Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. vdsm hooks: this patch provides after/before_network_setup hooks. This enables the capability to interact with physical network management interfaces, setting up extra parameters, or interacting with switches, etc. It also introduces a standard testing decorator for hook testcases. Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Signed-off-by: Miguel Angel Ajo miguelan...@ajo.es Reviewed-on: http://gerrit.ovirt.org/20076 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M AUTHORS M tests/Makefile.am M tests/functional/networkTests.py A tests/hookValidation.py M vdsm.spec.in M vdsm/configNetwork.py M vdsm/hooks.py M vdsm/vdsmd.8.in M vdsm_hooks/Makefile.am 9 files changed, 154 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Miguel Angel Ajo Pelayo: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4934/ : ABORTED http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4048/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/682/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 1: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4899/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4014/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4824/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/670/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 2: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4900/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4015/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4825/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/671/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 2: (4 comments) File AUTHORS Line 8:Federico Simoncelli fsimo...@redhat.com Line 9:Saggi Mizrahi smizr...@redhat.com Line 10: Line 11: Patches have also been contributed by (ordered by lastname): Line 12: trailing whitespace showing up as red in gerrit. Line 13:Miguel Angel Ajo miguelan...@ajo.es Line 14:Timothy Asir tjeya...@redhat.com Line 15:Haim Ateya hat...@redhat.com Line 16:Daniel P. Berrange berra...@redhat.com File tests/Makefile.am Line 104: apiData.py \ Line 105: monkeypatch.py \ Line 106: testrunner.py \ Line 107: testValidation.py \ Line 108: hookValidation.py Please keep sorted, and add a trailing $(NULL) at the end. Line 109: Line 110: dist_vdsmtests_SCRIPTS = \ Line 111: run_tests.sh \ Line 112: testValidation.py \ File vdsm/vdsmd.8.in Line 63: .FN /usr/libexec/vdsm/hooks/hook-name/ Line 64: in lexicographic order. Line 65: Line 66: .SS Hook environment Line 67: Each hook script (except before_vdsm_start, after_vdsm_stop, before_network_setup please keep under 80 chars. It's easier to review. Line 68: and after_network_setup)) inherit the environment of the VDSM process, with an Line 69: additional variable Line 70: .B _hook_domxml Line 71: which holds the path of libvirt's File vdsm_hooks/Makefile.am Line 100: after_disk_hotunplug \ Line 101: before_vdsm_start \ Line 102: after_vdsm_stop \ Line 103: before_network_setup \ Line 104: after_network_setup Could you append $(NULL) here, too? Line 105: Line 106: all-local: \ Line 107: $(nodist_vdsmexec_SCRIPTS) Line 108: -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 3: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4908/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4023/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4833/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_network_functional_tests/674/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 4: Code-Review-1 Please note few nit-picking on PS2 and PS3. Other than that, ACK. I believe that the Jenkins failure are unrelated. Toni - could you help here? Oct 10 11:43:59 jenkins-slave-vm01.ovirt.org vdsm[2744]: vdsm vds ERROR interface 'dummy_18' already member of network 'test-network' Oct 10 11:43:59 jenkins-slave-vm01.ovirt.org vdsm[2744]: vdsm vds ERROR interface 'dummy_18' already has networks -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 5: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4914/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4029/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4839/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/676/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 6: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4915/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4030/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4840/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/677/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 7: Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4916/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4031/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4841/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_network_functional_tests/678/ : FAILURE -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm hooks: this patch provides after/before_network_setup h...
Dan Kenigsberg has posted comments on this change. Change subject: vdsm hooks: this patch provides after/before_network_setup hooks. .. Patch Set 7: Code-Review+2 Thanks! -- To view, visit http://gerrit.ovirt.org/20076 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iac5c6f57b300b3b1a2a9bfad4a7919f4d8a74707 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Assaf Muller amul...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Miguel Angel Ajo Pelayo miguelan...@ajo.es Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
