Change in vdsm[master]: virt: Add Drive.chunked property

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 8:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 6:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 7:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 5:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-13 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 7:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2381/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15633/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14831/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15802/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/609/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-13 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 8:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/635/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/234/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4618/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/611/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/238/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/636/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/238/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/225/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/632/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6457/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Add Drive.chunked property
..


virt: Add Drive.chunked property

Previously the logic for extending a drive was part of the vm god-class.
This makes the code little more readable, and encapsulate the logic in a
better location.

Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Signed-off-by: Nir Soffer 
Reviewed-on: http://gerrit.ovirt.org/37570
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M tests/vmStorageTests.py
M vdsm/virt/vm.py
M vdsm/virt/vmdevices/storage.py
3 files changed, 32 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-13 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 7: Code-Review+2

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-12 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 7: Verified+1

Verified by provisioning vm on file and block domain, the disk on the block 
domain was extended twice as it should.

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-12 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 6: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-12 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37570/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 149: Return True if drive supports extending.
Line 150: 
Line 151: If a drive is extendable, current drive write watermark and
Line 152: Drive.volExtensionChunk is used to detect if a drive should be
Line 153: extended, and getNextVolumeSize to find the new size.
> In "closer to the implementation", do you mean to the code that perform ext
Yes that was I meant, and I'm ok with your plan outlined above. Actually I 
don't see any serious problem having this docstring here, so no big deal.
Line 154: """
Line 155: return self.blockDev and self.format == "cow"
Line 156: 
Line 157: @property


-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 6:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2374/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15586/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14784/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15755/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/562/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 6:

This version fixed bad rename.

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/37570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1407: # FIXME: mergeCandidates should be a dictionary of candidate 
volumes
Line 1408: # once libvirt starts reporting watermark information for 
all volumes.
Line 1409: mergeCandidates = {}
Line 1410: for drive in self._devices[hwclass.DISK]:
Line 1411: if not drive.extendable:
> chunked?  This is the first I've seen extendable.
Right, bad rename.
Line 1412: continue
Line 1413: 
Line 1414: capacity, alloc, physical = 
self._dom.blockInfo(drive.path, 0)
Line 1415: ret.append((drive, drive.volumeID, capacity, alloc, 
physical))


-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread alitke
Adam Litke has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/37570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1407: # FIXME: mergeCandidates should be a dictionary of candidate 
volumes
Line 1408: # once libvirt starts reporting watermark information for 
all volumes.
Line 1409: mergeCandidates = {}
Line 1410: for drive in self._devices[hwclass.DISK]:
Line 1411: if not drive.extendable:
chunked?  This is the first I've seen extendable.
Line 1412: continue
Line 1413: 
Line 1414: capacity, alloc, physical = 
self._dom.blockInfo(drive.path, 0)
Line 1415: ret.append((drive, drive.volumeID, capacity, alloc, 
physical))


-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2368/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15573/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14771/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15742/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/549/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 4:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2362/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15566/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14764/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15735/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/542/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: virt: Add Drive.chunked property

2015-02-11 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: virt: Add Drive.chunked property
..


Patch Set 4:

This version address Federico comments, replacing "extendable" with "chunked"

-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches