Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 15: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Add getReplicaXML method .. virt: Add getReplicaXML method This method returns destination disk xml required for blockCopy. We need basically the same logic for Drive and replic dict, so _getSourceXML() and _getDriverXML() are now module functions, accepting a dict like object. Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/40068 Continuous-Integration: Jenkins CI Reviewed-by: Federico Simoncelli --- M tests/vmStorageTests.py M vdsm/virt/vmdevices/storage.py 2 files changed, 154 insertions(+), 50 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Federico Simoncelli has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Nir Soffer has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 14: Verified+1 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 14: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 13: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Nir Soffer has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 12: Federico, I believe this version addresses your concerns. Would you review it again? -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 12: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 11: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 10: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Nir Soffer has posted comments on this change.
Change subject: virt: Add getReplicaXML method
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/40068/9/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line 140:
Line 141:
Line 143:
Line 144: """
> Since what you're checking here is hidden in xml can you add a comment on t
Good idea, I will improve the documentation in the next version.
Line 145: self.check({}, conf, xml, is_block_device=True)
Line 146:
Line 147: def test_block_to_file(self):
Line 148: conf = drive_config(
https://gerrit.ovirt.org/#/c/40068/9/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 398:
Line 399:
Line 400: def _getSourceXML(drive):
Line 401: source = vmxml.Element('source')
Line 402: if drive["diskType"] == DISK_TYPE.BLOCK:
> Is it necessary to translate self.diskType => drive["diskType"]
Where do you see self.diskType? I can find only one instance in line 345.
Line 403: source.setAttrs(dev=drive["path"])
Line 404: elif drive["diskType"] == DISK_TYPE.NETWORK:
Line 405: info = drive["volumeInfo"]
Line 406: source.setAttrs(protocol=info['protocol'],
Line 401: source = vmxml.Element('source')
Line 402: if drive["diskType"] == DISK_TYPE.BLOCK:
Line 403: source.setAttrs(dev=drive["path"])
Line 404: elif drive["diskType"] == DISK_TYPE.NETWORK:
Line 405: info = drive["volumeInfo"]
> You added info, but I think the least we change the better it is. You can r
I agree that it could be better to avoid this change for easier review, but I
don't want to introduce another trivial cleanup patch, specially when this code
will die soon (see https://gerrit.ovirt.org/38766)
Line 406: source.setAttrs(protocol=info['protocol'],
Line 407: name=info['path'])
Line 408: hostAttrs = {'name': info['volfileServer'],
Line 409: 'port': info['volPort'],
Line 421: def _getDriverXML(drive):
Line 422: driver = vmxml.Element('driver')
Line 423: driverAttrs = {'name': 'qemu'}
Line 424:
Line 425: if drive['diskType'] == DISK_TYPE.BLOCK:
> Are you sure that this change is ok? (aren't you introducing diskType later
This change *must* be here, because the function was using self.blockDev, but
now it must work with replica dict that does not have a "blockDev" key. Since
both the replica dict and the drive object have "diskType", I'm using it here.
self.blockDev depends on diskType != "network" and self._blockDev.
I'm working on simplifying this (see https://gerrit.ovirt.org/40472). The goal
is to eliminate both networkDev and blockDev, and keep only _blockDev for
supporting legacy engine that do not send diskType:
def diskType(self):
# New code must send a diskType
if hasattr(self, "_diskType"):
return self._diskType
# Backward compatibility for clients not sending diskType, supporting
# only file or block types.
if self._blockDev is None:
self._blockDev = ...
return DISK_TYPE.BLOCK if self._blockDev else DISK_TYPE.FILE
When migrating from one type to another, the drive.diskType will be updated by
the migration code.
Line 426: driverAttrs['io'] = 'native'
Line 427: else:
Line 428: driverAttrs['io'] = 'threads'
Line 429:
Line 431: driverAttrs['type'] = 'qcow2'
Line 432: elif drive['format']:
Line 433: driverAttrs['type'] = 'raw'
Line 434:
Line 435: try:
> This block changed significantly given the attribute => key switch. It seem
This is like the self.volumeInfo change - code became too ugly when you need to
check and get multiple levels of dictionaries, and using direct dictionary
lookup simplify things.
I can keep the old code if you like and add a trivial patch applying this
change and add the missing tests if you prefer.
Line 436: driverAttrs['iothread'] =
str(drive['specParams']['pinToIoThread'])
Line 437: except KeyError:
Line 438: pass
Line 439:
--
To view, visit https://gerrit.ovirt.org/40068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Federico Simoncelli has posted comments on this change.
Change subject: virt: Add getReplicaXML method
..
Patch Set 9:
(5 comments)
https://gerrit.ovirt.org/#/c/40068/9/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line 140:
Line 141:
Line 143:
Line 144: """
Since what you're checking here is hidden in xml can you add a comment on the
key features that you're effectively testing? For example:
# type: block (as destination)
# cache/error_policy: taken from replica definition
# io: native (for block destination)
Another option would be to make the code more explicit on what you're checking.
Same for all the other tests below.
Line 145: self.check({}, conf, xml, is_block_device=True)
Line 146:
Line 147: def test_block_to_file(self):
Line 148: conf = drive_config(
https://gerrit.ovirt.org/#/c/40068/9/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 398:
Line 399:
Line 400: def _getSourceXML(drive):
Line 401: source = vmxml.Element('source')
Line 402: if drive["diskType"] == DISK_TYPE.BLOCK:
Is it necessary to translate self.diskType => drive["diskType"]
Same for all the others that are switched from attributes to keys.
Line 403: source.setAttrs(dev=drive["path"])
Line 404: elif drive["diskType"] == DISK_TYPE.NETWORK:
Line 405: info = drive["volumeInfo"]
Line 406: source.setAttrs(protocol=info['protocol'],
Line 401: source = vmxml.Element('source')
Line 402: if drive["diskType"] == DISK_TYPE.BLOCK:
Line 403: source.setAttrs(dev=drive["path"])
Line 404: elif drive["diskType"] == DISK_TYPE.NETWORK:
Line 405: info = drive["volumeInfo"]
You added info, but I think the least we change the better it is. You can
refactor later. (Anyway it's up to you, it seems fine).
Line 406: source.setAttrs(protocol=info['protocol'],
Line 407: name=info['path'])
Line 408: hostAttrs = {'name': info['volfileServer'],
Line 409: 'port': info['volPort'],
Line 421: def _getDriverXML(drive):
Line 422: driver = vmxml.Element('driver')
Line 423: driverAttrs = {'name': 'qemu'}
Line 424:
Line 425: if drive['diskType'] == DISK_TYPE.BLOCK:
Are you sure that this change is ok? (aren't you introducing diskType later? I
don't think this change should be here)
self.blockDev => drive['diskType'] == DISK_TYPE.BLOCK
Line 426: driverAttrs['io'] = 'native'
Line 427: else:
Line 428: driverAttrs['io'] = 'threads'
Line 429:
Line 435: try
This block changed significantly given the attribute => key switch. It seems
fine but I still wonder if we need such a change.
--
To view, visit https://gerrit.ovirt.org/40068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Fred Rolland
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 9: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 8: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18384/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1614/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 6: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1614/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 6: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18384/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Adam Litke has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18183/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1413/ : 0 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 5: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1413/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 5: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18183/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Nir Soffer has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18137/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1367/ : 0 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 4: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1367/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 4: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18137/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18030/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1259/ : 0 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 3: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1259/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18030/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Nir Soffer has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18094/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17922/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18094/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17922/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Fred Rolland Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18064/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17893/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17893/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
automat...@ovirt.org has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Add getReplicaXML method .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18064/ -- To view, visit https://gerrit.ovirt.org/40068 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Add getReplicaXML method
Nir Soffer has uploaded a new change for review.
Change subject: virt: Add getReplicaXML method
..
virt: Add getReplicaXML method
This method returns destination disk xml required for blockCopy. We need
basically the same logic for Drive and replic dict, so _getSourceXML()
and _getDriverXML() are now module functions, accepting a dict like
object.
Change-Id: Iff17e0bfc86fbff9c817a2f126fb71706396833e
Signed-off-by: Nir Soffer
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 136 insertions(+), 46 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/40068/1
diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index 055d1c9..5cd9d54 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -25,7 +25,7 @@
from vdsm import constants
from vdsm import utils
-from virt.vmdevices.storage import Drive
+from virt.vmdevices.storage import Drive, DISK_TYPE
class DriveXMLTests(XMLTestCase):
@@ -128,6 +128,82 @@
self.assertXMLEqual(drive.getXML().toxml(), xml)
+class DriveReplicaXML(XMLTestCase):
+
+def test_block_to_block(self):
+conf = drive_config(
+format='cow',
+diskReplicate=replica(DISK_TYPE.BLOCK),
+)
+xml = """
+
+
+
+
+"""
+self.check({}, conf, xml, is_block_device=True)
+
+def test_block_to_file(self):
+conf = drive_config(
+format='cow',
+diskReplicate=replica(DISK_TYPE.FILE),
+)
+xml = """
+
+
+
+
+"""
+self.check({}, conf, xml, is_block_device=True)
+
+def test_file_to_file(self):
+conf = drive_config(
+format='cow',
+diskReplicate=replica(DISK_TYPE.FILE),
+)
+xml = """
+
+
+
+
+"""
+self.check({}, conf, xml, is_block_device=False)
+
+def test_file_to_block(self):
+conf = drive_config(
+format='cow',
+diskReplicate=replica(DISK_TYPE.BLOCK),
+)
+xml = """
+
+
+
+
+"""
+self.check({}, conf, xml, is_block_device=False)
+
+def check(self, vm_conf, device_conf, xml, is_block_device=False):
+drive = Drive(vm_conf, self.log, **device_conf)
+# Patch to skip the block device checking.
+drive._blockDev = is_block_device
+self.assertXMLEqual(drive.getReplicaXML().toxml(), xml)
+
+
+def replica(diskType):
+return {
+"cache": "none",
+"device": "disk",
+"diskType": diskType,
+"format": "cow",
+"path": "/path/to/replica",
+"propagateErrors": "off",
+}
+
+
@expandPermutations
class DriveValidation(VdsmTestCase):
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index af1ddd2..9f3f547 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -328,7 +328,7 @@
['device', 'address', 'sgio'])
diskelem.setAttrs(snapshot='no')
-diskelem.appendChild(self._getSourceXML())
+diskelem.appendChild(_getSourceXML(self))
diskelem.appendChild(self._getTargetXML())
if self.extSharedState == DRIVE_SHARED_TYPE.SHARED:
@@ -348,62 +348,29 @@
diskelem.appendChildWithArgs('boot', order=self.bootOrder)
if self.device == 'disk' or self.device == 'lun':
-diskelem.appendChild(self._getDriverXML())
+diskelem.appendChild(_getDriverXML(self))
if hasattr(self, 'specParams') and 'ioTune' in self.specParams:
diskelem.appendChild(self._getIotuneXML())
return diskelem
-def _getSourceXML(self):
-source = vmxml.Element('source')
-if self.diskType == DISK_TYPE.BLOCK:
-source.setAttrs(dev=self.path)
-elif self.diskType == DISK_TYPE.NETWORK:
-source.setAttrs(protocol=self.volumeInfo['protocol'],
-name=self.volumeInfo['path'])
-hostAttrs = {'name': self.volumeInfo['volfileServer'],
- 'port': self.volumeInfo['volPort'],
- 'transport': self.volumeInfo['volTransport']}
-source.appendChildWithArgs('host', **hostAttrs)
-elif self.diskType == DISK_TYPE.FILE:
-source.setAttrs(file=self.path)
-if self.device == 'cdrom' or self.device == 'floppy':
-source.setAttrs(startupPolicy='optional')
-else:
-raise RuntimeError("Unsupported diskType %r", self.diskType)
-return source
+def getReplicaXML(self):
+disk = vmxml.Element(
+"disk",
+
