Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Vinzenz Feenstra has uploaded a new change for review. Change subject: virt: Additional reporting of CPU usage in ns .. virt: Additional reporting of CPU usage in ns As per request, we're now additionally reporting the VM CPU usage in nanoseconds Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Bug-Url: https://bugzilla.redhat.com/1172153 Signed-off-by: Vinzenz Feenstra --- M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vm.py 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/38412/1 diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json index 717c933..f8669bd 100644 --- a/vdsm/rpc/vdsmapi-schema.json +++ b/vdsm/rpc/vdsmapi-schema.json @@ -6872,6 +6872,9 @@ # @ioTune: #optional Current QoS settings for IO devices # (new in version 4.15.0) # +# @cpuUsage: #optional Total cpu usage since VM start in ns +# (new in version 4.17.0) +# # Since: 4.10.0 ## {'type': 'RunningVmStats', @@ -6896,7 +6899,7 @@ '*vNodeRuntimeInfo': 'VmNumaNodeRuntimeInfoMap', 'displayInfo': ['VmDisplayInfo'], '*vcpuQuota': 'int', '*vcpuPeriod': 'int', '*vcpuCount': 'int', '*vcpuUserLimit': 'int', - '*ioTune': ['VmDiskDeviceTuneParams']}} + '*ioTune': ['VmDiskDeviceTuneParams'], '*cpuUsage': 'uint'}} ## # @VmStats: diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 58d0d67..cae5b27 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -486,6 +486,8 @@ - self._diff(eInfo, sInfo, 'user_time') - self._diff(eInfo, sInfo, 'system_time'), sampleInterval) +stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + +sInfo['system_time']) except (TypeError, ZeroDivisionError) as e: self._log.exception("CPU stats not available: %s", e) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Francesco Romani has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Code-Review+1 neat, and in retrospect makes sense :) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2634/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16282/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/15482/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16452/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Dan Kenigsberg has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38412/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 484: stats['cpuUser'] = self._usagePercentage( Line 485: self._diff(eInfo, sInfo, 'cpu_time') Line 486: - self._diff(eInfo, sInfo, 'user_time') Line 487: - self._diff(eInfo, sInfo, 'system_time'), Line 488: sampleInterval) unlike _usagePercentage(), we have no chance of ZeroDivisionError here. Even TypeError can be ruled out as of line 476. So please place out of try-block. Line 489: stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + Line 490: sInfo['system_time']) Line 491: Line 492: except (TypeError, ZeroDivisionError) as e: Line 485: self._diff(eInfo, sInfo, 'cpu_time') Line 486: - self._diff(eInfo, sInfo, 'user_time') Line 487: - self._diff(eInfo, sInfo, 'system_time'), Line 488: sampleInterval) Line 489: stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + I do not think we care about cpu_time. According to our own docs (I did not dive into libvirt's, so please verify) it is the wall time spent by the VM. We do not care about this, if the guest laid dormant. This feature is about reporting the resources consumed by the VM, which is the sum of user and system time. Line 490: sInfo['system_time']) Line 491: Line 492: except (TypeError, ZeroDivisionError) as e: Line 493: self._log.exception("CPU stats not available: %s", e) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
automat...@ovirt.org has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: * Update tracker::#1172153::OK * Check Bug-Url::OK * Check Public Bug::#1172153::OK, public bug * Check Product::#1172153::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
automat...@ovirt.org has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 2: * Update tracker::#1172153::OK * Check Bug-Url::OK * Check Public Bug::#1172153::OK, public bug * Check Product::#1172153::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38412/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 484: stats['cpuUser'] = self._usagePercentage( Line 485: self._diff(eInfo, sInfo, 'cpu_time') Line 486: - self._diff(eInfo, sInfo, 'user_time') Line 487: - self._diff(eInfo, sInfo, 'system_time'), Line 488: sampleInterval) > unlike _usagePercentage(), we have no chance of ZeroDivisionError here. Eve Done Line 489: stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + Line 490: sInfo['system_time']) Line 491: Line 492: except (TypeError, ZeroDivisionError) as e: Line 485: self._diff(eInfo, sInfo, 'cpu_time') Line 486: - self._diff(eInfo, sInfo, 'user_time') Line 487: - self._diff(eInfo, sInfo, 'system_time'), Line 488: sampleInterval) Line 489: stats['cpuUsage'] = str(sInfo['cpu_time'] + sInfo['user_time'] + > I do not think we care about cpu_time. According to our own docs (I did not Yes you're right. I have removed it Line 490: sInfo['system_time']) Line 491: Line 492: except (TypeError, ZeroDivisionError) as e: Line 493: self._log.exception("CPU stats not available: %s", e) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 2: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17846/ -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18017/ -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 3: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18019/ -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
automat...@ovirt.org has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 3: * Update tracker::#1172153::OK * Check Bug-Url::OK * Check Public Bug::#1172153::OK, public bug * Check Product::#1172153::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 3: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17848/ -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18017/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17846/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18019/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17848/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Francesco Romani has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
automat...@ovirt.org has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 4: * Update tracker::#1172153::OK * Check Bug-Url::OK * Check Public Bug::#1172153::OK, public bug * Check Product::#1172153::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Francesco Romani has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Additional reporting of CPU usage in ns .. virt: Additional reporting of CPU usage in ns As per request, we're now additionally reporting the VM CPU usage in nanoseconds Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Bug-Url: https://bugzilla.redhat.com/1172153 Signed-off-by: Vinzenz Feenstra Reviewed-on: https://gerrit.ovirt.org/38412 Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M vdsm/rpc/vdsmapi-schema.json M vdsm/virt/vmstats.py 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Vinzenz Feenstra: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
automat...@ovirt.org has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 5: * Update tracker::#1172153::OK * Check TR::#1172153::ERROR, 3.6.0 should not match .* -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Dan Kenigsberg has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Additional reporting of CPU usage in ns
Arik Hadas has posted comments on this change. Change subject: virt: Additional reporting of CPU usage in ns .. Patch Set 5: is it possible that if I don't have guest-agent, I'll get the following error? GuestMonitor-eldan_shmuel::ERROR::2015-05-12 14:17:42,035::vm::1313::vm.Vm::(_getRunningVmStats) vmId=`c764b14b-3272-46db-93b6-f200ed7e8c5b`::Error fetching vm stats Traceback (most recent call last): File "/usr/share/vdsm/virt/vm.py", line 1310, in _getRunningVmStats vm_sample.interval) File "/usr/share/vdsm/virt/vmstats.py", line 37, in produce cpu(stats, first_sample, last_sample, interval) File "/usr/share/vdsm/virt/vmstats.py", line 78, in cpu stats['cpuUsage'] = str(last_sample['system_time'] KeyError: 'system_time' -- To view, visit https://gerrit.ovirt.org/38412 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31fb4305511f0c2174b217ac24f0d96767c31803 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches