Change in vdsm[master]: virt: Fix limit when calculating next volume size
automat...@ovirt.org has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
automat...@ovirt.org has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
automat...@ovirt.org has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
automat...@ovirt.org has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
automat...@ovirt.org has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 5: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/251/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4635/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/628/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/653/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/255/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/243/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/650/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6474/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Fix limit when calculating next volume size .. virt: Fix limit when calculating next volume size Drive.getNextVolumeSize() limit was wrong in two ways. First, Drive.truesize is *not* the drive true size on block-based drive (it is a duplicate of Drive.apparentsize). Second, Drive.truesize is using bytes but the code assumed that it is using megabytes. The result was that next volume size was limited only by the vg free size. Drive.getNextVolumeSize() requires now a capacity argument. To prevent the confusion with mixing different size units, we use now safer naming convention. Vm.extendDriveVolume() requires now a capacity argument. The capacity was already available but unused in the drive monitoring code. When starting live storage migration or live merge, we use now libvirt.virDomain.blockInfo() to get drive capacity for the initial extension. Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/37726 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M tests/vmStorageTests.py M vdsm/virt/vm.py M vdsm/virt/vmdevices/storage.py 3 files changed, 37 insertions(+), 10 deletions(-) Approvals: Nir Soffer: Verified Adam Litke: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Dan Kenigsberg has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/37726/4//COMMIT_MSG Commit Message: Line 9: Drive.getNextVolumeSize() limit was wrong in two ways. First, Line 10: Drive.truesize is *not* the drive true size on block-based drive (it Line 11: is a duplicate of Drive.apparentsize). Second, Drive.truesize is using Line 12: bytes but the code assumed that it is using megabytes. The result was Line 13: that next volume size was limited only by the vg free size. Please consider backporting a fix for that; we attempted to safeguard against a qemu/qcow bug causing complete vg consumption by a single disk. Line 14: Line 15: Drive.getNextVolumeSize() requires now a capacity argument. To prevent Line 16: the confusion with mixing different size units, we use now safer naming Line 17: convention. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2390/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15689/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14888/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15858/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/665/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2391/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15690/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14889/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15859/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/666/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Adam Litke has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 4: Verified+1 Verified on rhel 7 and fedoar 21: lsm - rhel 7 - lsm during install - block/cow - extend during dd - block/cow - lsm during dd - block/file/cow/raw live-merge - fedora 21: - remove second snapshot block/file/qcow/raw There are few issues with live-merge on fedora 21, but they exists also on master and not related to this change. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Francesco Romani has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 3: This version fixes copy and paste error. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: -Verified Verified by the tests, but I want to check also real extend flows and LSM. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2382/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15634/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14832/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15803/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/610/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 2: Verified-1 This patch correct, limiting extend size to Drive.truesize. However, Drive.truesize is not true! After creating a snapshot, it is always 1 GiB, so a snapshot is never extended more then 1 GiB, and the vm will finally pause. We must fix Drive.truesize first. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Francesco Romani has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Code-Review+1 (1 comment) patch seems fine. I wonder why this never exploded before. Or it did? http://gerrit.ovirt.org/#/c/37726/1//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-02-11 19:16:51 +0200 Line 6: Line 7: virt: Fix limit when calculating next volume size Line 8: Line 9: Drive.getNextVolumeSize limit was wrong, since Drive.truesize is using that's scary! Line 10: bytes and the result in in megabytes. We use safer naming convention now Line 11: to avoid future confusion. Line 12: Line 13: Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has uploaded a new change for review. Change subject: virt: Fix limit when calculating next volume size .. virt: Fix limit when calculating next volume size Drive.getNextVolumeSize limit was wrong, since Drive.truesize is using bytes and the result in in megabytes. We use safer naming convention now to avoid future confusion. Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Signed-off-by: Nir Soffer nsof...@redhat.com --- M tests/vmStorageTests.py M vdsm/virt/vmdevices/storage.py 2 files changed, 3 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/37726/1 diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py index 925d52d..d661401 100644 --- a/tests/vmStorageTests.py +++ b/tests/vmStorageTests.py @@ -19,7 +19,6 @@ # from monkeypatch import MonkeyPatch -from testValidation import brokentest from testlib import VdsmTestCase from testlib import XMLTestCase from testlib import permutations, expandPermutations @@ -252,7 +251,6 @@ size_mb = apparentsize_mb + drive.volExtensionChunk self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), size_mb) -@brokentest() def test_truesize_limit(self): drive = self.chunked_drive(8191, 8192) self.assertEqual(drive.getNextVolumeSize(drive.apparentsize), 8192) diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py index 7ef7f19..800128d 100644 --- a/vdsm/virt/vmdevices/storage.py +++ b/vdsm/virt/vmdevices/storage.py @@ -139,9 +139,9 @@ to be extended. For the leaf volume curSize == self.apparentsize. For internal volumes it is discovered by calling irs.getVolumeSize(). -nextSize = (self.volExtensionChunk + -((curSize + constants.MEGAB - 1) / constants.MEGAB)) -return min(nextSize, self.truesize) +curSizeMB = (curSize + constants.MEGAB - 1) / constants.MEGAB +nextSizeMB = curSizeMB + self.volExtensionChunk +return min(nextSizeMB, self.truesize / constants.MEGAB) @property def chunked(self): -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Verified using the tests. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
Nir Soffer has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Verified+1 Verified using the tests. -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Fix limit when calculating next volume size
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Fix limit when calculating next volume size .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2376/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15589/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14787/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15758/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/565/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
