Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-05 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: virt: Invalidate drive blockDev when path changes
..

virt: Invalidate drive blockDev when path changes

After live storage migration between mixed domain types, a drive
blockDev must be reinitialized. We initialize this property in __init__
for cdrom or floppy devices, or lazily for other devices, and cache the
computed value for later calls.

The initialization was moved to single location, to make it easier to
understand the code.

Drive.path is now a property so modifying it after LSM invalidates
cached blockDev value.

Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Signed-off-by: Nir Soffer 
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 53 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/37552/1

diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index 86996b0..307b0d8 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -191,6 +191,38 @@
 self.assertFalse(drive.networkDev)
 self.assertFalse(drive.blockDev)
 
+@MonkeyPatch(utils, 'isBlockDevice', lambda path: False)
+def test_migrate_from_file_to_block(self):
+conf = drive_config(path='/filedomain/volume')
+drive = Drive({}, self.log, **conf)
+self.assertFalse(drive.blockDev)
+# Migrate drive to block domain...
+utils.isBlockDevice = lambda path: True
+drive.path = "/blockdomain/volume"
+self.assertTrue(drive.blockDev)
+
+@MonkeyPatch(utils, 'isBlockDevice', lambda path: True)
+def test_migrate_from_block_to_file(self):
+conf = drive_config(path='/blockdomain/volume')
+conf = drive_config(device='disk')
+drive = Drive({}, self.log, **conf)
+self.assertTrue(drive.blockDev)
+# Migrate drive to file domain...
+utils.isBlockDevice = lambda path: False
+drive.path = "/filedomain/volume"
+self.assertFalse(drive.blockDev)
+
+@MonkeyPatch(utils, 'isBlockDevice', lambda path: True)
+def test_migrate_from_block_to_network(self):
+conf = drive_config(path='/blockdomain/volume')
+conf = drive_config(device='disk')
+drive = Drive({}, self.log, **conf)
+self.assertTrue(drive.blockDev)
+# Migrate drive to netowrk (not sure we will support this)...
+drive.path = "rbd:pool/volume"
+drive.volumeInfo = {'volType': 'network'}
+self.assertFalse(drive.blockDev)
+
 
 def drive_config(**kw):
 """ Reutrn drive configuration updated from **kw """
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 780ffc1..39c4a65 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -40,7 +40,7 @@
 
 
 class Drive(Base):
-__slots__ = ('iface', 'path', 'readonly', 'bootOrder', 'domainID',
+__slots__ = ('iface', '_path', 'readonly', 'bootOrder', 'domainID',
  'poolID', 'imageID', 'UUID', 'volumeID', 'format',
  'propagateErrors', 'address', 'apparentsize', 'volumeInfo',
  'index', 'name', 'optional', 'shared', 'truesize',
@@ -62,10 +62,7 @@
 self.name = self._makeName()
 self.cache = config.get('vars', 'qemu_drive_cache')
 
-if self.device in ("cdrom", "floppy"):
-self._blockDev = False
-else:
-self._blockDev = None
+self._blockDev = None  # Lazy initialized
 
 self._customize()
 self._setExtSharedState()
@@ -156,18 +153,29 @@
 
 @property
 def blockDev(self):
-if self.networkDev:
-return False
-
 if self._blockDev is None:
-try:
-self._blockDev = utils.isBlockDevice(self.path)
-except Exception:
-self.log.debug("Unable to determine if the path '%s' is a "
-   "block device", self.path, exc_info=True)
+if self.networkDev or self.device in ("cdrom", "floppy"):
+self._blockDev = False
+else:
+try:
+self._blockDev = utils.isBlockDevice(self.path)
+except Exception:
+self.log.debug("Unable to determine if the path '%s' is a "
+   "block device", self.path, exc_info=True)
 return self._blockDev
 
 @property
+def path(self):
+return self._path
+
+@path.setter
+def path(self, path):
+self._path = path
+# After live storage migration domain type may have changed
+# invalidating cached blockDev.
+self._blockDev = None
+
+@property
 def transientDisk(self):
 # Using getattr to handle legacy and removable drives.
 return getattr(self, 'shared', None) == DRIVE_SHARED_TYPE.TRANSIENT


-- 
To view, visi

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-05 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2318/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15457/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14654/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15626/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-05 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 1:

Verified by the tests, need additional functional testing using live storage 
migration and other flows.

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-09 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2364/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15568/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14766/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15737/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/544/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-11 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 3:

This version fixes copy and paste error in the tests.

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-11 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 3:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2370/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15575/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14773/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15744/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/551/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-11 Thread alitke 
Adam Litke has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-12 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 3: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-12 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 4: Verified+1

This version invalidates _blockDev only when path changes, and log the new and 
old values for easier debugging.

Verified by performing live storage migration on file and block storage domain.

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-13 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 4: Code-Review+1

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-13 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 4: Code-Review+2

raising

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-13 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Invalidate drive blockDev when path changes
..


virt: Invalidate drive blockDev when path changes

After live storage migration between mixed domain types, a drive
blockDev must be reinitialized. We initialize this property in __init__
for cdrom or floppy devices, or lazily for other devices, and cache the
computed value for later calls.

The initialization was moved to single location, to make it easier to
understand the code.

Drive.path is now a property so modifying it after LSM invalidates
cached blockDev value.

For easier debugging, each time Drive.path changes we log the old and
new values.

Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Signed-off-by: Nir Soffer 
Reviewed-on: http://gerrit.ovirt.org/37552
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 54 insertions(+), 13 deletions(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-13 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 5:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/634/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/233/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4617/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/610/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/237/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/635/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/237/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/224/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/631/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6456/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-02-13 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 4:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2385/ : 
There was an infra issue, please contact in...@ovirt.org

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15638/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14836/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15807/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/614/ : 
FAILURE

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 3:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 4:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Invalidate drive blockDev when path changes

2015-03-15 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Invalidate drive blockDev when path changes
..


Patch Set 5:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit http://gerrit.ovirt.org/37552
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I387dd55843701597f595eb234d30db44a93a8535
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches