Change in vdsm[master]: virt: Move status constant to vmstatus
automat...@ovirt.org has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
automat...@ovirt.org has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
automat...@ovirt.org has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/627/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/226/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4610/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/603/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/628/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/230/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/216/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/623/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6449/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Dan Kenigsberg has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: Move status constant to vmstatus .. virt: Move status constant to vmstatus _get_lastStatus was creating a temporary tuple using values from vmstatus. The repeating "vmstatus." tells us that the code belongs to the vmstatus module. Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Signed-off-by: Nir Soffer Reviewed-on: http://gerrit.ovirt.org/37677 Reviewed-by: Francesco Romani Reviewed-by: Vinzenz Feenstra Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vm.py M vdsm/virt/vmstatus.py 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Nir Soffer: Verified Vinzenz Feenstra: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Francesco Romani has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2349/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15543/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14741/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15712/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/519/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
oVirt Jenkins CI Server has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_virt_functional_tests_gerrit/2348/ : There was an infra issue, please contact in...@ovirt.org http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/15542/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/14740/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/15711/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created_staging/518/ : FAILURE -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Nir Soffer has posted comments on this change. Change subject: virt: Move status constant to vmstatus .. Patch Set 2: Verified+1 Verified by the tests. -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: Move status constant to vmstatus
Nir Soffer has uploaded a new change for review. Change subject: virt: Move status constant to vmstatus .. virt: Move status constant to vmstatus _get_lastStatus was creating a temporary tuple using values from vmstatus. The repeating "vmstatus." in this tuple tells us that the code belongs in the vmstatus module. Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Signed-off-by: Nir Soffer --- M vdsm/virt/vm.py M vdsm/virt/vmstatus.py 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/37677/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index dc513cf..fd138ad 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -879,10 +879,8 @@ # note that we don't use _statusLock here. One of the reasons is the # non-obvious recursive locking in the following flow: # _set_lastStatus() -> saveState() -> status() -> _get_lastStatus(). -PAUSED_STATES = (vmstatus.POWERING_DOWN, vmstatus.REBOOT_IN_PROGRESS, - vmstatus.UP) status = self._lastStatus -if not self._guestCpuRunning and status in PAUSED_STATES: +if not self._guestCpuRunning and status in vmstatus.PAUSED_STATES: return vmstatus.PAUSED return status diff --git a/vdsm/virt/vmstatus.py b/vdsm/virt/vmstatus.py index ffab32c..d58c1a3 100644 --- a/vdsm/virt/vmstatus.py +++ b/vdsm/virt/vmstatus.py @@ -29,3 +29,5 @@ RESTORING_STATE = 'Restoring state' SAVING_STATE = 'Saving State' WAIT_FOR_LAUNCH = 'WaitForLaunch' + +PAUSED_STATES = (POWERING_DOWN, REBOOT_IN_PROGRESS, UP) -- To view, visit http://gerrit.ovirt.org/37677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iad4e2bca91710848a6178f8bbde922bee1ba1cde Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
