Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: virt: Set defualt device in __init__
..


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/40063/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-04-20 09:19:43 +0300
Line 4: Commit: Nir Soffer 
Line 5: CommitDate: 2015-04-21 00:43:45 +0300
Line 6: 
Line 7: virt: Set defualt device in __init__
typo: "defualt" vs "default"
Line 8: 
Line 9: Set Drive.device in __init__ instead of getXML().
Line 10: 
Line 11: Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6


https://gerrit.ovirt.org/#/c/40063/1/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 321
Line 322
Line 323
Line 324
Line 325
not sure why it was that way, most likely a relic of past times. Anyway, the 
new way looks just better.


-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: virt: Set defualt device in __init__
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Set defualt device in __init__
..


Patch Set 1:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18059/ : FAILURE

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17888/ : SUCCESS

-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Set defualt device in __init__
..


Patch Set 1:

Build Started (1/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17888/

-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: virt: Set defualt device in __init__
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: virt: Set defualt device in __init__
..


Patch Set 1:

Build Started (2/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18059/

-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Set defualt device in __init__

2015-04-20 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: virt: Set defualt device in __init__
..

virt: Set defualt device in __init__

Set Drive.device in __init__ instead of getXML().

Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Signed-off-by: Nir Soffer 
---
M vdsm/virt/vmdevices/storage.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/40063/1

diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 12625f1..8cb78fb 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -65,6 +65,7 @@
 if not kwargs.get('serial'):
 self.serial = kwargs.get('imageID'[-20:]) or ''
 super(Drive, self).__init__(conf, log, **kwargs)
+self.device = getattr(self, 'device', 'disk')
 # Keep sizes as int
 self.reqsize = int(kwargs.get('reqsize', '0'))  # Backward compatible
 self.truesize = int(kwargs.get('truesize', '0'))
@@ -322,8 +323,6 @@
   54-a672-23e5b495a9ea
 
 """
-self.device = getattr(self, 'device', 'disk')
-
 source = vmxml.Element('source')
 if self.diskType == DISK_TYPE.BLOCK:
 source.setAttrs(dev=self.path)


-- 
To view, visit https://gerrit.ovirt.org/40063
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I533c25075869d8e233e02f7f314d27f13fe203f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches