Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has uploaded a new change for review.
Change subject: virt: add kernel cmdline reporting
..
virt: add kernel cmdline reporting
As we want to control kernel command line from ovirt, we need a way to
let users (and us) see if the changes are successfully applied. We
approach this by reporting kernel command line from /proc/cmdline
without any modifications, allowing for relatively easy debugging.
Name kernelArgs was chosen as we already refer in the same way to guest
kernel arguments.
Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301104
Signed-off-by: Martin Polednik
---
M lib/vdsm/osinfo.py
M vdsm/caps.py
2 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/57084/1
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index 3b3aeb1..58097c2 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -121,6 +121,12 @@
@utils.memoized
+def kernel_args():
+with open('/proc/cmdline', 'r') as f:
+return f.readline().strip()
+
+
+@utils.memoized
def version():
version = release_name = ''
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 66eb245..42bddbe 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -176,6 +176,7 @@
caps['operatingSystem'] = osinfo.version()
caps['uuid'] = host.uuid()
caps['packages2'] = osinfo.package_versions()
+caps['kernelArgs'] = osinfo.kernel_args()
caps['emulatedMachines'] = machinetype.emulated_machines(
cpuarch.effective())
caps['ISCSIInitiatorName'] = _getIscsiIniName()
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 1: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 2: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/57084/2/tests/capsTests.py File tests/capsTests.py: PS2, Line 143: def testKernelArgs(self, kernel_args): : with tempfile.NamedTemporaryFile() as f: : f.write(kernel_args) : actual_args = osinfo.kernel_args(f.name) : : self.assertEqual(kernel_args, actual_args) unrelated artifact from local version -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 3: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 3: Code-Review+1 (1 comment) looks ok, but please check the inline comments https://gerrit.ovirt.org/#/c/57084/3/tests/osinfo_test.py File tests/osinfo_test.py: PS3, Line 31: ChunkedTests why "Chunked" ? -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 4: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 4: Code-Review-1 codewise fine, but you seem to miss the schema updates -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 5: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 6: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Michal Skrivanek has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 7: Verified+1 jenkins unrelated -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 7: Code-Review+2
(1 comment)
looks ok, tested and very low risk. Silly comment inside. Taking ownership (+2
instead of +1) because this is a virt flow.
https://gerrit.ovirt.org/#/c/57084/7/vdsm/caps.py
File vdsm/caps.py:
Line 175:
Line 176: caps['operatingSystem'] = osinfo.version()
Line 177: caps['uuid'] = host.uuid()
Line 178: caps['packages2'] = osinfo.package_versions()
Line 179: caps['kernelArgs'] = osinfo.kernel_args('/proc/cmdline')
IMHO nicer with the default argument
Line 180: caps['emulatedMachines'] = machinetype.emulated_machines(
Line 181: cpuarch.effective())
Line 182: caps['ISCSIInitiatorName'] = _getIscsiIniName()
Line 183: caps['HBAInventory'] = storage.hba.HBAInventory()
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/57084/7/vdsm/caps.py
File vdsm/caps.py:
Line 175:
Line 176: caps['operatingSystem'] = osinfo.version()
Line 177: caps['uuid'] = host.uuid()
Line 178: caps['packages2'] = osinfo.package_versions()
Line 179: caps['kernelArgs'] = osinfo.kernel_args('/proc/cmdline')
> IMHO nicer with the default argument
True, fixed.
Line 180: caps['emulatedMachines'] = machinetype.emulated_machines(
Line 181: cpuarch.effective())
Line 182: caps['ISCSIInitiatorName'] = _getIscsiIniName()
Line 183: caps['HBAInventory'] = storage.hba.HBAInventory()
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 8: please rebase on top of gerrit to make jenkins happy. -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 9: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 10: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 11: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 12: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Dan Kenigsberg has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 12: Code-Review-1 until we drop schema.json, we need to keep .yml up to date as well (we more days, I hope) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 13: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 14: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 14: Code-Review-1 (2 comments) the YML schema needs some more (minor) fixes, otherwise looks ok https://gerrit.ovirt.org/#/c/57084/14/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS14, Line 6272: /proc/cmdline)' bad indentation? (see other descriptions) PS14, Line 6273: s trailing whitespace -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/57084/14/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS14, Line 6272: /proc/cmdline)' > bad indentation? (see other descriptions) wish it failed the tests or did something, fixed PS14, Line 6273: s > trailing whitespace as above -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 15: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 15: Code-Review+1 schema looks good now. Temprary lowering my score to let Piotr review. -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Piotr Kliczewski has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 15: Code-Review+2 Raising Francesco's score -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 15: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Dan Kenigsberg has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 15: Code-Review-1 "until we drop schema.json, we need to keep .yml up to date as well (we more days, I hope)" - and now we need to revert this change, sorry! -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 16: * #1301104::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1301104::OK, public bug * Check Product::#1301104::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6']) -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Francesco Romani has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 16: Code-Review+2 thanks for the updates, this should be ready now. -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Piotr Kliczewski has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 16: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Martin Polednik has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 16: Verified+1 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: add kernel cmdline reporting .. virt: add kernel cmdline reporting As we want to control kernel command line from ovirt, we need a way to let users (and us) see if the changes are successfully applied. We approach this by reporting kernel command line from /proc/cmdline without any modifications, allowing for relatively easy debugging. Name kernelArgs was chosen as we already refer in the same way to guest kernel arguments. Also, using this patch as an opportunity to boostrap osinfo tests. Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1301104 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/57084 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski --- M lib/api/vdsm-api.yml M lib/vdsm/osinfo.py M tests/Makefile.am A tests/osinfo_test.py M vdsm/caps.py 5 files changed, 59 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: add kernel cmdline reporting
gerrit-hooks has posted comments on this change. Change subject: virt: add kernel cmdline reporting .. Patch Set 17: * #1301104::Update tracker: OK * Set MODIFIED::bug 1301104#1301104IGNORE, not all related patches are closed, check 56284 -- To view, visit https://gerrit.ovirt.org/57084 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cfb9bef65391b9ae6fff7abeb9da64408f90ad5 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
