Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 3: Arik, can you submit this also to ovirt-3.6 branch? -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has submitted this change and it was merged. Change subject: virt: hibernation - use r+ to open vm conf file .. virt: hibernation - use r+ to open vm conf file Complementary part of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 for vm hibernation. Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Signed-off-by: Arik Hadas Reviewed-on: https://gerrit.ovirt.org/48826 Reviewed-by: Nir Soffer Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M vdsm/virt/migration.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
gerrit-hooks has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Waiting for Dan -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Done -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Arik, can you get jenkins to be happy with your patch, or explain the failures? -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Francesco Romani has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Code-Review+2 Right, I missed (for completely silly reasons) to point out to check and fix this in review of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Code-Review+2 Waiting for Francesco review. -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: Done -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
gerrit-hooks has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Nir Soffer has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 1: Code-Review+1 Thanks Arik! Would add the same comment above the open call like in Daniel patch? -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
Arik Hadas has uploaded a new change for review. Change subject: virt: hibernation - use r+ to open vm conf file .. virt: hibernation - use r+ to open vm conf file Complementary part of Ic6799e07898155fd4a630bfaf4151ea9ccdcee49 for vm hibernation. Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Signed-off-by: Arik Hadas --- M vdsm/virt/migration.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/26/48826/1 diff --git a/vdsm/virt/migration.py b/vdsm/virt/migration.py index de1c4f2..4765f27 100644 --- a/vdsm/virt/migration.py +++ b/vdsm/virt/migration.py @@ -231,7 +231,7 @@ fname = self._vm.cif.prepareVolumePath(self._dstparams) try: -with open(fname, "w") as f: +with open(fname, "r+") as f: pickle.dump(self._machineParams, f) finally: self._vm.cif.teardownVolumePath(self._dstparams) -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: hibernation - use r+ to open vm conf file
gerrit-hooks has posted comments on this change. Change subject: virt: hibernation - use r+ to open vm conf file .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/48826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75bb6c69541678ea9b0ede4a917318075bfe25c6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
