Change in vdsm[master]: vm: Set numatune and guest numa topology
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Set numatune and guest numa topology .. vm: Set numatune and guest numa topology Modify vm module to provide the functions of set numatune and guest numa topology when create vm. Modify vdsClient to add the related options. The xml format of numatune is like: domain ... numatune memory mode=strict nodeset=1-4,^3/ /numatune ... /domain The format of guest numa topology is like: cpu ... numa cell cpus='0-3' memory='512000'/ cell cpus='4-7' memory='512000'/ /numa ... /cpu More detailed libvirt reference in: http://libvirt.org/formatdomain.html#elementsNUMATuning and http://libvirt.org/formatdomain.html#elementsCPU Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Bug-Url: https://bugzilla.redhat.com/1069303 Signed-off-by: Bruce Shi xiao-lei@hp.com Reviewed-on: http://gerrit.ovirt.org/25254 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M client/vdsClient.py M tests/vdsClientTests.py M tests/vmTests.py M tests/vmTestsData.py M vdsm/vm.py M vdsm_api/vdsmapi-schema.json 6 files changed, 127 insertions(+), 8 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Xiaolei Shi: Verified -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Dan Kenigsberg has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 3: No Builds Executed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6756/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7546/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7656/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Francesco Romani has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 2: Code-Review+1 looks OK. It seems already OK, but please be careful when adding CPU features: make sure PPC64 supports them, or add them only in the X86_64 path. Once again: at glance it seems already OK but I was bitten by this once and I'd like to point out. -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Dan Kenigsberg has posted comments on this change.
Change subject: vm: Set numatune and guest numa topology
..
Patch Set 2: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/25254/2/vdsm/vm.py
File vdsm/vm.py:
Line 1131: numa = XMLElement('numa')
Line 1132: guestNumaNodes = self.conf.get('guestNumaNodes')
Line 1133: for vmCell in guestNumaNodes:
Line 1134: numa.appendChildWithArgs('cell',
Line 1135:
cpus=vmCell['cpus'].replace(;, ,),
Would you explain why do we need this special handling of the semicolon? Why
should we accept both colon and semicolon for the same purpose? At the least,
please document this oddity in the commit message.
Line 1136:
memory=str(vmCell['memory']))
Line 1137: cpu.appendChild(numa)
Line 1138:
Line 1139: self.dom.appendChild(cpu)
--
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Gilad Chaplik gchap...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Saggi Mizrahi has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 2: Code-Review+1 Looks decent enough. -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Adam Litke has posted comments on this change.
Change subject: vm: Set numatune and guest numa topology
..
Patch Set 1: Code-Review-1
(2 comments)
Thanks for the patch! On the next submission I hope you will include the
changes to vdsmapi-schema.json so we can discuss the API a bit more thoroughly.
http://gerrit.ovirt.org/#/c/25254/1/vdsm/vm.py
File vdsm/vm.py:
Line 1136: numa = XMLElement('numa')
Line 1137: vmNumaTopology = self.conf.get('vmNumaTopology')
Line 1138: for vmCell in vmNumaTopology:
Line 1139: numa.appendChildWithArgs('cell',
Line 1140:
cpus=vmCell['cpus'].replace(;, ,),
Something seems strange here. If you want commas, why not make them part of
the format of vmNumaTopology to begin with? Maybe you need to model this a bit
differently in the API.
Line 1141: memory=vmCell['memory'])
Line 1142: cpu.appendChild(numa)
Line 1143:
Line 1144: self.dom.appendChild(cpu)
Line 1157: if ('nodeset' in numaMemory.keys()):
Line 1158: mode = 'strict'
Line 1159: if ('mode' in numaMemory.keys()):
Line 1160: mode = numaMemory['mode']
Line 1161: nodeset = numaMemory['nodeset'].replace(';', ',')
same comment about replacing ; with ,
Line 1162: numatune = XMLElement('numatune')
Line 1163: numatune.appendChildWithArgs('memory', mode=mode,
Line 1164: nodeset=nodeset)
Line 1165: self.dom.appendChild(numatune)
--
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
Vinzenz Feenstra has posted comments on this change.
Change subject: vm: Set numatune and guest numa topology
..
Patch Set 1: Code-Review-1
(2 comments)
Please update vdsm_api/vdsmapi-schema.json if you modify the API
Also I don't like the inconsistency of 'vmNumaTopology' vs 'numaMemory'
http://gerrit.ovirt.org/#/c/25254/1/vdsm/vm.py
File vdsm/vm.py:
Line 1157:
unnecessary paranthesis
Line 1155: if 'numaMemory' in self.conf:
Line 1156: numaMemory = self.conf.get('numaMemory')
Line 1157: if ('nodeset' in numaMemory.keys()):
Line 1158: mode = 'strict'
Line 1159: if ('mode' in numaMemory.keys()):
same here
But better would be:
mode = numaMemory.get('mode', 'strict')
Which defaults to strict when mode not present
Line 1160: mode = numaMemory['mode']
Line 1161: nodeset = numaMemory['nodeset'].replace(';', ',')
Line 1162: numatune = XMLElement('numatune')
Line 1163: numatune.appendChildWithArgs('memory', mode=mode,
--
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7386/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6594/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7496/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: Set numatune and guest numa topology
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: Set numatune and guest numa topology .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6594/ : To avoid overloading the infrastructure, a whitelist for running gerrit triggered jobs has been set in place, if you feel like you should be in it, please contact infra at ovirt dot org. http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7496/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7387/ : FAILURE -- To view, visit http://gerrit.ovirt.org/25254 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: Xiaolei Shi xiao-lei@hp.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
