Change in vdsm[master]: vm: devices: replace Sound device info

[Jenkins CI RO]

Jenkins CI RO has abandoned this change.

Change subject: vm: devices: replace Sound device info
..


Abandoned

Abandoned due to no activity - please restore if still relevant

-- 
To view, visit https://gerrit.ovirt.org/50196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: devices: replace Sound device info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: devices: replace Sound device info
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/50196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: devices: replace Sound device info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: devices: replace Sound device info
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: devices: replace Sound device info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: devices: replace Sound device info
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: devices: replace Sound device info

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: devices: replace Sound device info
..

vm: devices: replace Sound device info

Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 29 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/50196/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 6565bf6..378fd4c 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1695,7 +1695,7 @@
 """
 self._getUnderlyingNetworkInterfaceInfo()
 self._getUnderlyingDriveInfo()
-self._getUnderlyingSoundDeviceInfo()
+self._getUnderlyingDeviceInfo(hwclass.SOUND)
 self._getUnderlyingDeviceInfo(hwclass.VIDEO)
 self._getUnderlyingGraphicsDeviceInfo()
 self._getUnderlyingControllerDeviceInfo()
@@ -4189,34 +4189,6 @@
   'alias': alias,
   'address': address}
 self.conf['devices'].append(hostdevice)
-
-def _getUnderlyingSoundDeviceInfo(self):
-"""
-Obtain sound devices info from libvirt.
-"""
-for x in self._domain.get_device_elements('sound'):
-if not x.getElementsByTagName('address'):
-self.log.debug('device without address: %s', x)
-continue
-address = self._getUnderlyingDeviceAddress(x)
-alias = x.getElementsByTagName('alias')[0].getAttribute('name')
-
-# FIXME. We have an identification problem here.
-# Sound device has not unique identifier, except the alias
-# (but backend not aware to device's aliases). So, for now
-# we can only assign the address according to devices order.
-for sc in self._devices[hwclass.SOUND]:
-if not hasattr(sc, 'address') or not hasattr(sc, 'alias'):
-sc.alias = alias
-sc.address = address
-break
-# Update vm's conf with address
-for dev in self.conf['devices']:
-if ((dev['type'] == hwclass.SOUND) and
-(not dev.get('address') or not dev.get('alias'))):
-dev['address'] = address
-dev['alias'] = alias
-break
 
 def _getDriveIdentification(self, dom):
 sources = dom.getElementsByTagName('source')


-- 
To view, visit https://gerrit.ovirt.org/50196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: devices: replace Sound device info

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: devices: replace Sound device info
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50196
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3f4b5306aa8c7a93b26cd6ae7059a5d4578aef4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches