Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (9/9)

0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/30/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-28 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/544/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/921/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/958/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/540/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/956/ : 
FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/553/
 : FAILURE

http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/98/
 : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/98/ : 
SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/30/ : 0

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (3/9) - 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/958/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (4/9) - 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/540/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (5/9) - 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/956/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (8/9) - 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/98/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread mpolednik
Martin Polednik has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread danken
Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: do not clean StatsCache on setDownStatus
..


vm: do not clean StatsCache on setDownStatus

We should clean StatsCache, but only when a VM
is released, not when it is set to Down.

Otherwise, destroy will fail, leaving VDSM
into an inconsistent state.

Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Signed-off-by: Francesco Romani from...@redhat.com
Reviewed-on: https://gerrit.ovirt.org/40223
Reviewed-by: Nir Soffer nsof...@redhat.com
Tested-by: Nir Soffer nsof...@redhat.com
Reviewed-by: Martin Polednik mpoled...@redhat.com
Reviewed-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread danken
Dan Kenigsberg has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (1/9) - 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/544/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (2/9) - 
http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/921/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (6/9) - 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/553/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 2:

Build Started (7/9) - 
http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/98/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Polednik mpoled...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread fromani
Francesco Romani has uploaded a new change for review.

Change subject: vm: do not clean StatsCache on setDownStatus
..

vm: do not clean StatsCache on setDownStatus

We should clean StatsCache, but only when a VM
is released, not when it is set to Down.

Otherwise, destroy will fail, leaving VDSM
into an inconsistent state.

Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Signed-off-by: Francesco Romani from...@redhat.com
---
M vdsm/virt/vm.py
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/40223/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 25861a1..f8250ea 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1227,7 +1227,6 @@
 self.guestAgent.stop()
 except Exception:
 pass
-sampling.stats_cache.remove(self.id)
 self.saveState()
 
 def status(self, fullStatus=True):


-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1: Code-Review+1

Looks ok, I don't fully understand what is the stats cache, but we should 
quickly return to a stable state.

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1:

Build Started (2/2)

0 - http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1380/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18150/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1380/ : 0

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1:

Build Started (1/2) - 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18150/

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread automation
automat...@ovirt.org has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1: Verified+1

succesfully started and stopped a (GuestOS-less) VM:

Thread-435::DEBUG::2015-04-24 
17:28:17,990::__init__::445::jsonrpc.JsonRpcServer::(_serveRequest) Calling 
'VM.destroy' in bridge with {u'vmID': u'548ef480-fb31-4f79-a6c2-5558b33a5b42'}
JsonRpcServer::DEBUG::2015-04-24 
17:28:17,990::__init__::483::jsonrpc.JsonRpcServer::(serve_requests) Waiting 
for request
Thread-435::INFO::2015-04-24 17:28:17,991::API::334::vds::(destroy) 
vmContainerLock acquired by vm 548ef480-fb31-4f79-a6c2-5558b33a5b42
Thread-435::DEBUG::2015-04-24 17:28:17,992::vm::3516::vm.Vm::(destroy) 
vmId=`548ef480-fb31-4f79-a6c2-5558b33a5b42`::destroy Called
Thread-435::INFO::2015-04-24 17:28:17,993::vm::3447::vm.Vm::(releaseVm) 
vmId=`548ef480-fb31-4f79-a6c2-5558b33a5b42`::Release VM resources

Thread-435::DEBUG::2015-04-24 17:28:18,950::vm::3511::vm.Vm::(deleteVm) 
vmId=`548ef480-fb31-4f79-a6c2-5558b33a5b42`::Total desktops after destroy of 
548ef480-fb31-4f79-a6c2-5558b33a5b42 is 0
libvirtEventLoop::INFO::2015-04-24 
17:28:18,951::vm::1223::vm.Vm::(setDownStatus) 
vmId=`548ef480-fb31-4f79-a6c2-5558b33a5b42`::Changed state to Down: Admin shut 
down from the engine (code=6)
Thread-435::DEBUG::2015-04-24 
17:28:18,951::__init__::476::jsonrpc.JsonRpcServer::(_serveRequest) Return 
'VM.destroy' in bridge with True
Thread-435::DEBUG::2015-04-24 
17:28:18,952::stompReactor::158::yajsonrpc.StompServer::(send) Sending response
Thread-435::DEBUG::2015-04-24 
17:28:18,953::__init__::478::jsonrpc.JsonRpcServer::(_serveRequest) Served 
'VM.destroy'

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[master]: vm: do not clean StatsCache on setDownStatus

2015-04-24 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: vm: do not clean StatsCache on setDownStatus
..


Patch Set 1: Verified+1

Works for me - the errors in vdsm log are gone, and the extenral vms can be 
deleted now, and they do not come back.

-- 
To view, visit https://gerrit.ovirt.org/40223
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a511afa7a03f7f3d63409372f21060c2eaa21a6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches