Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-05-03 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


vm: hyperv: hypervclock dosn't have 'tickpolicy'

'hypervclock' (and kvmclock as well) does not
support the tickpolicy attribute.

This patch removes the setting, while preserving
it for 'rtc' clocksources.

Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/40387
Reviewed-by: Dan Kenigsberg 
---
M tests/vmTests.py
M vdsm/virt/vmxml.py
2 files changed, 6 insertions(+), 8 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-05-03 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 2:

* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-30 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1: Verified+1

same VDSM (with this patch, of course), using Os type = Linux produces







so no regressions. Ticking V+1

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-30 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1:

Verification:
- this patch is about fixing parameters for libvirt, so I created a Win7 VM on 
Engine and run it through a patched VDSM.

The XML created has hyperv enlightenment enabled as expected, and libvirt 
(libvirt-devel-1.2.13-1.el7.centos.x86_64) does not complain anymore

Relevant XML as expected by tests (and by us):







-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-29 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-29 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18326/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1556/ : FAILURE

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-29 Thread automation 
automat...@ovirt.org has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1:

* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 
'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-29 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1:

Build Started (1/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18326/

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-29 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..


Patch Set 1:

Build Started (2/2) -> 
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1556/

-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: hyperv: hypervclock dosn't have 'tickpolicy'

2015-04-29 Thread fromani 
Francesco Romani has uploaded a new change for review.

Change subject: vm: hyperv: hypervclock dosn't have 'tickpolicy'
..

vm: hyperv: hypervclock dosn't have 'tickpolicy'

'hypervclock' (and kvmclock as well) does not
support the tickpolicy attribute.

This patch removes the setting, while preserving
it for 'rtc' clocksources.

Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Signed-off-by: Francesco Romani 
---
M tests/vmTests.py
M vdsm/virt/vmxml.py
2 files changed, 6 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/40387/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index 25aac90..3cd4967 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -285,7 +285,7 @@
 def testHyperVClockXML(self):
 clockXML = """
 
-
+
 
 
 """
diff --git a/vdsm/virt/vmxml.py b/vdsm/virt/vmxml.py
index c4fd60c..02bbb52 100644
--- a/vdsm/virt/vmxml.py
+++ b/vdsm/virt/vmxml.py
@@ -183,18 +183,16 @@
 
 for hyperv:
 
-
+
 
 """
 
-if utils.tobool(self.conf.get('hypervEnable', 'false')):
-clockName = 'hypervclock'
-else:
-clockName = 'rtc'
-
 m = Element('clock', offset='variable',
 adjustment=str(self.conf.get('timeOffset', 0)))
-m.appendChildWithArgs('timer', name=clockName, tickpolicy='catchup')
+if utils.tobool(self.conf.get('hypervEnable', 'false')):
+m.appendChildWithArgs('timer', name='hypervclock')
+else:
+m.appendChildWithArgs('timer', name='rtc', tickpolicy='catchup')
 m.appendChildWithArgs('timer', name='pit', tickpolicy='delay')
 
 if self.arch == caps.Architecture.X86_64:


-- 
To view, visit https://gerrit.ovirt.org/40387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If38dba9f9667b43a2b00338135b901f7886224f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches