Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Abandoned

too old

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vm: report "MigrationSource" only if transferring
..

vm: report "MigrationSource" only if transferring

When a Vm failed to migrate for whatever reason,
the reported status should be "Up", no longer
"MigrationSource".
Current Vdsm code reports instead "MigrationSource",
because of a too coarse check in Vm class.

To fix this properly is not easy, due to the asynchronous
implementation of migration supervision.
However, we can improve the reporting leveraging the new-ly
added 'transferring' property.

This patch does that, making the event raised on migration
aborted report the true status.

Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/50338/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index af8383c..ddad637 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1473,7 +1473,7 @@
 vmstatus.PAUSED, vmstatus.DOWN)
 if self.lastStatus in statuses:
 return self.lastStatus
-elif self.isMigrating():
+elif self.isMigrating() and self._migrationSource.transferring:
 if self._migrationSourceThread.hibernating:
 return vmstatus.SAVING_STATE
 else:


-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: report "MigrationSource" only if transferring
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/50338
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e6b4ed8218fbe095845fcea44eba46780e918bc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches