Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/549/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/926/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/963/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/545/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/961/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/558/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/103/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/35/ : 0 -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (9/9) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/35/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (8/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc22-x86_64_merged/103/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (7/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc22-x86_64_merged/103/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (6/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/558/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (5/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/961/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
automat...@ovirt.org has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (4/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/545/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm.py: factor out device object creation from _run method .. vm.py: factor out device object creation from _run method This is an attempt to start more isolation of device related functionality in vm.py. This will allow us to move it to it's own module in future, and in the meantime give us more granularity for testing. Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/40073 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm/virt/vm.py 1 file changed, 10 insertions(+), 4 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (1/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/926/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (3/9) -> http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/963/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 3: Build Started (2/9) -> http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/549/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Dan Kenigsberg has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Francesco Romani has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Martin Polednik has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: Verified+1 Verified via unit tests and functional tests (with closer focus on the number of devices) -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18035/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1264/ : 0 -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: Build Started (2/2) 0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1264/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18035/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
automat...@ovirt.org has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Francesco Romani has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 1: Code-Review+1 (1 comment) I like the general direction and this patch makes the code a little nicer (to me), so I'm OK going ahead. Let's see how next patches will look. https://gerrit.ovirt.org/#/c/40073/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 853: 'index': 0, Line 854: 'truesize': 0}) Line 855: return removables Line 856: Line 857: def buildDevicesFromMapping(self, devices): > The way that code works is pure by design - only methodized it yep, I meant fully de-methodizing it removing all 'self' references. Line 858: """ Line 859: Given a device mapping, construct device objects in their internal Line 860: container Line 861: """ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Martin Polednik has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 1: (1 comment) One is https://gerrit.ovirt.org/#/c/39364/ - when the object creation is modularized, the test could access the devices directly - right now sice vm._devices is empty it's not really accurate. Long term plan is try and very slowly reintroduce the device container to get rid of conf['devices'] as a separate device entity. I would like to see it done by fully modularizing the devices, refactoring them and encapsulating them in an object. Renaming buildConfDevices to something it actually does while hinting it's return value type is just a small addition. https://gerrit.ovirt.org/#/c/40073/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 853: 'index': 0, Line 854: 'truesize': 0}) Line 855: return removables Line 856: Line 857: def buildDevicesFromMapping(self, devices): > does it make sense to make this a pure function? The way that code works is pure by design - only methodized it Line 858: """ Line 859: Given a device mapping, construct device objects in their internal Line 860: container Line 861: """ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Francesco Romani has posted comments on this change.
Change subject: vm.py: factor out device object creation from _run method
..
Patch Set 1:
(2 comments)
can you share more long term plans, to see the direction this patch is heading?
To point to followup patches (if any) works anyway
https://gerrit.ovirt.org/#/c/40073/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 853: 'index': 0,
Line 854: 'truesize': 0})
Line 855: return removables
Line 856:
Line 857: def buildDevicesFromMapping(self, devices):
does it make sense to make this a pure function?
Line 858: """
Line 859: Given a device mapping, construct device objects in their
internal
Line 860: container
Line 861: """
Line 868: """
Line 869: Returns a map of {device type: [devices]} supplied in devices
Line 870: section of conf.
Line 871:
Line 872: If devices section is missing, creait it according to the old
API.
typo: "creait" vs "create"
Line 873:
Line 874: """
Line 875: devices = self._makeDeviceDict()
Line 876:
--
To view, visit https://gerrit.ovirt.org/40073
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18101/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17929/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 1: Build Started (2/2) -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/18101/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
automat...@ovirt.org has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm.py: factor out device object creation from _run method .. Patch Set 1: Build Started (1/2) -> http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/17929/ -- To view, visit https://gerrit.ovirt.org/40073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm.py: factor out device object creation from _run method
Martin Polednik has uploaded a new change for review.
Change subject: vm.py: factor out device object creation from _run method
..
vm.py: factor out device object creation from _run method
This is an attempt to start more isolation of device related
functionality in vm.py. This will allow us to move it to it's own
module in future, and in the meantime give us more granularity for
testing.
Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d
Signed-off-by: Martin Polednik
---
M tests/deviceTests.py
M tests/vmTests.py
M vdsm/virt/vm.py
3 files changed, 24 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/40073/1
diff --git a/tests/deviceTests.py b/tests/deviceTests.py
index 1235cca..8f9c8e9 100644
--- a/tests/deviceTests.py
+++ b/tests/deviceTests.py
@@ -118,13 +118,13 @@
for conf in self.confDisplay:
conf.update(self.conf)
with fake.VM(conf) as testvm:
-devs = testvm.buildConfDevices()
+devs = testvm.buildDeviceMappingFromConf()
self.assertTrue(devs['graphics'])
def testGraphicsDevice(self):
for dev in self.confDeviceGraphics:
with fake.VM(self.conf, dev) as testvm:
-devs = testvm.buildConfDevices()
+devs = testvm.buildDeviceMappingFromConf()
self.assertTrue(devs['graphics'])
def testGraphicsDeviceMixed(self):
@@ -136,7 +136,7 @@
conf.update(self.conf)
for dev in self.confDeviceGraphics:
with fake.VM(self.conf, dev) as testvm:
-devs = testvm.buildConfDevices()
+devs = testvm.buildDeviceMappingFromConf()
self.assertEqual(len(devs['graphics']), 1)
self.assertEqual(devs['graphics'][0]['device'],
dev[0]['device'])
@@ -182,7 +182,7 @@
devices = [{'type': 'graphics', 'device': primary},
{'type': 'graphics', 'device': secondary}]
with fake.VM(self.conf, devices) as testvm:
-devs = testvm.buildConfDevices()
+devs = testvm.buildDeviceMappingFromConf()
self.assertTrue(len(devs['graphics']) == 2)
@permutations([['vnc'], ['spice']])
@@ -190,7 +190,7 @@
devices = [{'type': 'graphics', 'device': devType},
{'type': 'graphics', 'device': devType}]
with fake.VM(self.conf, devices) as testvm:
-self.assertRaises(ValueError, testvm.buildConfDevices)
+self.assertRaises(ValueError, testvm.buildDeviceMappingFromConf)
def testSmartcardXML(self):
smartcardXML = ''
diff --git a/tests/vmTests.py b/tests/vmTests.py
index 7cba205..c70ffcd 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -1212,7 +1212,7 @@
{'type': 'graphics', 'device': 'vnc', 'port': '-1'}]
with fake.VM(_VM_PARAMS, devices) as testvm:
-testvm._updateDevices(testvm.buildConfDevices())
+testvm._updateDevices(testvm.buildDeviceMappingFromConf())
res = testvm.getStats()
self.assertIn('displayPort', res)
self.assertEqual(res['displayType'],
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 2690c6e..6d61477 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -854,10 +854,23 @@
'truesize': 0})
return removables
-def buildConfDevices(self):
+def buildDevicesFromMapping(self, devices):
"""
-Return the "devices" section of this Vm's conf.
-If missing, create it according to old API.
+Given a device mapping, construct device objects in their internal
+container
+"""
+for dev_type, dev_class in self.DeviceMapping:
+for dev in devices[dev_type]:
+self._devices[dev_type].append(dev_class(self.conf, self.log,
+ **dev))
+
+def buildDeviceMappingFromConf(self):
+"""
+Returns a map of {device type: [devices]} supplied in devices
+section of conf.
+
+If devices section is missing, creait it according to the old API.
+
"""
devices = self._makeDeviceDict()
@@ -2126,7 +2139,7 @@
def _run(self):
self.log.info("VM wrapper has started")
-devices = self.buildConfDevices()
+devices = self.buildDeviceMappingFromConf()
# recovery flow note:
# we do not start disk stats collection here since
@@ -2150,10 +2163,7 @@
# rebooting it. Evident on, but not limited to, the HE case.
self._fixLegacyConf()
-for devType, devClass in self.DeviceMapping:
-for dev in devices[devType]:
-self._devices[devType].append(devClass(self.conf, self.log,
-
