Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: fix odd migration progress reporting .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_3.4_create-rpms_merged/229/ : FAILURE -- To view, visit http://gerrit.ovirt.org/28363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: fix odd migration progress reporting .. vm: fix odd migration progress reporting migration progress should not start from 100, otherwise the user will see smething like: progress: 100 -> 0% ... X% ... 100% A real-word scenario that shows the need for this patch is the following: If during the the initialization of migration we experience some delay, for example DNS resolve issues, libvirt returns 0 for all the progress values, and that incorrectly triggered the old shortcut, leading to an incorrect initial progress value of 100. Bug-Url: https://bugzilla.redhat.com/1104670 Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Signed-off-by: Francesco Romani Reviewed-on: http://gerrit.ovirt.org/27465 Tested-by: Tomas Jelinek Reviewed-by: Dan Kenigsberg Reviewed-on: http://gerrit.ovirt.org/28363 --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit http://gerrit.ovirt.org/28363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has posted comments on this change. Change subject: vm: fix odd migration progress reporting .. Patch Set 2: Verified+1 Verification: trivial patch; however, still verified on a patched 4.14.9 VDSM by running a few migrations and observing the progress reported on the logs. -- To view, visit http://gerrit.ovirt.org/28363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Dan Kenigsberg has posted comments on this change. Change subject: vm: fix odd migration progress reporting .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/28363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Tomas Jelinek Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Hello Tomas Jelinek, Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/28363 to review the following change. Change subject: vm: fix odd migration progress reporting .. vm: fix odd migration progress reporting migration progress should not start from 100, otherwise the user will see smething like: progress: 100 -> 0% ... X% ... 100% A real-word scenario that shows the need for this patch is the following: If during the the initialization of migration we experience some delay, for example DNS resolve issues, libvirt returns 0 for all the progress values, and that incorrectly triggered the old shortcut, leading to an incorrect initial progress value of 100. Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Signed-off-by: Francesco Romani Reviewed-on: http://gerrit.ovirt.org/27465 Tested-by: Tomas Jelinek Reviewed-by: Dan Kenigsberg --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/28363/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 69f7cb4..a21d08b 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -765,7 +765,7 @@ def run(self): def calculateProgress(remaining, total): -if remaining == 0: +if remaining == 0 and total: return 100 progress = 100 - 100 * remaining / total if total else 0 return progress if (progress < 100) else 99 -- To view, visit http://gerrit.ovirt.org/28363 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9d72b0b8b956d79a7f69df61f4b45048dc9443e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Tomas Jelinek ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has abandoned this change. Change subject: vm: fix odd migration progress reporting .. Abandoned will do proper cherry-pick to make automation happy -- To view, visit http://gerrit.ovirt.org/28362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has posted comments on this change. Change subject: vm: fix odd migration progress reporting .. Patch Set 1: this patch is not the same of master due to recent refactorings. -- To view, visit http://gerrit.ovirt.org/28362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: vm: fix odd migration progress reporting
Francesco Romani has uploaded a new change for review. Change subject: vm: fix odd migration progress reporting .. vm: fix odd migration progress reporting migration progress should not start from 100, otherwise the user will see smething like: progress: 100 -> 0% ... X% ... 100% A real-word scenario that shows the need for this patch is the following: If during the the initialization of migration we experience some delay, for example DNS resolve issues, libvirt returns 0 for all the progress values, and that incorrectly triggered the old shortcut, leading to an incorrect initial progress value of 100. Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Bug-Url: https://bugzilla.redhat.com/1104670 Signed-off-by: Francesco Romani --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/28362/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 69f7cb4..a21d08b 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -765,7 +765,7 @@ def run(self): def calculateProgress(remaining, total): -if remaining == 0: +if remaining == 0 and total: return 100 progress = 100 - 100 * remaining / total if total else 0 return progress if (progress < 100) else 99 -- To view, visit http://gerrit.ovirt.org/28362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib2bfefb3ffc7d21f6a554f00eac6934fa89ab669 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Francesco Romani ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
