Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: Add an empty metadata qos element to the created domain
..


Add an empty metadata qos element to the created domain

Libvirt reports an error every time VDSM queries for the metadata
element when there is none. This patch adds an empty default
element to get rid of those errors.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1289007
Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/45664
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
(cherry picked from commit deadb606de96fc84d8d912d56bbc042974074f54)
Reviewed-on: https://gerrit.ovirt.org/45799
Reviewed-on: https://gerrit.ovirt.org/49655
Reviewed-by: Vinzenz Feenstra 
Continuous-Integration: Francesco Romani 
---
M tests/vmTests.py
M tests/vmTestsData.py
M vdsm/virt/utils.py
M vdsm/virt/vm.py
4 files changed, 52 insertions(+), 7 deletions(-)

Approvals:
  Martin Sivák: Verified
  Vinzenz Feenstra: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 4:

* #1289007::Update tracker: OK
* Set MODIFIED::bug 1289007#1289007IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Continuous-Integration+1

jenkins failure unrelated

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

caused by appendMetadata - we need a try/except IndexError in sampling.py in 
_sampleCpuTune. Probably another backport.

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

...sorry, I misread 3.5 for 3.6. Will recheck the tests and merge

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

will check test failure, it should be bogus. Will be merged after the 3.6.1 
branch created (on monday 20151214)

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Code-Review-1

sorry for late noticing: smoke test revelead a bug

Thread-77::ERROR::2015-12-11 17:14:07,156::sampling::488::vm.Vm::(collect) 
vmId=`0eab0e22-d58b-4342-a8d9-dd9512557fd0`::Stats function failed: 

Traceback (most recent call last):
  File "/usr/share/vdsm/virt/sampling.py", line 484, in collect
statsFunction()
  File "/usr/share/vdsm/virt/sampling.py", line 359, in __call__
retValue = self._function(*args, **kwargs)
  File "/usr/share/vdsm/virt/vm.py", line 393, in _sampleCpuTune
infos['vcpuLimit'] = nodeList[0].childNodes[0].data
IndexError: list index out of range

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

seems fine now. Waiting until monday because 50341, otherwise fine.

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-09 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

jenkins failure seems unrelated (orphan bridges?). Retrying.

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-09 Thread msivak 
Martin Sivák has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-09 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-09 Thread vfeenstr 
Vinzenz Feenstra has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 3:

* #1289007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1289007::OK, public bug
* Check Product::#1289007::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1289007::ERROR, wrong target milestone for stable branch, --- 
should match ^.*3.5.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 2:

* #1289007::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1289007::OK, public bug
* Check Product::#1289007::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1289007::ERROR, wrong target milestone for stable branch, --- 
should match ^.*3.5.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-03 Thread msivak 
Hello Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49655

to review the following change.

Change subject: Add an empty metadata qos element to the created domain
..

Add an empty metadata qos element to the created domain

Libvirt reports an error every time VDSM queries for the metadata
element when there is none. This patch adds an empty default
element to get rid of those errors.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1219903
Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/45664
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
(cherry picked from commit deadb606de96fc84d8d912d56bbc042974074f54)
Reviewed-on: https://gerrit.ovirt.org/45799
---
M tests/vmTests.py
M tests/vmTestsData.py
M vdsm/virt/utils.py
M vdsm/virt/vm.py
4 files changed, 52 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/49655/1

diff --git a/tests/vmTests.py b/tests/vmTests.py
index be0b801..a403415 100644
--- a/tests/vmTests.py
+++ b/tests/vmTests.py
@@ -204,13 +204,16 @@
 
 def testDomXML(self):
 expectedXML = """
-   
+   http://ovirt.org/vm/tune/1.0;>
   testVm
   9ffe28b6-6134-4b1e-8804-1185f49c436f
   1048576
   1048576
   160
   
+  
+ 
+  
"""
 
 domxml = vm._DomXML(self.conf, self.log,
diff --git a/tests/vmTestsData.py b/tests/vmTestsData.py
index 4eb4960..63321f2 100644
--- a/tests/vmTestsData.py
+++ b/tests/vmTestsData.py
@@ -33,7 +33,8 @@
 'guestNumaNodes': []},
 
 """
-
+http://ovirt.org/vm/tune/1.0;>
 testVm
 %(vmId)s
 1048576
@@ -52,6 +53,9 @@
 
 
 
+
+
+
 
 hvm
 
@@ -99,6 +103,7 @@
 
 """
 http://ovirt.org/vm/tune/1.0;
 xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0;>
 testVm
 %(vmId)s
@@ -119,6 +124,9 @@
 
 /usr/bin/qemu-system-ppc64
 
+
+
+
 
 hvm
 
diff --git a/vdsm/virt/utils.py b/vdsm/virt/utils.py
index 48f9a37..a20ef03 100644
--- a/vdsm/virt/utils.py
+++ b/vdsm/virt/utils.py
@@ -39,8 +39,12 @@
 
 class XMLElement(object):
 
-def __init__(self, tagName, text=None, **attrs):
-self._elem = xml.dom.minidom.Document().createElement(tagName)
+def __init__(self, tagName, text=None, namespaceUri=None, **attrs):
+if namespaceUri is not None:
+self._elem = xml.dom.minidom.Document().createElementNS(
+namespaceUri, tagName)
+else:
+self._elem = xml.dom.minidom.Document().createElement(tagName)
 self.setAttrs(**attrs)
 if text is not None:
 self.appendTextNode(text)
@@ -52,6 +56,9 @@
 for attrName, attrValue in attrs.iteritems():
 self._elem.setAttribute(attrName, attrValue)
 
+def setAttr(self, attrName, attrValue):
+self._elem.setAttribute(attrName, attrValue)
+
 def appendTextNode(self, text):
 textNode = xml.dom.minidom.Document().createTextNode(text)
 self._elem.appendChild(textNode)
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ba4940c..2576522 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -95,6 +95,8 @@
 TPM_DEVICES = 'tpm'
 
 METADATA_VM_TUNE_URI = 'http://ovirt.org/vm/tune/1.0'
+METADATA_VM_TUNE_ELEMENT = 'qos'
+METADATA_VM_TUNE_PREFIX = 'ovirt'
 
 # A libvirt constant for undefined cpu quota
 _NO_CPU_QUOTA = 0
@@ -765,6 +767,8 @@
 self._devices = XMLElement('devices')
 self.dom.appendChild(self._devices)
 
+self.appendMetadata()
+
 def appendClock(self):
 """
 Add  element to domain:
@@ -785,6 +789,28 @@
 m.appendChildWithArgs('timer', name='hpet', present='no')
 
 self.dom.appendChild(m)
+
+def appendMetadata(self):
+"""
+Add the namespaced qos metadata element to the domain
+
+http://ovirt.org/vm/tune/1.0;>
+...
+   
+  
+   
+...
+
+"""
+
+self._metadata = XMLElement('metadata')
+self._metadata.appendChild(
+XMLElement(METADATA_VM_TUNE_PREFIX + ':' +
+   METADATA_VM_TUNE_ELEMENT,
+   namespaceUri=METADATA_VM_TUNE_URI))
+self.dom.setAttr('xmlns:' + METADATA_VM_TUNE_PREFIX,
+ METADATA_VM_TUNE_URI)
+

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-03 Thread msivak 
Martin Sivák has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 1: Verified-1

Needs a new bug number.

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-03 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 1: Code-Review+1

yep, we need new bz, but I want this patch

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: Add an empty metadata qos element to the created domain
..


Patch Set 1:

* #1219903::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1219903::OK, public bug
* Check Product::#1219903::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1219903::OK, correct target milestone ovirt-3.5.7
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49655
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc5db925b55ea8e583a11d548a27dc3fd0886fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches