Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
automat...@ovirt.org has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 2: * Update tracker::#1198512::OK * Set MODIFIED::bug 1198512#1198512IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
automat...@ovirt.org has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: * Update tracker::#1198512::OK * Check Bug-Url::OK * Check Public Bug::#1198512::OK, public bug * Check Product::#1198512::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1198512::OK, correct target release 3.5.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
oVirt Jenkins CI Server has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/170/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/172/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/2/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/173/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Yaniv Bronhaim has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Live Merge: Update drive.format after active layer merge .. Live Merge: Update drive.format after active layer merge A merge of the active layer can change the drive format from cow - raw if a snapshot was merged into a raw backing file. In that case we must correct the VM Drive metadata to ensure the drive is handled properly after the merge has finished. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198512 Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Signed-off-by: Adam Litke ali...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36923 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38437 Reviewed-by: Allon Mureinik amure...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 11 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Verified Yaniv Bronhaim: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
oVirt Jenkins CI Server has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/169/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/172/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/172/ : FAILURE http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/2/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Allon Mureinik has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Nir Soffer has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Adam Litke has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Live Merge: Update drive.format after active layer merge
Hello Nir Soffer, Dan Kenigsberg, Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38437 to review the following change. Change subject: Live Merge: Update drive.format after active layer merge .. Live Merge: Update drive.format after active layer merge A merge of the active layer can change the drive format from cow - raw if a snapshot was merged into a raw backing file. In that case we must correct the VM Drive metadata to ensure the drive is handled properly after the merge has finished. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1198512 Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Signed-off-by: Adam Litke ali...@redhat.com Reviewed-on: http://gerrit.ovirt.org/36923 Reviewed-by: Francesco Romani from...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/virt/vm.py 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/38437/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 16f8212..904c8e1 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -5986,15 +5986,25 @@ return volumeID = volumes[-1] +res = self.cif.irs.getVolumeInfo(drive.domainID, drive.poolID, + drive.imageID, volumeID) +if res['status']['code'] != 0: +self.log.error(Unable to get info of volume %s (domain: %s image: +%s), volumeID, drive.domainID, drive.imageID) +raise RuntimeError(Unable to get volume info) +driveFormat = res['info']['format'].lower() + # Sync this VM's data strctures. Ugh, we're storing the same info in # two places so we need to change it twice. device = self._lookupConfByPath(drive['path']) if drive.volumeID != volumeID: # If the active layer changed: -# Update the disk path, volumeID, and volumeInfo members +# Update the disk path, volumeID, volumeInfo, and format members volInfo = getVolumeInfo(device, volumeID) + # Path must be set with the value being used by libvirt device['path'] = drive.path = volInfo['path'] = activePath +device['format'] = drive.format = driveFormat device['volumeID'] = drive.volumeID = volumeID device['volumeInfo'] = drive.volumeInfo = volInfo for v in device['volumeChain']: -- To view, visit https://gerrit.ovirt.org/38437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
