Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Piotr Kliczewski has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: It is a revert so marking verify flag -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Piotr Kliczewski has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit e7ebfdeb7b036ce10f25a3b26657e6414644fc55.
Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
Bug-Url: https://bugzilla.redhat.com/1196327
---
M vdsm/rpc/Bridge.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/38433/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index e1781a2..e4b12aa 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -333,6 +333,13 @@
return API.Global().getVMList(True, vmList)
+def Host_getVMList_Ret(ret):
+
+Just return a list of VM UUIDs
+
+return [v['vmId'] for v in ret['vmList']]
+
+
def StoragePool_getInfo_Ret(ret):
The result contains two data structures which must be merged
@@ -402,7 +409,7 @@
'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
'Host_startMonitoringDomain': {},
'Host_stopMonitoringDomain': {},
-'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
+'Host_getVMList': {'call': Host_getVMList_Call, 'ret': Host_getVMList_Ret},
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
'Host_setupNetworks': {'ret': 'status'},
--
To view, visit https://gerrit.ovirt.org/38433
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Piotr Kliczewski has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
automat...@ovirt.org has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 2: * Update tracker::#1196327::OK * Check TR::#1196327::OK * Set MODIFIED::bug 1196327#1196327FAILED, illegal change from ON_QA -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
automat...@ovirt.org has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/38431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
automat...@ovirt.org has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified-1 * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public bug * Check Product::#1196327::OK, Correct product oVirt * Check TR::#1196327::OK, correct target release 3.5.2 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
automat...@ovirt.org has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/38431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Yaniv Bronhaim has submitted this change and it was merged. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Revert json-rpc: fix the Host.getVMList return value This reverts commit e7ebfdeb7b036ce10f25a3b26657e6414644fc55. Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Bug-Url: https://bugzilla.redhat.com/1196327 Reviewed-on: https://gerrit.ovirt.org/38433 Reviewed-by: Dan Kenigsberg dan...@redhat.com Tested-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/rpc/Bridge.py 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has uploaded a new change for review.
Change subject: Revert json-rpc: fix the Host.getVMList return value
..
Revert json-rpc: fix the Host.getVMList return value
This reverts commit e7ebfdeb7b036ce10f25a3b26657e6414644fc55.
Unfortunately, this patch ended up causing a regression with
oldready-released engine-3.5.0.
Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79
Related-To: https://bugzilla.redhat.com/1198680
Signed-off-by: Dan Kenigsberg dan...@redhat.com
---
M vdsm/rpc/Bridge.py
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/38431/1
diff --git a/vdsm/rpc/Bridge.py b/vdsm/rpc/Bridge.py
index e1781a2..e4b12aa 100644
--- a/vdsm/rpc/Bridge.py
+++ b/vdsm/rpc/Bridge.py
@@ -333,6 +333,13 @@
return API.Global().getVMList(True, vmList)
+def Host_getVMList_Ret(ret):
+
+Just return a list of VM UUIDs
+
+return [v['vmId'] for v in ret['vmList']]
+
+
def StoragePool_getInfo_Ret(ret):
The result contains two data structures which must be merged
@@ -402,7 +409,7 @@
'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
'Host_startMonitoringDomain': {},
'Host_stopMonitoringDomain': {},
-'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
+'Host_getVMList': {'call': Host_getVMList_Call, 'ret': Host_getVMList_Ret},
'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
'Host_getAllVmStats': {'ret': 'statsList'},
'Host_setupNetworks': {'ret': 'status'},
--
To view, visit https://gerrit.ovirt.org/38431
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg dan...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Dan Kenigsberg has abandoned this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Abandoned -- To view, visit https://gerrit.ovirt.org/38431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I820a1f81e41bfe1c8f442db6d5d8d5b12de4ad79 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
