Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4: Code-Review+2

looks OK. Let's give Jenkins another change.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4: Verified+1

Verified on RHEL6.6 with Python2.6- checked dircet LUN disks, file and block 
disks- both successful and unsuccessful hotunplugging.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4: Code-Review+1

Sorry for the noise, bool does not handle generators well.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 5: Verified-1

* #1283287::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283287::OK, public bug
* Check Product::#1283287::OK, Correct classification oVirt
* Check TM::#1283287::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::WARN, Still missing on branches ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4:

Jenkins failures are not relevant

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 5: Continuous-Integration+1

CI failures unrelated, did smoke test locally, seems OK.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 6:

* #1283287::Update tracker: OK
* Set MODIFIED::bug 1283287#1283287OK

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hotunplug: support python 2.6
..


hotunplug: support python 2.6

In commit d0d05b02ee, we introduced a libvirt quering method to find
out if a drive was attached to a VM.

However- The XPath expression used in this method is supported only in
ElementTree1.3: http://effbot.org/zone/element-xpath.htm, which was only
introduced in Python 2.7:
https://docs.python.org/2/library/xml.etree.elementtree.html

As VDSM needs to support Python2.6 on RHEL6, this patch changes the
method to work with ElementTreee x.y available in Python 2.6.

Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Bug-Url: https://bugzilla.redhat.com/1283287
Label: ovirt-3.5-only
Signed-off-by: Amit Aviram 
Reviewed-on: https://gerrit.ovirt.org/48916
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
Continuous-Integration: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Amit Aviram: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 5: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 4

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/48916/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-11-22 14:45:25 +0200
Line 6: 
Line 7: hotunplug: support python 2.6
Line 8: 
Line 9: In patch I393ce55dd761ac825cb96bd499976fd74c366b09, we introduced a
> Please mention the ovirt-3.5 commit (d0d05b02ee6f60cdccddd809f4b02bb2020c75
Done
Line 10: libvirt quering method to find out if a drive was attached to a VM.
Line 11: 
Line 12: However- The XPath expression used in this method is supported only in
Line 13: ElementTree1.3: http://effbot.org/zone/element-xpath.htm, which was 
only


Line 15: https://docs.python.org/2/library/xml.etree.elementtree.html
Line 16: 
Line 17: As VDSM needs to support Python2.6 on RHEL6, this patch changes the
Line 18: method to use a path expression which is supported in earlier version
Line 19: of ElementTree, for Python2.6 to support the method.
> Lets shorten this to:
Done
Line 20: 
Line 21: Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Line 22: Bug-Url: https://bugzilla.redhat.com/1283287


-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 3: Verified-1

* #1283287::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283287::OK, public bug
* Check Product::#1283287::OK, Correct classification oVirt
* Check TM::#1283287::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::WARN, Still missing on branches ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 4:

* #1283287::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283287::OK, public bug
* Check Product::#1283287::OK, Correct classification oVirt
* Check TM::#1283287::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::WARN, Still missing on branches ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48916/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4151: def _isDriveAttached(self, drive):
Line 4152: root = ET.fromstring(self._dom.XMLDesc(0))
Line 4153: source_key = 'dev' if drive.blockDev else 'file'
Line 4154: sources = root.findall("./devices/disk/source")
Line 4155: return bool([s for s in sources if s.get(source_key) == 
drive.path])
Se my comment in https://gerrit.ovirt.org/#/c/48908/1/vdsm/virt/vm.py
Line 4156: 
Line 4157: def _readPauseCode(self, timeout):
Line 4158: # libvirt does not not export yet the I/O error reason code.
Line 4159: # we need a way to


-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[eedri]

Eyal Edri has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2:

Rerunning only bug_url to skip the 3.6 branch verification.
since its only 3.5 bug.

Rerun-Hooks: patchset-created.bz.0.has_bug_url

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2: -Verified

* Check Bug-Url::OK

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2:

Please to run again the jenkins jobs. I they continue to fail, please report 
this to infra mailing list:
http://lists.ovirt.org/mailman/listinfo/infra

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/48916/2//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-11-22 14:45:25 +0200
Line 6: 
Line 7: hotunplug: support python 2.6
Line 8: 
Line 9: In patch I393ce55dd761ac825cb96bd499976fd74c366b09, we introduced a
Please mention the ovirt-3.5 commit (d0d05b02ee6f60cdccddd809f4b02bb2020c75f8) 
instead, since the patch on master and ovirt-3.6 is fine.

Use this format when you refert to old commit:

commit d0d05b02ee (vm: Libvirt quering after disk detach operation addition)

The first 10 characters of the commit hash are unique enough to identify the 
commit.
Line 10: libvirt quering method to find out if a drive was attached to a VM.
Line 11: 
Line 12: However- The XPath expression used in this method is supported only in
Line 13: ElementTree1.3: http://effbot.org/zone/element-xpath.htm, which was 
only


Line 15: https://docs.python.org/2/library/xml.etree.elementtree.html
Line 16: 
Line 17: As VDSM needs to support Python2.6 on RHEL6, this patch changes the
Line 18: method to use a path expression which is supported in earlier version
Line 19: of ElementTree, for Python2.6 to support the method.
Lets shorten this to:

As VDSM needs to support Python2.6 on RHEL6, this patch changes the
method to work with ElementTreee x.y available in Python 2.6.
Line 20: 
Line 21: Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Line 22: Bug-Url: https://bugzilla.redhat.com/1283287


-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2:

Eyal, this is an ovirt-3.5 only fix,  which is not needed on ovirt-3.6 or 
master.

Do we need to mark this patch somehow to make the hooks happy? The patch does 
not exists in master and ovirt 3.6 and will never be.

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 1: Verified-1

* #1283287::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283287::OK, public bug
* Check Product::#1283287::OK, Correct classification oVirt
* Check TM::#1283287::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::WARN, Still missing on branches ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2: Verified-1

* #1283287::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1283287::OK, public bug
* Check Product::#1283287::OK, Correct classification oVirt
* Check TM::#1283287::OK, correct target milestone ovirt-3.5.6
* Check merged to previous::WARN, Still missing on branches ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[aaviram]

Amit Aviram has uploaded a new change for review.

Change subject: hotunplug: support python 2.6
..

hotunplug: support python 2.6

In patch I393ce55dd761ac825cb96bd499976fd74c366b09, we introduced a
libvirt quering method to find out if a drive was attached to a VM.

However- The XPath expression used in this method is supported only in
ElementTree1.3: http://effbot.org/zone/element-xpath.htm, which was only
introduced in Python 2.7:
https://docs.python.org/2/library/xml.etree.elementtree.html

As VDSM needs to support Python2.6 on RHEL6, this patch changes the
method to use a path expression which is supported in earlier version
of ElementTree, for Python2.6 to support the method.

Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Bug-Url: https://bugzilla.redhat.com/1283287
Signed-off-by: Amit Aviram 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/48916/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 72287fd..d1092da 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4151,8 +4151,9 @@
 def _isDriveAttached(self, drive):
 root = ET.fromstring(self._dom.XMLDesc(0))
 source_key = 'dev' if drive.blockDev else 'file'
-return bool(root.findall("./devices/disk/source[@%s='%s']" %
- (source_key, drive.path)))
+sources = root.findall("./devices/disk/source")
+return bool([s for s in sources
+ if s.get(source_key[drive.diskType]) == drive.path])
 
 def _readPauseCode(self, timeout):
 # libvirt does not not export yet the I/O error reason code.


-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: hotunplug: support python 2.6

[aaviram]

Amit Aviram has posted comments on this change.

Change subject: hotunplug: support python 2.6
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48916/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4151: def _isDriveAttached(self, drive):
Line 4152: root = ET.fromstring(self._dom.XMLDesc(0))
Line 4153: source_key = 'dev' if drive.blockDev else 'file'
Line 4154: sources = root.findall("./devices/disk/source")
Line 4155: return bool([s for s in sources if s.get(source_key) == 
drive.path])
> Se my comment in https://gerrit.ovirt.org/#/c/48908/1/vdsm/virt/vm.py
It is not relevant here, as "source_key" is not a dictionary in this case (no 
cinder disk, only two options)
Line 4156: 
Line 4157: def _readPauseCode(self, timeout):
Line 4158: # libvirt does not not export yet the I/O error reason code.
Line 4159: # we need a way to


-- 
To view, visit https://gerrit.ovirt.org/48916
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches