Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor
oVirt Jenkins CI Server has posted comments on this change. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. Patch Set 2: Build Failed http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms_merged/163/ : ABORTED -- To view, visit http://gerrit.ovirt.org/32980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/32980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor
Yaniv Bronhaim has submitted this change and it was merged. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. jsonrpc: wrong usage of optional arguments in ctor When ctor arguments are marked as optional in schema the code compares argument names with '*' from schema with request names without '*'. This behavior result in passing wrong number of arguments to a method. Bug-Url: https://bugzilla.redhat.com/1141510 Change-Id: I3630025b992e3ec8573069c5868c415653515594 Signed-off-by: pkliczewski Reviewed-on: http://gerrit.ovirt.org/32980 Reviewed-by: Oved Ourfali Reviewed-by: Nir Soffer Reviewed-by: Yaniv Bronhaim --- M vdsm/rpc/Bridge.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Verified Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, approved Oved Ourfali: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/32980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor
Nir Soffer has posted comments on this change. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/32980/1/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 152: for arg in allArgs: Line 153: name = self._symNameFilter(arg) Line 154: Line 155: if name not in ctorArgs: Line 156: methodArgs.append(arg) This should work, but note that this appends "*name" to methodArgs, and in _getArgs "*name" is converted again to "name". This mess should be cleaned later. Line 157: Line 158: return self._getArgs(argObj, methodArgs, defaultArgs) Line 159: Line 160: def _getDefaultArgs(self, api, className, methodName): -- To view, visit http://gerrit.ovirt.org/32980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: jsonrpc: wrong usage of optional arguments in ctor
Oved Ourfali has posted comments on this change. Change subject: jsonrpc: wrong usage of optional arguments in ctor .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/32980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3630025b992e3ec8573069c5868c415653515594 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
