Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 5: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Dan Kenigsberg has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 5: this seems bad, albeit unrelated to the patch ERROR: test_parseVolumeStatus (gluster_cli_tests.GlusterCliTests) -- Traceback (most recent call last): File "/builddir/build/BUILD/vdsm-4.16.26/tests/gluster_cli_tests.py", line 1083, in test_parseVolumeStatus self._parseVolumeStatus_test() File "/builddir/build/BUILD/vdsm-4.16.26/tests/gluster_cli_tests.py", line 268, in _parseVolumeStatus_test status = gcli._parseVolumeStatus(tree) File "/builddir/build/BUILD/vdsm-4.16.26/vdsm/gluster/cli.py", line 137, in _parseVolumeStatus hostname = _getLocalIpAddress() or _getGlusterHostName() File "/builddir/build/BUILD/vdsm-4.16.26/vdsm/gluster/cli.py", line 107, in _getLocalIpAddress for ip in netinfo.getIpAddresses(): File "/builddir/build/BUILD/vdsm-4.16.26/lib/vdsm/netinfo.py", line 784, in getIpAddresses return filter(None, [getaddr(i) for i in ethtool.get_active_devices()]) File "/builddir/build/BUILD/vdsm-4.16.26/lib/vdsm/netinfo.py", line 300, in getaddr dev_info_list = ethtool.get_interfaces_info(dev.encode('utf8')) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe3 in position 5: ordinal not in range(128) -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Dan Kenigsberg has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 6: * Update tracker::#1228322::OK * Set MODIFIED::bug 1228322#1228322IGNORE, not all related patches are closed, check 43853 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: backport cmdutils.systemd_run .. net: backport cmdutils.systemd_run This is a minimal backport of cmdutils to 3.5. cmdutils is only a partial version of what was already included in the master branch. This was done to avoid meeting many dependencies just in order to fix a bug in the stable branch. Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Signed-off-by: Federico Simoncelli Bug-Url: https://bugzilla.redhat.com/1228322 Reviewed-on: https://gerrit.ovirt.org/43852 Tested-by: Ido Barkan Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg --- M configure.ac M debian/vdsm-python.install M lib/vdsm/Makefile.am A lib/vdsm/cmdutils.py M lib/vdsm/constants.py.in M tests/Makefile.am A tests/cmdutilsTests.py M vdsm.spec.in 8 files changed, 90 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Ido Barkan: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has uploaded a new change for review. Change subject: net: backport cmdutils.systemd_run .. net: backport cmdutils.systemd_run This is a minimal backport of cmdutils to 3.5. cmdutils is only a partial version of what was already included in the master branch. This was done to avoid meeting many dependencies just in order to fix a bug in the stable branch. Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Signed-off-by: Federico Simoncelli --- M configure.ac M debian/vdsm-python.install M lib/vdsm/Makefile.am A lib/vdsm/cmdutils.py M lib/vdsm/constants.py.in M tests/Makefile.am A tests/cmdutilsTests.py M vdsm.spec.in M vdsm/sudoers.vdsm.in 9 files changed, 87 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/43852/1 diff --git a/configure.ac b/configure.ac index 7d3472c..46c857b 100644 --- a/configure.ac +++ b/configure.ac @@ -264,6 +264,7 @@ AC_PATH_PROG([SU_PATH], [su], [/bin/su]) AC_PATH_PROG([SYSCTL_PATH], [sysctl], [/sbin/sysctl]) AC_PATH_PROG([SYSTEMCTL_PATH], [systemctl], [/bin/systemctl]) +AC_PATH_PROG([SYSTEMD_RUN_PATH], [systemd-run], [/usr/bin/systemd-run]) AC_PATH_PROG([TAR_PATH], [tar], [/bin/tar]) AC_PATH_PROG([TC_PATH], [tc], [/sbin/tc]) AC_PATH_PROG([TEE_PATH], [tee], [/usr/bin/tee]) diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install index 5f142a7..142dfce 100644 --- a/debian/vdsm-python.install +++ b/debian/vdsm-python.install @@ -2,6 +2,7 @@ ./usr/bin/vdsm-tool ./usr/lib/python2.7/dist-packages/vdsm/SecureXMLRPCServer.py ./usr/lib/python2.7/dist-packages/vdsm/__init__.py +./usr/lib/python2.7/dist-packages/vdsm/cmdutils.py ./usr/lib/python2.7/dist-packages/vdsm/compat.py ./usr/lib/python2.7/dist-packages/vdsm/config.py ./usr/lib/python2.7/dist-packages/vdsm/constants.py diff --git a/lib/vdsm/Makefile.am b/lib/vdsm/Makefile.am index aaf26bf..a0f5c72 100644 --- a/lib/vdsm/Makefile.am +++ b/lib/vdsm/Makefile.am @@ -23,6 +23,7 @@ dist_vdsmpylib_PYTHON = \ __init__.py \ + cmdutils.py \ compat.py \ define.py \ exception.py \ diff --git a/lib/vdsm/cmdutils.py b/lib/vdsm/cmdutils.py new file mode 100644 index 000..5d1c96e --- /dev/null +++ b/lib/vdsm/cmdutils.py @@ -0,0 +1,32 @@ +# +# Copyright 2014 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# +from . import constants + + +def systemd_run(cmd, scope=False, unit=None, slice=None): +command = [constants.EXT_SYSTEMD_RUN] +if scope: +command.append('--scope') +if unit: +command.append('--unit=%s' % unit) +if slice: +command.append('--slice=%s' % slice) +command.extend(cmd) +return command diff --git a/lib/vdsm/constants.py.in b/lib/vdsm/constants.py.in index 4539d26..e75796a 100644 --- a/lib/vdsm/constants.py.in +++ b/lib/vdsm/constants.py.in @@ -168,3 +168,4 @@ EXT_CURL_IMG_WRAP = '@LIBEXECDIR@/curl-img-wrap' EXT_FC_SCAN = '@LIBEXECDIR@/fc-scan' +EXT_SYSTEMD_RUN = '@SYSTEMD_RUN_PATH@' diff --git a/tests/Makefile.am b/tests/Makefile.am index ec9ab0b..bd15c19 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -29,6 +29,7 @@ cPopenTests.py \ capsTests.py \ clientifTests.py \ + cmdutilsTests.py \ configNetworkTests.py \ fileVolumeTests.py \ fileUtilTests.py \ diff --git a/tests/cmdutilsTests.py b/tests/cmdutilsTests.py new file mode 100644 index 000..a8c928b --- /dev/null +++ b/tests/cmdutilsTests.py @@ -0,0 +1,47 @@ +# +# Copyright 2015 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Founda
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 1: Verified-1 * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 2: -Verified * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 2: (1 comment) Looks ok, just need note in cmdutils.py to prevent confusion. https://gerrit.ovirt.org/#/c/43852/2/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py: Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: from . import constants Line 21: Please add a note here that this is a partial version of cmdutils from master. Line 22: Line 23: def systemd_run(cmd, scope=False, unit=None, slice=None): Line 24: command = [constants.EXT_SYSTEMD_RUN] Line 25: if scope: -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/43852/2/lib/vdsm/cmdutils.py File lib/vdsm/cmdutils.py: Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: from . import constants Line 21: > Please add a note here that this is a partial version of cmdutils from mast Done Line 22: Line 23: def systemd_run(cmd, scope=False, unit=None, slice=None): Line 24: command = [constants.EXT_SYSTEMD_RUN] Line 25: if scope: -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: The tests fail again because of bridges with same names. Maybe we should backport the fix from master? -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Dan Kenigsberg has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/43852/3/vdsm/sudoers.vdsm.in File vdsm/sudoers.vdsm.in: Line 32: @MULTIPATH_PATH@, \ Line 33: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \ Line 34: @SERVICE_PATH@ vdsmd *, \ Line 35: @REBOOT_PATH@ -f, \ Line 36: @SYSTEMD_RUN_PATH@ this is a security breach that should be fixed on master, as it allows vdsm to run ANY binary (provided it is prefixed with systemd-run). In this backport, we need it ONLY within setupNetwork, which is run already in supervdsm, so I don't think we need it at all in this file. Line 37: Line 38: vdsm ALL=(ALL) NOPASSWD: VDSM_LIFECYCLE, VDSM_STORAGE Line 39: Defaults:vdsm !requiretty -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
automat...@ovirt.org has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 4: * Update tracker::#1228322::OK * Check Bug-Url::OK * Check Public Bug::#1228322::OK, public bug * Check Product::#1228322::OK, Correct product oVirt * Check TR::#1228322::OK, correct target release 3.5.5 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43852/3/vdsm/sudoers.vdsm.in File vdsm/sudoers.vdsm.in: Line 32: @MULTIPATH_PATH@, \ Line 33: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \ Line 34: @SERVICE_PATH@ vdsmd *, \ Line 35: @REBOOT_PATH@ -f, \ Line 36: @SYSTEMD_RUN_PATH@ > this is a security breach that should be fixed on master, as it allows vdsm Done Line 37: Line 38: vdsm ALL=(ALL) NOPASSWD: VDSM_LIFECYCLE, VDSM_STORAGE Line 39: Defaults:vdsm !requiretty -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Ido Barkan has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: net: backport cmdutils.systemd_run
Nir Soffer has posted comments on this change. Change subject: net: backport cmdutils.systemd_run .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43852/3/vdsm/sudoers.vdsm.in File vdsm/sudoers.vdsm.in: Line 32: @MULTIPATH_PATH@, \ Line 33: @SETSID_PATH@ @IONICE_PATH@ -c ? -n ? @SU_PATH@ vdsm -s /bin/sh -c /usr/libexec/vdsm/spmprotect.sh*, \ Line 34: @SERVICE_PATH@ vdsmd *, \ Line 35: @REBOOT_PATH@ -f, \ Line 36: @SYSTEMD_RUN_PATH@ > this is a security breach that should be fixed on master, as it allows vdsm Fixed in https://gerrit.ovirt.org/43937 Line 37: Line 38: vdsm ALL=(ALL) NOPASSWD: VDSM_LIFECYCLE, VDSM_STORAGE Line 39: Defaults:vdsm !requiretty -- To view, visit https://gerrit.ovirt.org/43852 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7686e80c0880dcc28fa735d1dd3ab658136889f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Ido Barkan Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches