Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[ybronhei]

Yaniv Bronhaim has submitted this change and it was merged.

Change subject: net tests: Marking testFakeNics as broken
..


net tests: Marking testFakeNics as broken

The test testFakeNics fails when hidden nics
appear in netinfo nics report. Found no good
explanation why this may happen as the nics
comming from netinfo are filtered by their name.

Label: ovirt-3.5-only
Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/50580
Continuous-Integration: Dan Kenigsberg 
Reviewed-by: Dan Kenigsberg 
Reviewed-by: Yaniv Bronhaim 
Continuous-Integration: Yaniv Bronhaim 
---
M tests/netinfoTests.py
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, approved; Passed CI tests
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3: Code-Review+2 Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3:

Yaniv: yes, please!

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3:

can I take it ?

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3: Continuous-Integration+1

unrelated broken test

12:40:04 ERROR: testTogglePromisc (tcTests.TestQdisc)
12:40:04 --
12:40:04 Traceback (most recent call last):
12:40:04   File 
"/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/tcTests.py",
 line 175, in tearDown
12:40:04 self._bridge.delDevice()
12:40:04   File 
"/home/jenkins/workspace/vdsm_3.5_check-patch-el7-x86_64/vdsm/tests/tcTests.py",
 line 85, in delDevice
12:40:04 check_call([EXT_BRCTL, 'delbr', self.devName])
12:40:04   File "/usr/lib64/python2.7/subprocess.py", line 542, in check_call
12:40:04 raise CalledProcessError(retcode, cmd)
12:40:04 CalledProcessError: Command '['/usr/sbin/brctl', 'delbr', 
'vdsmtest-bWI3g']' returned non-zero exit status 1
12:40:04

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 3: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[edwardh]

Edward Haas has uploaded a new change for review.

Change subject: net tests: Marking testFakeNics as broken
..

net tests: Marking testFakeNics as broken

The test testFakeNics fails when hidden nics
appear in netinfo nics report. Found no good
explanation why this may happen as the nics
comming from netinfo are filtered by their name.

Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Signed-off-by: Edward Haas 
---
M tests/netinfoTests.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/50580/1

diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index 67ff285..5918885 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -38,7 +38,7 @@
 from ipwrapperTests import _fakeTypeDetection
 from monkeypatch import MonkeyPatch, MonkeyPatchScope
 from testrunner import VdsmTestCase as TestCaseBase, namedTemporaryDir
-from testValidation import ValidateRunningAsRoot
+from testValidation import ValidateRunningAsRoot, brokentest
 
 # speeds defined in ethtool
 ETHTOOL_SPEEDS = set([10, 100, 1000, 2500, 1])
@@ -212,6 +212,7 @@
 self.assertEqual(set(netinfo.nics()),
  set(['em', 'me', 'fake', 'fake0']))
 
+@brokentest("Unexplained behavior where netinfo.nics()")
 @ValidateRunningAsRoot
 def testFakeNics(self):
 with MonkeyPatchScope([(ipwrapper.Link, '_fakeNics', ['veth_*',


-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master, ovirt-3.6

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: net tests: Marking testFakeNics as broken

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: net tests: Marking testFakeNics as broken
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/50580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I499e0c6b916203a366bf2c3fbd9dad232ffc76a2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches