Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
automat...@ovirt.org has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 2: * Update tracker::#1158108::OK * Check TR::#1158108::OK * Set MODIFIED::bug 1158108#1158108OK -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Dan Kenigsberg has submitted this change and it was merged. Change subject: netlink: fix PEP8 in netlink memory leak patch .. netlink: fix PEP8 in netlink memory leak patch Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Bug-Url: https://bugzilla.redhat.com/1158108 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/40383 Reviewed-by: Yaniv Bronhaim Tested-by: Dan Kenigsberg --- M lib/vdsm/netlink.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Dan Kenigsberg: Verified -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Dan Kenigsberg has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: yes, the pep8 issue is only in 3.5. -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Dan Kenigsberg has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Yaniv Bronhaim has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: only relevant to 3.5? -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Yaniv Bronhaim has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
automat...@ovirt.org has posted comments on this change. Change subject: netlink: fix PEP8 in netlink memory leak patch .. Patch Set 1: * Update tracker::#1158108::OK * Check Bug-Url::OK * Check Public Bug::#1158108::OK, public bug * Check Product::#1158108::OK, Correct product oVirt * Check TR::#1158108::OK, correct target release 3.5.3 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/40383 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: netlink: fix PEP8 in netlink memory leak patch
Petr Horáček has uploaded a new change for review.
Change subject: netlink: fix PEP8 in netlink memory leak patch
..
netlink: fix PEP8 in netlink memory leak patch
Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61
Bug-Url: https://bugzilla.redhat.com/1158108
Signed-off-by: Petr Horáček
---
M lib/vdsm/netlink.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/40383/1
diff --git a/lib/vdsm/netlink.py b/lib/vdsm/netlink.py
index d822944..8aae2e5 100644
--- a/lib/vdsm/netlink.py
+++ b/lib/vdsm/netlink.py
@@ -333,7 +333,7 @@
_nl_af2str = _int_char_proto(('nl_af2str', LIBNL))
_rtnl_scope2str = _int_char_proto(('rtnl_scope2str', LIBNL_ROUTE))
-_rtnl_link_put = _none_proto(('rtnl_link_put', LIBNL_ROUTE))
+_rtnl_link_put = _none_proto(('rtnl_link_put', LIBNL_ROUTE))
_nl_link_cache = partial(_cache_manager, _rtnl_link_alloc_cache)
_nl_addr_cache = partial(_cache_manager, _rtnl_addr_alloc_cache)
--
To view, visit https://gerrit.ovirt.org/40383
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6af9e2a7e76c5d610d553df7a285d00c28d15d61
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
