Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Oved Ourfali has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Saggi Mizrahi has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Nir Soffer has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/33643/2/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 25: DEFAULT_ACCEPT_TIMEOUT = 5 Line 26: Line 27: # M2Crypto.threading needs initialization. Line 28: # See https://bugzilla.redhat.com/482420 Line 29: threading.init() Why this is new code? I move this code here few moth ago, after you deleted in one of your patches. Please separate this to a new patch and explain this change. Line 30: Line 31: Line 32: class SSLSocket(object): Line 33: def __init__(self, connection): Line 117: Line 118: try: Line 119: client.setup_ssl() Line 120: client.set_accept_state() Line 121: client.settimeout(self.accept_timeout) accept does not work in non-blocking mode? This is really bad for a non blocking server. Line 122: client.accept_ssl() Line 123: client.settimeout(None) Line 124: except SSL.SSLError as e: Line 125: raise SSL.SSLError(%s, client %s % (e, address[0])) -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Yaniv Bronhaim has submitted this change and it was merged. Change subject: ssl: ssl_accept blocks after reboot .. ssl: ssl_accept blocks after reboot When rebooting host most of the times ssl_accept blocks when there is new connection established just after socket is opened. Setting timeout on socket seems to help but when testing I noticed sometimes there is still connection blocked on ssl_accept. Bug-Url: https://bugzilla.redhat.com/1147487 Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Signed-off-by: pkliczewski piotr.kliczew...@gmail.com Signed-off-by: Saggi Mizrahi smizr...@redhat.com Reviewed-on: http://gerrit.ovirt.org/33643 Reviewed-by: Yaniv Bronhaim ybron...@redhat.com --- M lib/vdsm/sslutils.py 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
Yaniv Bronhaim has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot
oVirt Jenkins CI Server has posted comments on this change. Change subject: ssl: ssl_accept blocks after reboot .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el6-x86_64_merged/31/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc19-x86_64_merged/27/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc20-x86_64_merged/26/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-el7-x86_64_merged/31/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/33643 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches