Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Francesco Romani has submitted this change and it was merged. Change subject: tests: Fix unmount in mkimage tests .. tests: Fix unmount in mkimage tests These tests seem to fail too much lately. Inspecting the code reveal that we use freeloop=True in mkimage, but do not use this flag in the tests. This lead to consuming of all available loop devices, causing later mount attempts to fail. Change-Id: If68a378133757f86b534f65808b2212828d97228 Signed-off-by: Nir Soffer Bug-Url: https://bugzilla.redhat.com/1267851 Reviewed-on: https://gerrit.ovirt.org/46336 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/47038 Tested-by: Francesco Romani Continuous-Integration: Francesco Romani --- M tests/mkimageTests.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 4: * Update tracker::#1267851::OK * Set MODIFIED::bug 1267851#1267851IGNORE, not oVirt prod but vdsm -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Francesco Romani has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 3: CI scripts run manually -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Francesco Romani has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 3: Continuous-Integration+1 -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 3: * Update tracker::#1267851::OK * Check Bug-Url::OK * Check Public Bug::#1267851::OK, public bug * Check Product::#1267851::OK, Correct classification oVirt * Check TM::#1267851::OK, correct target milestone ovirt-3.5.6 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Dan Kenigsberg has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Nir Soffer has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 2: Note that this fix is not enough, we have some other fixes in master that should be backported as well if you want to avoid the mkimages tests failures in the CI. -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
David Caro has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 2: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 2: Verified-1 * Update tracker::#1267851::OK * Check Bug-Url::OK * Check Public Bug::#1267851::OK, public bug * Check Product::#1267851::OK, Correct classification oVirt * Check TM::#1267851::OK, correct target milestone ovirt-3.5.7 * Check merged to previous::WARN, Still missing on branches ovirt-3.6 -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 2: * Update tracker::#1267851::OK * Check Bug-Url::OK * Check Public Bug::#1267851::OK, public bug * Check Product::#1267851::OK, Correct classification oVirt * Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].* * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Francesco Romani has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 1: Continuous-Integration+1 run CI checks manually -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Nir Soffer has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Francesco Romani has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 1: Verified+1 verified running the tests. -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Piotr Kliczewski has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
automat...@ovirt.org has posted comments on this change. Change subject: tests: Fix unmount in mkimage tests .. Patch Set 1: * Update tracker::#1267851::OK * Check Bug-Url::OK * Check Public Bug::#1267851::OK, public bug * Check Product::#1267851::OK, Correct classification oVirt * Check TR::#1267851::ERROR, wrong target release for stable branch, --- should match ^3.[54321].* * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: tests: Fix unmount in mkimage tests
Hello Piotr Kliczewski, Petr Horáček, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/47038 to review the following change. Change subject: tests: Fix unmount in mkimage tests .. tests: Fix unmount in mkimage tests These tests seem to fail too much lately. Inspecting the code reveal that we use freeloop=True in mkimage, but do not use this flag in the tests. This lead to consuming of all available loop devices, causing later mount attempts to fail. Change-Id: If68a378133757f86b534f65808b2212828d97228 Signed-off-by: Nir Soffer Bug-Url: https://bugzilla.redhat.com/1267851 Reviewed-on: https://gerrit.ovirt.org/46336 Continuous-Integration: Jenkins CI Reviewed-by: Piotr Kliczewski Reviewed-by: Petr Horáček Reviewed-by: Dan Kenigsberg --- M tests/mkimageTests.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/47038/1 diff --git a/tests/mkimageTests.py b/tests/mkimageTests.py index 2d4da27..027516c 100644 --- a/tests/mkimageTests.py +++ b/tests/mkimageTests.py @@ -173,7 +173,7 @@ self._check_content(checkPerms=False) self._check_label(floppy, label) finally: -m.umount(force=True) +m.umount(force=True, freeloop=True) os.unlink(floppy) @permutations([[None], ['fslabel']]) @@ -203,7 +203,7 @@ (stat.S_IWOTH, False), (stat.S_IXOTH, False))) finally: -m.umount(force=True) +m.umount(force=True, freeloop=True) os.unlink(iso_img) def test_removeFs(self): -- To view, visit https://gerrit.ovirt.org/47038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If68a378133757f86b534f65808b2212828d97228 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
