Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
..


Patch Set 2:

* #1288513::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-04 Thread fromani 
Francesco Romani has abandoned this change.

Change subject: vm: reformat _EVENT_STRINGS
..


Abandoned

on hold, not sure we want to fix this on 3.5.x/x86

-- 
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
..


Patch Set 2:

* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check Product::#1288513::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1288513::OK, correct target milestone ovirt-3.5.7
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-03 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: vm: reformat _EVENT_STRINGS
..


Patch Set 1:

* #1284564::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284564::OK, public bug
* Check Product::#1284564::OK, Correct classification oVirt
* Check TM::#1284564::OK, correct target milestone ovirt-3.5.7
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.5]: vm: reformat _EVENT_STRINGS

2015-12-03 Thread fromani 
Hello Dan Kenigsberg, Milan Zamazal,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49673

to review the following change.

Change subject: vm: reformat _EVENT_STRINGS
..

vm: reformat _EVENT_STRINGS

Reformat code to make it easy to extend the known event list.

Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Format-Only: yes
Bug-Url: https://bugzilla.redhat.com/1284564
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/48530
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/48789
Reviewed-by: Milan Zamazal 
---
M vdsm/virt/vm.py
1 file changed, 10 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/49673/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ba4940c..8bc545a 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -184,14 +184,16 @@
 
 # These strings are representing libvirt virDomainEventType values
 # http://libvirt.org/html/libvirt-libvirt.html#virDomainEventType
-_EVENT_STRINGS = ("Defined",
-  "Undefined",
-  "Started",
-  "Suspended",
-  "Resumed",
-  "Stopped",
-  "Shutdown",
-  "PM-Suspended")
+_EVENT_STRINGS = (
+"Defined",
+"Undefined",
+"Started",
+"Suspended",
+"Resumed",
+"Stopped",
+"Shutdown",
+"PM-Suspended",
+)
 
 
 def eventToString(event):


-- 
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e8d577ebcee9e72cf70aab214f9ff42d46fcb9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Milan Zamazal 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches