Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 3: * Update tracker::#1216900::OK * Set MODIFIED::bug 1216900#1216900IGNORE, not oVirt prod but Red Hat Enterprise Virtualization Manager -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Dan Kenigsberg has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Dan Kenigsberg has submitted this change and it was merged. Change subject: vm payload: Add Joliet FS support .. vm payload: Add Joliet FS support Current payload ISO only uses Rock Ridge extension, as a result Windows VMs can't use payloads with long filenames. This fix adds the Joliet extension to the generated ISO. Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Bug-Url: https://bugzilla.redhat.com/1216900 Signed-off-by: Eldan Shachar Reviewed-on: https://gerrit.ovirt.org/40534 Reviewed-by: Francesco Romani Reviewed-by: Dan Kenigsberg --- M vdsm/mkimage.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eldan Shachar: Verified Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 2: * Update tracker::#1216900::OK * Check Bug-Url::OK * Check Public Bug::#1216900::OK, public bug * Check Product::#1216900::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1216900::OK, correct target release 3.5.3 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Francesco Romani has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Code-Review+1 code and code path should be the same as master -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has uploaded a new change for review. Change subject: vm payload: Add Joliet FS support .. vm payload: Add Joliet FS support Current payload ISO only uses Rock Ridge extension, as a result Windows VMs can't use payloads with long filenames. This fix adds the Joliet extension to the generated ISO. Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Bug-Url: https://bugzilla.redhat.com/1205058 Signed-off-by: Eldan Shachar --- M vdsm/mkimage.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/40534/1 diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py index 2b69a18..7633662 100644 --- a/vdsm/mkimage.py +++ b/vdsm/mkimage.py @@ -123,7 +123,7 @@ _decodeFilesIntoDir(files, dirname) isopath = _getFileName(vmId, files) -command = [EXT_MKISOFS, '-R', '-o', isopath] +command = [EXT_MKISOFS, '-R', '-J', '-o', isopath] if volumeName is not None: command.extend(['-V', volumeName]) command.extend([dirname]) -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: * Update tracker::#1205058::OK * Check Bug-Url::OK * Check Public Bug::#1205058::OK, public bug * Check Product::#1205058::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1205058::ERROR, wrong target release for stable branch, 3.6.0 should match ^3.[54321].* * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/40534 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45a48e53b93aa36aaf43100cdb8cdf00bbf18263 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has abandoned this change. Change subject: vm payload: Add Joliet FS support .. Abandoned -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: * Update tracker::#1205058::OK -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: sure I'll cherry-pick after it will be merged in master, because it was a small change I did it manually and forgot about the change-id. -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Francesco Romani has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: Code-Review-1 seems to be a different change, which breaks the flow. At least, should have the same change-id as master patch, to make it easily searchable on gerrit. The recommended flow is: - post patch against master, have it reviewed, verified and merged - cherry-pick commit from master to branch, in descending order (3.5 -> 3.4 -> ...). - on each branch, do any needed adjustement, if any (maybe code changed after branch was done), have separate independent review and verification -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Omer Frenkel Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
automat...@ovirt.org has posted comments on this change. Change subject: vm payload: Add Joliet FS support .. Patch Set 1: * Update tracker::#1205058::OK * Check Bug-Url::OK * Check Public Bug::#1205058::OK, public bug * Check Product::#1205058::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::#1205058::OK, correct target release 3.5.4 * warn_if_not_merged_to_previous_branch: OK -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: vm payload: Add Joliet FS support
Eldan Shachar has uploaded a new change for review. Change subject: vm payload: Add Joliet FS support .. vm payload: Add Joliet FS support Current payload ISO only uses Rock Ridge extension, as a result Windows VMs can't use payloads with long filenames. This fix adds the Joliet extension to the generated ISO. Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Bug-Url: https://bugzilla.redhat.com/1205058 Signed-off-by: Eldan Shachar --- M vdsm/mkimage.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/39898/1 diff --git a/vdsm/mkimage.py b/vdsm/mkimage.py index 2b69a18..7633662 100644 --- a/vdsm/mkimage.py +++ b/vdsm/mkimage.py @@ -123,7 +123,7 @@ _decodeFilesIntoDir(files, dirname) isopath = _getFileName(vmId, files) -command = [EXT_MKISOFS, '-R', '-o', isopath] +command = [EXT_MKISOFS, '-R', '-J', '-o', isopath] if volumeName is not None: command.extend(['-V', volumeName]) command.extend([dirname]) -- To view, visit https://gerrit.ovirt.org/39898 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I31dd2df17da7230ca3841209ce1dae3325dcd164 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Eldan Shachar ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
