Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 3:

* #1375076::Update tracker: OK
* Set MODIFIED::bug 1375076#1375076OK

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: Live Merge: Refresh base volume before live merge
..


Live Merge: Refresh base volume before live merge

When live merging raw base volume, engine extends the base volume
if it is smaller than the top volume. However, on the host running
the vm, the lv is already active and does not reflect the new size
until we refresh it.  During the merge we don't know whether base
volume extended, so we always refresh it.

Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Bug-Url: https://bugzilla.redhat.com/1375076
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/63454
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63634
Tested-by: Allon Mureinik 
Reviewed-by: Francesco Romani 
Continuous-Integration: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Allon Mureinik: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests
  Ala Hino: Verified

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Code-Review+2 Continuous-Integration+1

This failure is irrilevant:

00:06:31.819 
==
00:06:31.819 FAIL: test_events_keys (netlinkTests.NetlinkEventMonitorTests)
00:06:31.820 
--
00:06:31.820 Traceback (most recent call last):
00:06:31.820   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/testValidation.py",
 line 105, in wrapper
00:06:31.820 return f(*args, **kwargs)
00:06:31.820   File 
"/home/jenkins/workspace/vdsm_3.6_check-patch-fc23-x86_64/vdsm/tests/netlinkTests.py",
 line 133, in test_events_keys
00:06:31.820 % (1 + len(expected_events)))
00:06:31.821 AssertionError: 5 expected events have not been caught (in the 
right order)
00:06:31.821  >> begin captured logging << 

00:06:31.821 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link add 
name dummy_lBtFM type dummy (cwd None)
00:06:31.821 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.821 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip -4 addr add 
dev dummy_lBtFM 192.0.2.1/24 (cwd None)
00:06:31.821 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.822 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link set dev 
dummy_lBtFM up (cwd None)
00:06:31.822 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.822 root: DEBUG: /usr/bin/taskset --cpu-list 0-3 /sbin/ip link del dev 
dummy_lBtFM (cwd None)
00:06:31.822 root: DEBUG: SUCCESS:  = '';  = 0
00:06:31.822 - >> end captured logging << 
-

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Code-Review+1

Looks ok, let me try to make jenkins happy.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

Rerun-Hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: -Verified

* #1375076::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1375076::OK, public bug
* Check Product::#1375076::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1375076::OK, correct target milestone ovirt-3.6.10
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[ahino]

Ala Hino has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Verified+1

Verified following scenario on two different VMs - one running on SPM and other 
in HSM:
1. create a VM
2. add 1gb disk
3. create a snapshot
4. extend the disk by 1gb
5. run the VM
6. remove the snapshot

On both VMs, removing the snapshot successfully completed.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

Rerun-hooks: all

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

Rerun-hooks: All

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2: Verified+1

Fixed commit message to the 3.6 bug. Note that 
https://gerrit.ovirt.org/#/c/63532/ should be merged first.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 2:

* #1375076::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1375076::OK, public bug
* Check Product::#1375076::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1375076::OK, correct target milestone ovirt-3.6.10
* Check merged to previous::WARN, Still open on branches ovirt-4.0

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 1: Code-Review+1

Looks ok, but need testing with 3.6.

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[amureini]

Hello Nir Soffer, Ala Hino,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/63634

to review the following change.

Change subject: Live Merge: Refresh base volume before live merge
..

Live Merge: Refresh base volume before live merge

When live merging raw base volume, engine extends the base volume
if it is smaller than the top volume. However, on the host running
the vm, the lv is already active and does not reflect the new size
until we refresh it.  During the merge we don't know whether base
volume extended, so we always refresh it.

Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Bug-Url: https://bugzilla.redhat.com/1367281
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/63454
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M vdsm/virt/vm.py
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/63634/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index f50aa16..d719f1e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4947,6 +4947,25 @@
 if not self._can_merge_into(drive, baseInfo, topInfo):
 return errCode['destVolumeTooSmall']
 
+# If the base volume format is RAW and its size is smaller than its
+# capacity (this could happen because the engine extended the base
+# volume), we have to refresh the volume to cause lvm to get current lv
+# size from storage, and update the kernel so the lv reflects the real
+# size on storage. Not refreshing the volume may fail live merge.
+# This could happen if disk extended after taking a snapshot but before
+# performing the live merge.  See https://bugzilla.redhat.com/1367281
+if (drive.chunked and
+baseInfo['format'] == 'RAW' and
+int(baseInfo['apparentsize']) < int(baseInfo['capacity'])):
+self.log.info("Refreshing raw volume %r (apparentsize=%s, "
+  "capacity=%s)",
+  baseVolUUID, baseInfo['apparentsize'],
+  baseInfo['capacity'])
+self.__refreshDriveVolume({
+'domainID': drive.domainID, 'poolID': drive.poolID,
+'imageID': drive.imageID, 'volumeID': baseVolUUID,
+})
+
 # Take the jobs lock here to protect the new job we are tracking from
 # being cleaned up by queryBlockJobs() since it won't exist right away
 with self._jobsLock:


-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: Live Merge: Refresh base volume before live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Refresh base volume before live merge
..


Patch Set 1: Verified-1

* #1367281::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1367281::OK, public bug
* Check Product::#1367281::OK, Correct classification oVirt
* Check TM::#1367281::ERROR, wrong target milestone for stable branch, 
ovirt-4.0.5 should match ^.*3.6.*
* Check merged to previous::WARN, Still open on branches ovirt-4.0

-- 
To view, visit https://gerrit.ovirt.org/63634
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I787d6854e780035b09e4f09d71ca776342dff5be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org