Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-15 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-15 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-15 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: code coverage: change approach how to enable it
..


code coverage: change approach how to enable it

Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Signed-off-by: Petr Balogh 
Reviewed-on: https://gerrit.ovirt.org/49168
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
Tested-by: Nir Soffer 
(cherry picked from commit a037a21a7525054680845dd1b0e657d828a98893)
Reviewed-on: https://gerrit.ovirt.org/50263
Reviewed-by: Francesco Romani 
---
M lib/vdsm/config.py.in
M vdsm/vdsm
2 files changed, 6 insertions(+), 6 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Petr Balogh: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-11 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-10 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-10 Thread pbalogh 
Petr Balogh has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Verified+1

Hello, I've already verified it on my 3.6 environment . If it is enough 
consider it as verified.

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Balogh 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-10 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-10 Thread pbalogh 
Petr Balogh has uploaded a new change for review.

Change subject: code coverage: change approach how to enable it
..

code coverage: change approach how to enable it

Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Signed-off-by: Petr Balogh 
Reviewed-on: https://gerrit.ovirt.org/49168
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
Tested-by: Nir Soffer 
(cherry picked from commit a037a21a7525054680845dd1b0e657d828a98893)
---
M lib/vdsm/config.py.in
M vdsm/vdsm
2 files changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/50263/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 9cab004..ddaa784 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -406,6 +406,11 @@
 ('manhole_enable', 'false',
 'Enable manhole debugging service (requires manhole package).'),
 
+('coverage_enable', 'false',
+'Enable code coverage (requires python-coverage package). '
+'false by default. Use environment file /etc/sysconfig/vdsm to '
+'set COVERAGE_PROCESS_START and COVERAGE_FILE variables.'),
+
 ]),
 
 # Section: [gluster]
diff --git a/vdsm/vdsm b/vdsm/vdsm
index c9b6219..8f508d4 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -139,14 +139,9 @@
 # plugin and we would like to print that out.
 pass
 
-# Used to enable code coverage. On production machines
-# "coverage" should not exists and COVERAGE_PROCESS_START should not be
-# set.
-try:
+if config.getboolean('devel', 'coverage_enable'):
 import coverage
 coverage.process_startup()
-except ImportError:
-pass
 
 log = logging.getLogger('vds')
 try:


-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: code coverage: change approach how to enable it

2015-12-10 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: code coverage: change approach how to enable it
..


Patch Set 1: Code-Review+1

I usually require bugs for patches on stable branch, unless the patch does NOT 
changes production code (e.g. some changes on tests, stuff under automation/*).

In this case, we do change production code, but the change is minimal and 
mistakes are easy to spot, hence a full BZ seems overkill.

Let's go ahead without bz, but please verify *on branch*.
Looks good, will merge once branch 3.6.1 is created.

-- 
To view, visit https://gerrit.ovirt.org/50263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I49d8de0fd7c329d19a80827a4c2fd26eb70e04be
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Balogh 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches