Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-03 Thread fromani 
Hello Piotr Kliczewski,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49614

to review the following change.

Change subject: daemon: keep running without affinity.
..

daemon: keep running without affinity.

The cpu affinity is one (important) performance setting,
but Vdsm should keep running even if it fails to set it.

To run without affinity doesn't harm the functionality.

Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Bug-Url: https://bugzilla.redhat.com/1279431
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/49562
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Nir Soffer 
---
M vdsm/vdsm
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/14/49614/1

diff --git a/vdsm/vdsm b/vdsm/vdsm
index dcf4506..65bfd4b 100755
--- a/vdsm/vdsm
+++ b/vdsm/vdsm
@@ -163,7 +163,10 @@
 log.info('(PID: %s) I am the actual vdsm %s %s (%s)',
  pid, dsaversion.raw_version_revision, nodename, release)
 
-__set_cpu_affinity()
+try:
+__set_cpu_affinity()
+except Exception:
+log.exception('Failed to set affinity, running without')
 
 serve_clients(log)
 except:


-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 1:

* #1279431::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279431::OK, public bug
* Check Product::#1279431::OK, Correct classification oVirt
* Check TM::#1279431::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2:

* #1279431::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279431::OK, public bug
* Check Product::#1279431::OK, Correct classification oVirt
* Check TM::#1279431::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-03 Thread piotr . kliczewski 
Piotr Kliczewski has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2: Verified+1

re-verified on branch, subset of tests done for master patch

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-14 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: daemon: keep running without affinity.
..


Patch Set 3:

* #1279431::Update tracker: OK
* Set MODIFIED::bug 1279431#1279431OK

-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: daemon: keep running without affinity.

2015-12-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: daemon: keep running without affinity.
..


daemon: keep running without affinity.

The cpu affinity is one (important) performance setting,
but Vdsm should keep running even if it fails to set it.

To run without affinity doesn't harm the functionality.

Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Bug-Url: https://bugzilla.redhat.com/1279431
Backport-To: 3.6
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/49562
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Reviewed-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/49614
---
M vdsm/vdsm
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49614
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1cb45213b24016cc9be4b6690084b3a4445ef364
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches