Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 3:

* #1286565::Update tracker: OK
* Set MODIFIED::bug 1286565#1286565IGNORE, not all related patches are 
closed, check 49474

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


gluster: Warn instead of failing for unsupported gluster replica modes

A previous patch enforced the use of only supported gluster replication
modes.  If an unsupported mode was requested, the connection attempt
would fail.  Unfortunately, this was a bit heavy-handed and has resulted
in breaking working environments during upgrade. To lessen the impact on
users, instead of failing, log a warning. A related patch to
ovirt-engine will warn users about the unsupported replication mode in
the UI.

Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Signed-off-by: Ala Hino 
Bug-Url: https://bugzilla.redhat.com/1286565
Reviewed-on: https://gerrit.ovirt.org/50119
Reviewed-by: Nir Soffer 
Reviewed-by: Sahina Bose 
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/50258
Reviewed-by: Francesco Romani 
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 6 insertions(+), 9 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[fromani]

Francesco Romani has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2: Code-Review+1

looks OK, will merge once branch 3.6.1 is created. ETA: next monday (20151214)

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 1:

Ala, correction, why gerrit hooks are unhappy.

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 1: Code-Review-1

Gerrit is not happy because you uploaded this when the master change was not 
merged yet.

Please add the missing metadata to the commit message.

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 1: Code-Review+1

Ala, please check why jenkins in unhappy.

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2: -Verified

* #1286565::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1286565::OK, public bug
* Check Product::#1286565::OK, Correct classification oVirt
* Check TM::#1286565::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 2:

> Gerrit is not happy because you uploaded this when the master
 > change was not merged yet.
 > 
 > Please add the missing metadata to the commit message.

Done

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 1: Verified-1

* #1286565::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1286565::OK, public bug
* Check Product::#1286565::OK, Correct classification oVirt
* Check TM::#1286565::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[ahino]

Ala Hino has uploaded a new change for review.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..

gluster: Warn instead of failing for unsupported gluster replica modes

A previous patch enforced the use of only supported gluster replication
modes.  If an unsupported mode was requested, the connection attempt
would fail.  Unfortunately, this was a bit heavy-handed and has resulted
in breaking working environments during upgrade. To lessen the impact on
users, instead of failing, log a warning. A related patch to
ovirt-engine will warn users about the unsupported replication mode in
the UI.

Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Signed-off-by: Ala Hino 
Bug-Url: https://bugzilla.redhat.com/1286565
---
M tests/storageServerTests.py
M vdsm/storage/storageServer.py
2 files changed, 6 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/50258/1

diff --git a/tests/storageServerTests.py b/tests/storageServerTests.py
index 70f71ca..13cb27e 100644
--- a/tests/storageServerTests.py
+++ b/tests/storageServerTests.py
@@ -25,7 +25,6 @@
 from storage.storageServer import IscsiConnection
 from storage.storageServer import MountConnection
 from storage import storageServer
-from storage import storage_exception as se
 
 
 class FakeSupervdsm(object):
@@ -228,8 +227,8 @@
 
 @MonkeyPatch(storageServer, 'supervdsm', FakeSupervdsm())
 @MonkeyPatch(GlusterFSConnection, 'ALLOWED_REPLICA_COUNTS', ('1', '3'))
-@permutations([['1', True], ['2', False], ['3', True], ['4', False]])
-def test_allowed_gluster_replica_count(self, replica_count, supported):
+@permutations([['1'], ['2'], ['3'], ['4']])
+def test_allowed_gluster_replica_count(self, replica_count):
 
 def glusterVolumeInfo(volumeName=None, remoteServer=None):
 return {'music': {'replicaCount': replica_count}}
@@ -237,8 +236,4 @@
 storageServer.supervdsm.glusterVolumeInfo = glusterVolumeInfo
 
 gluster = GlusterFSConnection(spec="192.168.122.1:/music")
-if supported:
-gluster.validate()
-else:
-self.assertRaises(se.UnsupportedGlusterVolumeReplicaCountError,
-  gluster.validate)
+gluster.validate()
diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py
index 9f09aa4..35cf81e 100644
--- a/vdsm/storage/storageServer.py
+++ b/vdsm/storage/storageServer.py
@@ -334,7 +334,9 @@
 def validate(self):
 replicaCount = self.volinfo['replicaCount']
 if replicaCount not in self.ALLOWED_REPLICA_COUNTS:
-raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
+self.log.warning("Unsupported replica count (%s) for volume %r, "
+ "please upgrade volume to replica 3",
+ replicaCount, self._volname)
 
 def _get_backup_servers_option(self):
 servers = utils.unique(brick.split(":")[0] for brick


-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

[ahino]

Ala Hino has posted comments on this change.

Change subject: gluster: Warn instead of failing for unsupported gluster 
replica modes
..


Patch Set 1: Verified+1

Verified on master

-- 
To view, visit https://gerrit.ovirt.org/50258
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I359e2405153f45b6ae303e00eb0e04a5ae14cb99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches