Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 2: Code-Review+2

huge patch, trusting you guys!

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hooks: Open vSwitch configurator
..


hooks: Open vSwitch configurator

This patch introduces new hook which allows us to configure OVS network
instead of standard linux network.

Configuration is done by one big ovs-vsctl command executed at once, it
apply the whole configuration iff all commands are correct.

Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/40312
Reviewed-by: Ido Barkan 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49689
Continuous-Integration: Dan Kenigsberg 
Reviewed-by: Francesco Romani 
---
M .gitignore
M configure.ac
A debian/vdsm-hook-ovs.docs
A debian/vdsm-hook-ovs.install
M tests/functional/Makefile.am
A tests/functional/networkTestsOVS.py
M vdsm.spec.in
M vdsm_hooks/Makefile.am
A vdsm_hooks/ovs/Makefile.am
A vdsm_hooks/ovs/README
A vdsm_hooks/ovs/ovs_after_get_caps.py
A vdsm_hooks/ovs/ovs_after_get_stats.py
A vdsm_hooks/ovs/ovs_before_device_create.py
A vdsm_hooks/ovs/ovs_before_network_setup.py
A vdsm_hooks/ovs/ovs_before_network_setup_ip.py
A vdsm_hooks/ovs/ovs_before_network_setup_mtu.py
A vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
A vdsm_hooks/ovs/ovs_utils.py
A vdsm_hooks/ovs/sudoers.in
19 files changed, 1,901 insertions(+), 0 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49690

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[ibarkan]

Ido Barkan has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/49689/2/vdsm_hooks/Makefile.am
File vdsm_hooks/Makefile.am:

Line 27: ovs
is this later fixed (and backported) later in this branch? iirc this was later 
mved under 'if HOOKS'.


-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 2: Code-Review+2 Continuous-Integration+1

15:29:06 Error: nothing provides ovirt-vmconsole >= 1.0.0-0 needed by 
vdsm-4.17.11-10.git245d14f.fc23.noarch.

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 2:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 2: Verified+1

Passed network tests OK, OVS tests passed with a few expected fails.

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: Open vSwitch configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Open vSwitch configurator
..


Patch Set 1:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49689
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id602b6cc87a663424d06c77d1847d2c2d60d289f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches