Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-07 Thread phoracek 
Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49977

to review the following change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..

hooks: ovs: run ovs _configure only if there are changes to do

Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/49245
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
---
M vdsm_hooks/ovs/ovs_before_network_setup.py
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/49977/1

diff --git a/vdsm_hooks/ovs/ovs_before_network_setup.py 
b/vdsm_hooks/ovs/ovs_before_network_setup.py
index 6cc1f14..fa8cfb5 100755
--- a/vdsm_hooks/ovs/ovs_before_network_setup.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup.py
@@ -182,9 +182,10 @@
 else:
 ovs_nets, non_ovs_nets, ovs_bonds, non_ovs_bonds = \
 _separate_ovs_nets_bonds(networks, bondings, running_config)
-_configure(ovs_nets, ovs_bonds, running_config)
-_set_nets_bonds(setup_nets_config['request'], non_ovs_nets,
-non_ovs_bonds)
+if ovs_nets or ovs_bonds:
+_configure(ovs_nets, ovs_bonds, running_config)
+_set_nets_bonds(setup_nets_config['request'], non_ovs_nets,
+non_ovs_bonds)
 log('Hook finished, returning non-OVS networks and bondings back to '
 'VDSM: %s' % setup_nets_config)
 


-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 1:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-08 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 1: Verified+1

Passed ovs tests without a regression.

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-09 Thread ibarkan 
Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 2:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


hooks: ovs: run ovs _configure only if there are changes to do

Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/49245
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49977
Reviewed-by: Ido Barkan 
Reviewed-by: Francesco Romani 
---
M vdsm_hooks/ovs/ovs_before_network_setup.py
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hooks: ovs: run ovs _configure only if there are changes to do

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..


Patch Set 3:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867OK

-- 
To view, visit https://gerrit.ovirt.org/49977
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I01033314b633d5ffa50b7d4ff8e0d4dcc2a8c048
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches