Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 7:

* #1325485::Update tracker: OK
* Set MODIFIED::bug 1325485#1325485IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


hostdev: ignore scsi devices when retrieving addresses

Since hostdev in 3.6 supports only USB & PCI devices, people using
custom hooks that passthrough SCSI devices will find their hooks
broken. This change skips non-PCI and non-USB host devices when looking
up the device addresses.

Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Label: ovirt-3.6-only
Bug-Url: https://bugzilla.redhat.com/1325485
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/55957
Reviewed-by: Michal Skrivanek 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Michal Skrivanek: Looks good to me, but someone else must approve
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 6: Code-Review+1

tested by a RHEV user

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 6: Verified+1

copying v

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 6: Verified-1

* #1325485::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325485::OK, public bug
* Check Product::#1325485::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1325485::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 5:

* #1325485::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325485::OK, public bug
* Check Product::#1325485::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1325485::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 4: Code-Review+1

(1 comment)

please tag as 3.6-only

https://gerrit.ovirt.org/#/c/55957/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4092: for x in self._domain.devices.childNodes:
Line 4093: # Ignore empty nodes, devices without address and host 
devices
Line 4094: if (x.nodeName == '#text' or
Line 4095: not x.getElementsByTagName('address')
Line 4096: or x.nodeName == 'hostdev'):
I would add a comment that this is actually more of a hack to get it working 
with custom hooks. It won't stay like that on master
Line 4097: continue
Line 4098: 
Line 4099: alias = 
x.getElementsByTagName('alias')[0].getAttribute('name')
Line 4100: if not isKnownDevice(alias):


-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 4: Verified+1

Field tested, shouldn't break scsi hooks.

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 4: Verified-1

* #1325485::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325485::OK, public bug
* Check Product::#1325485::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1325485::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 3: -Code-Review

let's discuss the possible hacky code for 3.6 only. It is tested in the field 
alreadyit's not nice, but I guess if 3.6-only we can live with it

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 3: -Verified

although VDSM side seems fine, needs investigation w/ 3.6 engine

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 3:

we use the

Label: ovirt-3.6-only

convention, but not sure that Jenkins knows about that.

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 3:

do we have a tag for 3.6 only?

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 3: Verified-1

* #1325485::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325485::OK, public bug
* Check Product::#1325485::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1325485::OK, correct target milestone ovirt-3.6.5
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 2: Verified+1

tested w/ scsi passtrhough VM having this branch

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 2: Code-Review+1

(1 comment)

IIUC, the commit message should be rephrased to make things clearer.
Based on my understanding, this should be OK, hence partial ACK.
Please check inside question.

https://gerrit.ovirt.org/#/c/55957/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS2, Line 4273: elif device_type != 'pci':
  : continue
so we just skip non-pci, non-usb devices, right? If so, this was not obvious in 
the commit message, that could be rephrased to highlight this.


-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 2:

* #1325485::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1325485::OK, public bug
* Check Product::#1325485::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1325485::OK, correct target milestone ovirt-3.6.6
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: ignore scsi devices when retrieving addresses

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: ignore scsi devices when retrieving addresses
..

hostdev: ignore scsi devices when retrieving addresses

Since hostdev in 3.6 supports only USB & PCI devices, people using
custom hooks that passthrough SCSI devices will find their hooks
broken. This change avoids trying to get the generated libvirt address
for such devices.

Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Signed-off-by: Martin Polednik 
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/55957/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 4d0a96d..9a4e23d 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4270,6 +4270,8 @@
 if device_type == 'usb':
 self._getUnderlyingHostDeviceUSBInfo(x)
 continue
+elif device_type != 'pci':
+continue
 alias = x.getElementsByTagName('alias')[0].getAttribute('name')
 address = self._getUnderlyingDeviceAddress(x)
 source = x.getElementsByTagName('source')[0]


-- 
To view, visit https://gerrit.ovirt.org/55957
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9743e4d3ab1f071bd0a1c1320fcaa2861fa23121
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches