Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
gerrit-hooks has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 2: * update_tracker: OK * Set MODIFIED::bug 1358348#1358348::SKIPPED, tm_suffix '' does not match branch_suffix '3.6'. -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Francesco Romani has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Francesco Romani has submitted this change and it was merged. Change subject: lvm: Improve logging lv activation logging .. lvm: Improve logging lv activation logging Log vg name and lv names when we activate, refresh or deactivate lvs. All are important state changes that should be logged in INFO level. The actual lvm commands are logged in DEBUG level, and may not be available when we change the default log level to INFO. Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Bug-Url: https://bugzilla.redhat.com/1358348 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/61286 Reviewed-by: Allon Mureinik Reviewed-by: Adam Litke Continuous-Integration: Jenkins CI Reviewed-on: https://gerrit.ovirt.org/62732 Reviewed-by: Freddy Rolland Tested-by: Allon Mureinik Reviewed-by: Francesco Romani --- M vdsm/storage/lvm.py 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified Francesco Romani: Looks good to me, approved Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Allon Mureinik has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Verified+1 Marking VERIFIED as per automation tier 1 run. -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Nir Soffer has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Francesco Romani has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Code-Review+1 seems OK, but please verify on branch. -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
gerrit-hooks has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: -Verified * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358348::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Francesco Romani has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Rerun-Hooks: all -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Freddy Rolland has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
gerrit-hooks has posted comments on this change. Change subject: lvm: Improve logging lv activation logging .. Patch Set 1: Verified-1 * update_tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358348::ERROR, private bug * Check Public Bug::WARN, no public bug url found * Check merged to previous::WARN, Still missing on branches ovirt-4.0 -- To view, visit https://gerrit.ovirt.org/62732 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-3.6]: lvm: Improve logging lv activation logging
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62732
to review the following change.
Change subject: lvm: Improve logging lv activation logging
..
lvm: Improve logging lv activation logging
Log vg name and lv names when we activate, refresh or deactivate lvs.
All are important state changes that should be logged in INFO level.
The actual lvm commands are logged in DEBUG level, and may not be
available when we change the default log level to INFO.
Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d
Bug-Url: https://bugzilla.redhat.com/1358348
Signed-off-by: Nir Soffer
Reviewed-on: https://gerrit.ovirt.org/61286
Reviewed-by: Allon Mureinik
Reviewed-by: Adam Litke
Continuous-Integration: Jenkins CI
---
M vdsm/storage/lvm.py
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/62732/1
diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py
index 3cf0506..2925d83 100644
--- a/vdsm/storage/lvm.py
+++ b/vdsm/storage/lvm.py
@@ -1201,9 +1201,11 @@
inactive.append(lvName)
if active:
+log.info("Refreshing lvs: vg=%s lvs=%s", vgName, active)
refreshLVs(vgName, active)
if inactive:
+log.info("Activating lvs: vg=%s lvs=%s", vgName, inactive)
_setLVAvailability(vgName, inactive, "y")
@@ -1212,6 +1214,7 @@
toDeactivate = [lvName for lvName in lvNames
if _isLVActive(vgName, lvName)]
if toDeactivate:
+log.info("Deactivating lvs: vg=%s lvs=%s", vgName, toDeactivate)
_setLVAvailability(vgName, toDeactivate, "n")
--
To view, visit https://gerrit.ovirt.org/62732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I368b158c8d60ae2ff252e038b01024e4598b5f4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
