Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
Francesco Romani has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: Dan, do we want this on 3.6.z? -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
Edward Haas has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: We used centos-ovirt40-candidate in master, but I think for 3.6 we should use something else. Looks like it is already in centos-ovirt36 (http://mirror.centos.org/centos/7/virt/x86_64/ovirt-3.6/) Also here: http://cbs.centos.org/repos/virt7-ovirt-36-release/x86_64/os Not sure which one should be taken. -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
Pavel Zhukov has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
Dan Kenigsberg has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: https://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/ is suddenly not found (404). Petr/Edy: do we need to backport some of commit 32b98cbe1 to avoid that? -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
Edward Haas has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
gerrit-hooks has posted comments on this change. Change subject: net: Ignore noqueue queuing discipline .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: Ignore noqueue queuing discipline
Hello Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/57557 to review the following change. Change subject: net: Ignore noqueue queuing discipline .. net: Ignore noqueue queuing discipline tc qdisc show reports the qdisc noqueue discipline on virtual devices on updated Fedora 23. The patch gracefully ignores the 'noqueue' line. It is backported to the 3.6 branch only in order to let it pass unit test on a host running Fedora 23. Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/56532 Reviewed-by: Dan Kenigsberg Continuous-Integration: Jenkins CI --- M vdsm/network/tc/__init__.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/57557/1 diff --git a/vdsm/network/tc/__init__.py b/vdsm/network/tc/__init__.py index a623d1e..b869e2f 100644 --- a/vdsm/network/tc/__init__.py +++ b/vdsm/network/tc/__init__.py @@ -154,6 +154,8 @@ out = module.show(dev, **kwargs) for line in _parser.linearize(out.splitlines()): +if len(line) >= 2 and line[0] == 'qdisc' and line[1] == 'noqueue': +continue tokens = iter(line) _parser.consume(tokens, 'qdisc', 'class', 'filter') yield module.parse(tokens) -- To view, visit https://gerrit.ovirt.org/57557 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Edward Haas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
