Change in vdsm[ovirt-3.6]: net: fix systemd race in exec_ifup
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: fix systemd race in exec_ifup .. net: fix systemd race in exec_ifup We set unique uuid for every systemd-run to not use the same unit twice and prevent systemd_run race (BZ#1259468). This uuid could be dropped when BZ#1272368 will be solved or when we use systemd >= v220. Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Bug-Url: https://bugzilla.redhat.com/1259468 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/47627 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/48755 Continuous-Integration: Dan Kenigsberg --- M vdsm/network/configurators/ifcfg.py 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Petr Horáček: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/48755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: fix systemd race in exec_ifup
gerrit-hooks has posted comments on this change. Change subject: net: fix systemd race in exec_ifup .. Patch Set 2: * #1259468::Update tracker: OK * Set MODIFIED::bug 1259468#1259468OK, already on MODIFIED -- To view, visit https://gerrit.ovirt.org/48755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: fix systemd race in exec_ifup
Dan Kenigsberg has posted comments on this change. Change subject: net: fix systemd race in exec_ifup .. Patch Set 1: Code-Review+2 Continuous-Integration+1 unrelated failure 14:47:29 MountError: (32, ';mount: /tmp/vdsm-mkimage-testshptMXU/images/vmId_iso.03eb9fe9737f7825fa7538a33ed567a4.img: failed to setup loop device: No such file or directory\n') -- To view, visit https://gerrit.ovirt.org/48755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: fix systemd race in exec_ifup
Petr Horáček has posted comments on this change. Change subject: net: fix systemd race in exec_ifup .. Patch Set 1: Verified+1 Functional network tests passed OK -- To view, visit https://gerrit.ovirt.org/48755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: fix systemd race in exec_ifup
gerrit-hooks has posted comments on this change. Change subject: net: fix systemd race in exec_ifup .. Patch Set 1: * #1259468::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1259468::OK, public bug * Check Product::#1259468::OK, Correct classification oVirt * Check TM::#1259468::OK, correct target milestone ovirt-3.6.2 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/48755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: net: fix systemd race in exec_ifup
Hello Ido Barkan, Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/48755 to review the following change. Change subject: net: fix systemd race in exec_ifup .. net: fix systemd race in exec_ifup We set unique uuid for every systemd-run to not use the same unit twice and prevent systemd_run race (BZ#1259468). This uuid could be dropped when BZ#1272368 will be solved or when we use systemd >= v220. Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Bug-Url: https://bugzilla.redhat.com/1259468 Signed-off-by: Petr Horáček Reviewed-on: https://gerrit.ovirt.org/47627 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan Reviewed-by: Dan Kenigsberg --- M vdsm/network/configurators/ifcfg.py 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/48755/1 diff --git a/vdsm/network/configurators/ifcfg.py b/vdsm/network/configurators/ifcfg.py index eae734a..03aee3b 100644 --- a/vdsm/network/configurators/ifcfg.py +++ b/vdsm/network/configurators/ifcfg.py @@ -30,6 +30,7 @@ import selinux import shutil import threading +import uuid from libvirt import libvirtError, VIR_ERR_NO_NETWORK @@ -797,7 +798,11 @@ cmd = [constants.EXT_IFUP, iface_name] if cgroup is not None: -cmd = cmdutils.systemd_run(cmd, scope=True, slice=cgroup) +# TODO: We set unique uuid for every run to not use the same unit twice +# and prevent systemd_run race (BZ#1259468). This uuid could be dropped +# when BZ#1272368 will be solved or when we use systemd >= v220. +cmd = cmdutils.systemd_run(cmd, scope=True, unit=uuid.uuid4(), + slice=cgroup) rc, out, err = utils.execCmd(cmd, raw=False) -- To view, visit https://gerrit.ovirt.org/48755 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I331f5aa33e8c8c0038a91b3f700c93ba3f416fa3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Ido Barkan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
