Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: net: sysctl: enable ipv6
..


net: sysctl: enable ipv6

Enable sysctl.py:disable_ipv6(dev) to set /pro/sys/.../disable_ipv6
also to '0'. This is needed in following Open vSwitch hook patch.

Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/44992
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
Reviewed-on: https://gerrit.ovirt.org/49687
Reviewed-by: Ido Barkan 
Reviewed-by: Francesco Romani 
---
M lib/vdsm/sysctl.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 2:

* #1234867::Update tracker: OK
* Set MODIFIED::bug 1234867#1234867IGNORE, not all related patches are 
closed, check 49688

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-06 Thread ibarkan 
Ido Barkan has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-06 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 1: Code-Review+2 Continuous-Integration+1

'JsonRpcNoResponseError: [-32605] No response for JSON-RPC echo request.' is 
obviously unrelated.

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-04 Thread phoracek 
Petr Horáček has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 1: Verified+1

Passed network tests. Jenkins' 'JsonRpcNoResponseError: [-32605] No response 
for JSON-RPC echo request.' is obviously unrelated.

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-03 Thread phoracek 
Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/49687

to review the following change.

Change subject: net: sysctl: enable ipv6
..

net: sysctl: enable ipv6

Enable sysctl.py:disable_ipv6(dev) to set /pro/sys/.../disable_ipv6
also to '0'. This is needed in following Open vSwitch hook patch.

Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Signed-off-by: Petr Horáček 
Reviewed-on: https://gerrit.ovirt.org/44992
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Dan Kenigsberg 
Bug-Url: https://bugzilla.redhat.com/1234867
---
M lib/vdsm/sysctl.py
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/49687/1

diff --git a/lib/vdsm/sysctl.py b/lib/vdsm/sysctl.py
index 766ae11..957e61f 100644
--- a/lib/vdsm/sysctl.py
+++ b/lib/vdsm/sysctl.py
@@ -38,9 +38,9 @@
 set_rp_filter(dev, _RPFILTER_STRICT)
 
 
-def disable_ipv6(dev):
+def disable_ipv6(dev, disable=True):
 with open('/proc/sys/net/ipv6/conf/%s/disable_ipv6' % dev, 'w') as f:
-f.write('1')
+f.write('1' if disable else '0')
 
 
 def is_disabled_ipv6():


-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: net: sysctl: enable ipv6

2015-12-03 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: sysctl: enable ipv6
..


Patch Set 1:

* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234867::OK, Correct classification oVirt
* Check TM::#1234867::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeb47c9df152b29926f40b9b41a3ad5b7e659ddd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches