Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 2:

* #1353559::Update tracker: OK
* Set MODIFIED::bug 1353559#1353559FAILED, illegal change from ON_QA

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


sla: Use GuestIoTuneOptional collector in MOM

All major collectors in MOM now have the optional variant
that makes sure the VM can be processed even when some of
the functionality is missing.

The IoTune collector was the last one affected by this.

Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353559
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/59936
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit a030644e6ba0c05b438f80c59c451839adffb353)
Reviewed-on: https://gerrit.ovirt.org/59988
Continuous-Integration: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/60525
---
M vdsm.spec.in
M vdsm/mom.conf.in
M vdsm/mom.d/05-iotune.policy
3 files changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Martin Sivák: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-13 Thread msivak 
Martin Sivák has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-11 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-11 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..


Patch Set 1:

* #1353559::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1353559::OK, public bug
* Check Product::#1353559::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1353559::ERROR, wrong target milestone for stable branch, 
ovirt-4.0.1 should match ^.*3.6.*
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: sla: Use GuestIoTuneOptional collector in MOM

2016-07-11 Thread msivak 
Hello Dan Kenigsberg, Francesco Romani,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/60525

to review the following change.

Change subject: sla: Use GuestIoTuneOptional collector in MOM
..

sla: Use GuestIoTuneOptional collector in MOM

All major collectors in MOM now have the optional variant
that makes sure the VM can be processed even when some of
the functionality is missing.

The IoTune collector was the last one affected by this.

Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1353559
Signed-off-by: Martin Sivak 
Reviewed-on: https://gerrit.ovirt.org/59936
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
(cherry picked from commit a030644e6ba0c05b438f80c59c451839adffb353)
Reviewed-on: https://gerrit.ovirt.org/59988
Continuous-Integration: Francesco Romani 
---
M vdsm.spec.in
M vdsm/mom.conf.in
M vdsm/mom.d/05-iotune.policy
3 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/60525/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 142e2e1..1f093a7 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -84,7 +84,7 @@
 BuildRequires: libselinux-python
 BuildRequires: libvirt-python
 BuildRequires: m2crypto
-BuildRequires: mom >= 0.5.4
+BuildRequires: mom >= 0.5.5
 BuildRequires: openssl
 BuildRequires: policycoreutils-python
 BuildRequires: psmisc
diff --git a/vdsm/mom.conf.in b/vdsm/mom.conf.in
index 0388162..f079673 100644
--- a/vdsm/mom.conf.in
+++ b/vdsm/mom.conf.in
@@ -81,4 +81,4 @@
 
 [guest]
 # A comma-separated list of Collector plugins to use for Guest data collection.
-collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, 
GuestCpuTune, GuestIoTune
+collectors: GuestQemuProc, GuestMemoryOptional, GuestBalloonOptional, 
GuestCpuTune, GuestIoTuneOptional
diff --git a/vdsm/mom.d/05-iotune.policy b/vdsm/mom.d/05-iotune.policy
index 3132986..b9d845c 100644
--- a/vdsm/mom.d/05-iotune.policy
+++ b/vdsm/mom.d/05-iotune.policy
@@ -30,7 +30,8 @@
 
 ### Main Script
 (if (== True ioTuneEnabled) {
-(with Guests guest (set_io_limits guest))
+(with Guests guest (if (valid guest.io_tune) (set_io_limits guest) 0))
 }{
-(with Guests guest (reset_io_limits guest))
-})
\ No newline at end of file
+(with Guests guest (if (valid guest.io_tune) (reset_io_limits guest) 0))
+})
+


-- 
To view, visit https://gerrit.ovirt.org/60525
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27162756b33441ab1962fca930a5459ff909fd81
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Sivák 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org