Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-29 Thread ybronhei
Yaniv Bronhaim has submitted this change and it was merged.

Change subject: spec: build rhev with hooks
..


spec: build rhev with hooks

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1321823
Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Signed-off-by: Dan Kenigsberg 
Signed-off-by: Yaniv Bronhaim 
Reviewed-on: https://gerrit.ovirt.org/55322
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Reviewed-by: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-29 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 4:

* #1321823::Update tracker: OK
* Set MODIFIED::bug 1321823#1321823IGNORE, not oVirt classification but 
Red Hat

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-29 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-29 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 3: Verified-1

* #1321823::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321823::OK, public bug
* Check Product::#1321823::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1321823::OK, correct target milestone ovirt-3.6.3
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-29 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-29 Thread fromani
Francesco Romani has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2:

indeed the process would require a bug per change _which affects production 
code_ or the final product.
While we could make an exception for this case, but this seems important enough 
to have a tracker bug.

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread eedri
Eyal Edri has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2:

I think its worth opening a bug on it to track the change.

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2:

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread eedri
Eyal Edri has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2:

Rerun-Hooks: patchset-created.bz.0.has_bug_url

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2:

can we remove the all condition ? any problem with having the hooks also in 
centos?

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55322/1/vdsm.spec.in
File vdsm.spec.in:

Line 18: 
Line 19: # RHEV build - overridable using rpmbuild --define "rhev_build 1"
Line 20: %{!?rhev_build: %global rhev_build 0}
Line 21: 
Line 22: %if 0%{fedora_koji_build} || 0 %{rhev_build}
> this is only in 3.6 which didn't get latest master backport in this area - 
In this case we like minimal change, so this looks good.
Line 23: %global with_hooks 1
Line 24: %endif
Line 25: 
Line 26: # Default to skipping autoreconf.  Distros can change just this one 
line


-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55322/1/vdsm.spec.in
File vdsm.spec.in:

Line 18: 
Line 19: # RHEV build - overridable using rpmbuild --define "rhev_build 1"
Line 20: %{!?rhev_build: %global rhev_build 0}
Line 21: 
Line 22: %if 0%{fedora_koji_build} || 0 %{rhev_build}
> The value of with_hooks should come from configure. If you want to build wi
this is only in 3.6 which didn't get latest master backport in this area - we 
need to face what we currently have and fix it as quick and short as possible 
imo. I don't want to touch configure in stable branch and in this code tree 
--enable-hooks does nothing.
Line 23: %global with_hooks 1
Line 24: %endif
Line 25: 
Line 26: # Default to skipping autoreconf.  Distros can change just this one 
line


-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread nsoffer
Nir Soffer has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55322/1/vdsm.spec.in
File vdsm.spec.in:

Line 18: 
Line 19: # RHEV build - overridable using rpmbuild --define "rhev_build 1"
Line 20: %{!?rhev_build: %global rhev_build 0}
Line 21: 
Line 22: %if 0%{fedora_koji_build} || 0 %{rhev_build}
> If we always want hooks just remove this condition ..
The value of with_hooks should come from configure. If you want to build with 
hooks, use ./configure --enable-hooks, and to build without hooks use 
./configure --disable-hooks.

We don't want this kind of logic in the spec.
Line 23: %global with_hooks 1
Line 24: %endif
Line 25: 
Line 26: # Default to skipping autoreconf.  Distros can change just this one 
line


-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2: Verified+1

But do we really want not to build the hooks in centos? I'd remove the condition

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-28 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 2: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55322/1/vdsm.spec.in
File vdsm.spec.in:

Line 18: 
Line 19: # RHEV build - overridable using rpmbuild --define "rhev_build 1"
Line 20: %{!?rhev_build: %global rhev_build 0}
Line 21: 
Line 22: %if 0%{fedora_koji_build} || 0 %{rhev_build}
If we always want hooks just remove this condition ..
btw edri - this was changed since b5bab3a9 which didn't get to 3.6.4
Line 23: %global with_hooks 1
Line 24: %endif
Line 25: 
Line 26: # Default to skipping autoreconf.  Distros can change just this one 
line


-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-27 Thread danken
Dan Kenigsberg has uploaded a new change for review.

Change subject: spec: build rhev with hooks
..

spec: build rhev with hooks

Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Signed-off-by: Dan Kenigsberg 
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/55322/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index b785ae3..7fc0020 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -19,7 +19,7 @@
 # RHEV build - overridable using rpmbuild --define "rhev_build 1"
 %{!?rhev_build: %global rhev_build 0}
 
-%if 0%{fedora_koji_build}
+%if 0%{fedora_koji_build} || 0 %{rhev_build}
 %global with_hooks 1
 %endif
 


-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches


Change in vdsm[ovirt-3.6]: spec: build rhev with hooks

2016-03-27 Thread automation
gerrit-hooks has posted comments on this change.

Change subject: spec: build rhev with hooks
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/55322
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I02deb713806ba3650ecc4dbe623a5fe2da10fa94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches