Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 5:

* #1284412::Update tracker: OK
* Set MODIFIED::bug 1284412#1284412OK

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread fromani 
Francesco Romani has submitted this change and it was merged.

Change subject: v2v: add try/except to get_external_vms
..


v2v: add try/except to get_external_vms

Single domain error causes get_external_vms to fail.

Bug-Url: https://bugzilla.redhat.com/1284412
Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Signed-off-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/49507
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Tested-by: Shahar Havivi 
Reviewed-on: https://gerrit.ovirt.org/49438
Reviewed-by: Milan Zamazal 
---
M vdsm/v2v.py
1 file changed, 12 insertions(+), 4 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 3: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread shavivi 
Shahar Havivi has restored this change.

Change subject: v2v: add try/except to get_external_vms
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

* #1284412::Update tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread shavivi 
Shahar Havivi has abandoned this change.

Change subject: v2v: add try/except to get_external_vms
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 3

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-13 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 4: -Verified

* #1284412::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284412::OK, public bug
* Check Product::#1284412::OK, Correct classification oVirt
* Check TM::#1284412::OK, correct target milestone ovirt-3.6.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-03 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2: Code-Review-1

I think the corresponding master patch is actually 
https://gerrit.ovirt.org/49507. Not yet merged, so let's update this one after 
the master patch is finished.

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-01 Thread shavivi 
Shahar Havivi has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

> do we have this patch in master already?
Yes, the fix is presented in this patch
https://gerrit.ovirt.org/#/c/48672/12/vdsm/v2v.py@663

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-01 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2: Code-Review-1

do we have this patch in master already?

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-11-30 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2:

* #1284412::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1284412::OK, public bug
* Check Product::#1284412::OK, Correct classification oVirt
* Check TM::#1284412::ERROR, wrong target milestone for stable branch, --- 
should match ^.*3.6.*
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-11-30 Thread shavivi 
Shahar Havivi has uploaded a new change for review.

Change subject: v2v: add try/except to get_external_vms
..

v2v: add try/except to get_external_vms

Single domain error causes get_external_vms to fail.

Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Signed-off-by: Shahar Havivi 
---
M vdsm/v2v.py
1 file changed, 20 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/49438/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index 63df7e2..3b4fb54 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -152,25 +152,28 @@
 vms = []
 for vm in conn.listAllDomains():
 params = {}
-_add_vm_info(vm, params)
 try:
-xml = vm.XMLDesc(0)
-except libvirt.libvirtError as e:
-logging.error("error getting domain xml for vm %r: %s",
-  vm.name(), e)
-continue
-root = ET.fromstring(xml)
-try:
-_add_general_info(root, params)
+_add_vm_info(vm, params)
+try:
+xml = vm.XMLDesc(0)
+except libvirt.libvirtError as e:
+logging.error("error getting domain xml for vm %r: %s",
+  vm.name(), e)
+continue
+root = ET.fromstring(xml)
+try:
+_add_general_info(root, params)
+except InvalidVMConfiguration as e:
+logging.error('error parsing domain xml, msg: %s  xml: %s',
+  e.message, vm.XMLDesc(0))
+continue
+_add_networks(root, params)
+_add_disks(root, params)
+for disk in params['disks']:
+_add_disk_info(conn, disk)
+vms.append(params)
 except InvalidVMConfiguration as e:
-logging.error('error parsing domain xml, msg: %s  xml: %s',
-  e.message, vm.XMLDesc(0))
-continue
-_add_networks(root, params)
-_add_disks(root, params)
-for disk in params['disks']:
-_add_disk_info(conn, disk)
-vms.append(params)
+logging.error('error parsing domain: %s', e)
 return {'status': doneCode, 'vmList': vms}
 
 


-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-11-30 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 1: Verified-1

* Update tracker: IGNORE, no Bug-Url found

* Check Bug-Url::ERROR, At least one bug-url is required for the stable branch
* Check merged to previous::WARN, Still missing on branches master

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-11-30 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: v2v: add try/except to get_external_vms
..


Patch Set 2: Continuous-Integration-1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/49438
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches