Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-26 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


net: edit nic detached from bridge but still attached to a vlan

Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1372798
Reviewed-on: https://gerrit.ovirt.org/65231
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
(cherry picked from commit 0970a9e90bc229d1fc95210153aacf564353516d)
Reviewed-on: https://gerrit.ovirt.org/65232
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1001177: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-26 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 6:

* update_tracker: OK
* Set MODIFIED::bug 1372798#1372798IGNORE, not all related patches are 
closed, check 65219

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-26 Thread gerrit2 
Anonymous Coward #1001177 has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-26 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-24 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 5:

* Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::IGNORE, not relevant for classification: Red Hat
* Check TM::#1372798::IGNORE, not relevant for classification: Red Hat
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-24 Thread phoracek 
Petr Horáček has restored this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Restored

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-24 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 2:

* Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-24 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 2: -Verified

* Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::IGNORE, not relevant for classification: Red Hat
* Check TM::#1372798::IGNORE, not relevant for classification: Red Hat
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-24 Thread phoracek 
Petr Horáček has abandoned this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Abandoned

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 1: Verified-1

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::IGNORE, not relevant for classification: Red Hat
* Check TM::#1372798::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::WARN, Still open on branches master

-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: net: edit nic detached from bridge but still attached to a vlan

2016-10-07 Thread phoracek 
Petr Horáček has uploaded a new change for review.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..

net: edit nic detached from bridge but still attached to a vlan

Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1372798
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/65232/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index f49693a..f04a7f3 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -281,6 +281,11 @@
 if set_mtu is not None:
 ipwrapper.linkSet(nic.name, ['mtu', str(set_mtu)])
 
+# If the nic was bridged, we must remove BRIDGE parameter from its
+# ifcfg configuration file.
+if nic.bridge:
+self.configApplier.dropBridgeParameter(nic.name)
+
 def _getFilePath(self, fileType, device):
 return os.path.join(NET_CONF_DIR, '%s-%s' % (fileType, device))
 


-- 
To view, visit https://gerrit.ovirt.org/65232
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org