Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 2:

* #1339780::Update tracker: OK
* Set MODIFIED::bug 1339780#1339780OK

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1: Continuous-Integration+1

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


spec: Require python-ioprocess-0.16.1-1

ioprocess-0.16.1-1 solves a bug where ioprocess keeps a file open
after truncating or touching it (see the Related-To bug).

Vdsm requires ioprocess via the noarch package python-ioprocess, and
this patch bumps the requirement to include a fix for the
aforementioned issue.

Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Related-To: https://bugzilla.redhat.com/1339777
Bug-Url: https://bugzilla.redhat.com/1339780
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/60858
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/60860
Reviewed-by: Francesco Romani 
Continuous-Integration: Francesco Romani 
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Allon Mureinik: Verified
  Francesco Romani: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1: Code-Review+2

it is in the ovirt-4.0 repos.

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1: Code-Review+1

need to check that ioprocess 0.16.1-1 is available, will merge once it is.

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1: Verified+1

Marking as VERIFIED as it passes when I build/test this locally and the CI 
failure is fixed by different patch as Nir pointed out.

Yaniv/Francesco, can we move forwards with this please?

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1: Code-Review+1

This is known issue in 4.0, fixed in https://gerrit.ovirt.org/60847.

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1:

While the failure is consistent, it doesn't seem to be related to the patch. 
Instead 


14:13:07 == Running the shellscript automation/check-patch.sh
14:13:07 + easy_install pip
14:13:07 ./automation/check-patch.sh: line 7: easy_install: command not found
14:13:07 Took 0 seconds
14:13:07 ===
14:13:07 ##!
14:13:07 ##! ERROR ^^
14:13:07 ##!
14:13:07 ##

Nir/Sandro, could you advise?

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1:

CI failure doesn't seem to be related to the patch. Attempting to retrigger.

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1:

* #1339780::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1339780::OK, public bug
* Check Product::#1339780::OK, Correct classification oVirt
* Check TM::#1339780::OK, correct target milestone ovirt-4.0.2
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..


Patch Set 1:

Same patch as master, pending CI to mark as verified.

-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: spec: Require python-ioprocess-0.16.1-1

[amureini]

Hello Nir Soffer,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/60860

to review the following change.

Change subject: spec: Require python-ioprocess-0.16.1-1
..

spec: Require python-ioprocess-0.16.1-1

ioprocess-0.16.1-1 solves a bug where ioprocess keeps a file open
after truncating or touching it (see the Related-To bug).

Vdsm requires ioprocess via the noarch package python-ioprocess, and
this patch bumps the requirement to include a fix for the
aforementioned issue.

Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Related-To: https://bugzilla.redhat.com/1339777
Bug-Url: https://bugzilla.redhat.com/1339780
Signed-off-by: Allon Mureinik 
Reviewed-on: https://gerrit.ovirt.org/60858
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/60860/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 94a1a67..883de27 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -78,7 +78,7 @@
 BuildRequires: PyYAML
 BuildRequires: python-cpopen >= 1.4
 BuildRequires: python-inotify
-BuildRequires: python-ioprocess >= 0.15.0-4
+BuildRequires: python-ioprocess >= 0.16.1-1
 BuildRequires: python-pthreading
 BuildRequires: qemu-img
 BuildRequires: rpm-python
@@ -145,7 +145,7 @@
 Requires: python-inotify
 Requires: python-argparse
 Requires: python-cpopen >= 1.4
-Requires: python-ioprocess >= 0.15.0-4
+Requires: python-ioprocess >= 0.16.1-1
 Requires: python-pthreading >= 0.1.3-3
 Requires: python-six >= 1.9.0
 Requires: python-requests
@@ -355,7 +355,7 @@
 Requires:   %{name}-infra = %{version}-%{release}
 Requires:   python-cpopen >= 1.4
 Requires:   m2crypto
-Requires:   python-ioprocess >= 0.15.0-4
+Requires:   python-ioprocess >= 0.16.1-1
 
 %description python
 Shared libraries between the various VDSM packages.


-- 
To view, visit https://gerrit.ovirt.org/60860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib93b5649981ef423f88d354334bd7d3364f52a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org