Re: [Viking-devel] 1.6.2 buglets

2016-11-03 Thread Robert Norris 

I can just fix it.


NB $RANDOM is more autoconf rather than automake.


--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.

From: Greg Troxel <g...@lexort.com>
Sent: 03 November 2016 12:57:32
To: Robert Norris
Cc: viking-devel@lists.sourceforge.net
Subject: Re: [Viking-devel] 1.6.2 buglets


Robert Norris <rw_nor...@hotmail.com> writes:

> Good spot on the '==' issue.

Do you need a proper patch to configure.in, or is it easier for you to
just fix it.

> However the $RANDOM issue as far as I can tell is created by one of
> the 'random' autotools components, not in Viking itself. On my system
> (Automake version 1.15) it seems to be in aclocal.m4 which then gets
> included in the final configure script.

I see - I can see about that, and perhaps file a bug with them, and
until then just patch it out in pkgrsc.

> IIRC the configure script is only copied into the .tar.gz file and not
> part of the actual (git) source code repository.

True.  aclocal writes aclocal.m4 from various files installed by other
programs, parts of which are then included in configure.

(I've been distracted by non-geo things and am trying to page various
projects back in.)
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

Re: [Viking-devel] 1.6.2 buglets

2016-11-03 Thread Robert Norris 
Good spot on the '==' issue.


However the $RANDOM issue as far as I can tell is created by one of the 
'random' autotools components, not in Viking itself. On my system (Automake 
version 1.15) it seems to be in aclocal.m4 which then gets included in the 
final configure script.


IIRC the configure script is only copied into the .tar.gz file and not part of 
the actual (git) source code repository.


--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.

From: Greg Troxel <g...@lexort.com>
Sent: 02 November 2016 23:57:10
To: viking-devel@lists.sourceforge.net
Subject: [Viking-devel] 1.6.2 buglets


I know I should make separate commits and push a branch, but I have the
following in pkgsrc.  The issues are the use of $RANDOM and ==, both of
which are outside of POSIX's sh specification and hence unportable.  ==
is easy; it should just be = and there is no downside.  RANDOM may be
harder, but I don't see a lot of configure collisions and it seems $$
(pid) or mkstemp is the sticking-to-posix way.

$NetBSD$

--- configure.orig  2015-11-24 22:18:34.0 +
+++ configure
@@ -8585,7 +8585,7 @@ INTLTOOL_SOUNDLIST_RULE='%.soundlist: %.
 if test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge 5000; then
   INTLTOOL_XML_NOMERGE_RULE='%.xml:   %.xml.in   $(INTLTOOL_MERGE) 
; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x 
-u --no-translations $< $@'
 else
-  INTLTOOL_XML_NOMERGE_RULE='%.xml:   %.xml.in   $(INTLTOOL_MERGE) 
; $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.$$RANDOM && mkdir $$_it_tmp_dir 
&& LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u $$_it_tmp_dir 
$< $@ && rmdir $$_it_tmp_dir'
+  INTLTOOL_XML_NOMERGE_RULE='%.xml:   %.xml.in   $(INTLTOOL_MERGE) 
; $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.not-random && mkdir $$_it_tmp_dir 
&& LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u $$_it_tmp_dir 
$< $@ && rmdir $$_it_tmp_dir'
 fi
   INTLTOOL_XAM_RULE='%.xam:   %.xml.in   $(INTLTOOL_MERGE) 
$(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C 
$(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c 
$(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@'
   INTLTOOL_KBD_RULE='%.kbd:   %.kbd.in   $(INTLTOOL_MERGE) 
$(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C 
$(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -m -c 
$(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@'
@@ -12428,7 +12428,7 @@ $as_echo "no" >&6; }
 fi


- if test "x$XP" != "x" && test -r "$DB2MAN_XSL" && test "${HAVE_SCROLLKEEPER}" 
== "yes" ; then
+ if test "x$XP" != "x" && test -r "$DB2MAN_XSL" && test "${HAVE_SCROLLKEEPER}" 
= "yes" ; then
   GEN_MANPAGES_TRUE=
   GEN_MANPAGES_FALSE='#'
 else

--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/

[Viking-devel] 1.6.2 buglets

2016-11-02 Thread Greg Troxel 

I know I should make separate commits and push a branch, but I have the
following in pkgsrc.  The issues are the use of $RANDOM and ==, both of
which are outside of POSIX's sh specification and hence unportable.  ==
is easy; it should just be = and there is no downside.  RANDOM may be
harder, but I don't see a lot of configure collisions and it seems $$
(pid) or mkstemp is the sticking-to-posix way.

$NetBSD$

--- configure.orig  2015-11-24 22:18:34.0 +
+++ configure
@@ -8585,7 +8585,7 @@ INTLTOOL_SOUNDLIST_RULE='%.soundlist: %.
 if test "$INTLTOOL_APPLIED_VERSION_AS_INT" -ge 5000; then
   INTLTOOL_XML_NOMERGE_RULE='%.xml:   %.xml.in   $(INTLTOOL_MERGE) 
; $(INTLTOOL_V_MERGE)LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x 
-u --no-translations $< $@'
 else
-  INTLTOOL_XML_NOMERGE_RULE='%.xml:   %.xml.in   $(INTLTOOL_MERGE) 
; $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.$$RANDOM && mkdir $$_it_tmp_dir 
&& LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u $$_it_tmp_dir 
$< $@ && rmdir $$_it_tmp_dir'
+  INTLTOOL_XML_NOMERGE_RULE='%.xml:   %.xml.in   $(INTLTOOL_MERGE) 
; $(INTLTOOL_V_MERGE)_it_tmp_dir=tmp.intltool.not-random && mkdir $$_it_tmp_dir 
&& LC_ALL=C $(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u $$_it_tmp_dir 
$< $@ && rmdir $$_it_tmp_dir'
 fi
   INTLTOOL_XAM_RULE='%.xam:   %.xml.in   $(INTLTOOL_MERGE) 
$(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C 
$(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -c 
$(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@'
   INTLTOOL_KBD_RULE='%.kbd:   %.kbd.in   $(INTLTOOL_MERGE) 
$(wildcard $(top_srcdir)/po/*.po) ; $(INTLTOOL_V_MERGE)LC_ALL=C 
$(INTLTOOL_MERGE) $(INTLTOOL_V_MERGE_OPTIONS) -x -u -m -c 
$(top_builddir)/po/.intltool-merge-cache $(top_srcdir)/po $< $@'
@@ -12428,7 +12428,7 @@ $as_echo "no" >&6; }
 fi
 
 
- if test "x$XP" != "x" && test -r "$DB2MAN_XSL" && test "${HAVE_SCROLLKEEPER}" 
== "yes" ; then
+ if test "x$XP" != "x" && test -r "$DB2MAN_XSL" && test "${HAVE_SCROLLKEEPER}" 
= "yes" ; then
   GEN_MANPAGES_TRUE=
   GEN_MANPAGES_FALSE='#'
 else



signature.asc
Description: PGP signature
--
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi___
Viking-devel mailing list
Viking-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/viking-devel
Viking home page: http://viking.sf.net/