Re: Trigger OptionSet autocommand on entering diff mode

2017-07-07 Fir de Conversatie Christian Brabandt

On Fr, 07 Jul 2017, Bram Moolenaar wrote:

> Did you check that something nasty in the autocommand, such as closing
> the buffer, doesn't cause trouble?

This version does, by setting curbuf_locked. That makes at least my 
initial test:
au OptionSet diff :close
not fail (and still enters diff mode). (previously it would segfault.)

Best,
Christian
-- 
Traue den Menschen doch etwas mehr, sie sind wohl manchmal besser als
wir meinen.
-- S. Gontard

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
From d48757a29f46c3b1798747d7a5023491516aca8e Mon Sep 17 00:00:00 2001
From: Christian Brabandt 
Date: Fri, 7 Jul 2017 16:24:26 +0200
Subject: [PATCH] Trigger OptionSet on entering diffmode

Until now, when entering diff mode, the OptionSet autocommand was not
triggered, because internally, only the wp->w_p_diff flag was set and
the option was not really set. Therefore, call set_option_value() which
will trigger OptionSet autocommands.

This allows the user to have specific option triggered on entering diff
mode. (see e.g. https://vi.stackexchange.com/q/12847). Add a test to
verify the behaviour

Also convert the old style test test_autocmd_option.in to a new style test.
---
 runtime/doc/usr_41.txt |   1 +
 src/diff.c |  19 +++-
 src/testdir/Make_all.mak   |   1 -
 src/testdir/test_autocmd.vim   | 208 +++--
 src/testdir/test_autocmd_option.in |  77 --
 src/testdir/test_autocmd_option.ok |  64 
 6 files changed, 216 insertions(+), 154 deletions(-)
 delete mode 100644 src/testdir/test_autocmd_option.in
 delete mode 100644 src/testdir/test_autocmd_option.ok

diff --git a/runtime/doc/usr_41.txt b/runtime/doc/usr_41.txt
index d675c5e0b..069a719af 100644
--- a/runtime/doc/usr_41.txt
+++ b/runtime/doc/usr_41.txt
@@ -933,6 +933,7 @@ Testing:*test-functions*
 	test_null_list()	return a null List
 	test_null_partial()	return a null Partial function
 	test_null_string()	return a null String
+	test_override()		set an internal Vim flag for testing
 	test_settime()		set the time Vim uses internally
 
 Inter-process communication:		*channel-functions*
diff --git a/src/diff.c b/src/diff.c
index dfc968f83..4147a7a04 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -1198,10 +1198,16 @@ diff_win_options(
 if (vim_strchr(p_sbo, 'h') == NULL)
 	do_cmdline_cmd((char_u *)"set sbo+=hor");
 #endif
-/* Saved the current values, to be restored in ex_diffoff(). */
+/* Save the current values, to be restored in ex_diffoff(). */
 wp->w_p_diff_saved = TRUE;
 
-wp->w_p_diff = TRUE;
+curwin = wp;
+curbuf = curwin->w_buffer;
+++curbuf_lock;
+set_option_value((char_u *)"diff", 1L, NULL, OPT_LOCAL);
+--curbuf_lock;
+curwin = old_curwin;
+curbuf = curwin->w_buffer;
 
 if (addbuf)
 	diff_buf_add(wp->w_buffer);
@@ -1219,6 +1225,7 @@ ex_diffoff(exarg_T *eap)
 #ifdef FEAT_SCROLLBIND
 int		diffwin = FALSE;
 #endif
+win_T *old_curwin = curwin;
 
 FOR_ALL_WINDOWS(wp)
 {
@@ -1227,7 +1234,13 @@ ex_diffoff(exarg_T *eap)
 	/* Set 'diff' off. If option values were saved in
 	 * diff_win_options(), restore the ones whose settings seem to have
 	 * been left over from diff mode.  */
-	wp->w_p_diff = FALSE;
+	curwin = wp;
+	curbuf = curwin->w_buffer;
+	++curbuf_lock;
+	set_option_value((char_u *)"diff", 0L, NULL, OPT_LOCAL);
+	--curbuf_lock;
+	curwin = old_curwin;
+	curbuf = curwin->w_buffer;
 
 	if (wp->w_p_diff_saved)
 	{
diff --git a/src/testdir/Make_all.mak b/src/testdir/Make_all.mak
index 9a3cafd37..defb707dd 100644
--- a/src/testdir/Make_all.mak
+++ b/src/testdir/Make_all.mak
@@ -71,7 +71,6 @@ SCRIPTS_ALL = \
 	test104.out \
 	test107.out \
 	test108.out \
-	test_autocmd_option.out \
 	test_autoformat_join.out \
 	test_changelist.out \
 	test_close_count.out \
diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim
index ef280340c..62a6e5e9f 100644
--- a/src/testdir/test_autocmd.vim
+++ b/src/testdir/test_autocmd.vim
@@ -2,13 +2,13 @@
 
 set belloff=all
 
-function! s:cleanup_buffers() abort
+func! s:cleanup_buffers() abort
   for bnr in range(1, bufnr('$'))
 if bufloaded(bnr) && bufnr('%') != bnr
   execute 'bd! ' . bnr
 endif
   endfor
-endfunction
+endfunc
 
 func Test_vim_did_enter()
   call assert_false(v:vim_did_enter)
@@ -49,7 +49,7 @@ if has('timers')
   endfunc
 endif
 
-function Test_bufunload()
+func Test_bufunload()
   augroup 

Re: Trigger OptionSet autocommand on entering diff mode

2017-07-07 Fir de Conversatie Bram Moolenaar

Christian Brabandt wrote:

> Bram,
> currently, when entering diff mode, the OptionSet autocommand is not 
> called.
> 
> The attached patch changes that, so that a user can set specific options 
> only for diffmode.
> 
> Also the oldstyle test was converted to a new style test (and a small 
> bug in the oldstyle test was fixed).
> 
> Please see also the commit description in the attached patch for more 
> information.
> 
> And while I was writing the test, I noticed that test_override() was 
> missing from usr_41.txt, so I added it there as well.

Thanks.

Did you check that something nasty in the autocommand, such as closing
the buffer, doesn't cause trouble?

-- 
I have a watch cat! Just break in and she'll watch.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Trigger OptionSet autocommand on entering diff mode

2017-07-07 Fir de Conversatie Christian Brabandt
Bram,
currently, when entering diff mode, the OptionSet autocommand is not 
called.

The attached patch changes that, so that a user can set specific options 
only for diffmode.

Also the oldstyle test was converted to a new style test (and a small 
bug in the oldstyle test was fixed).

Please see also the commit description in the attached patch for more 
information.

And while I was writing the test, I noticed that test_override() was 
missing from usr_41.txt, so I added it there as well.

Best,
Christian

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
From 99e2791a8ad702047bbc0778494df32e54aa93f6 Mon Sep 17 00:00:00 2001
From: Christian Brabandt 
Date: Fri, 7 Jul 2017 16:24:26 +0200
Subject: [PATCH] Trigger OptionSet on entering diffmode

Until now, when entering diff mode, the OptionSet autocommand was not
triggered, because internally, only the wp->w_p_diff flag was set and
the option was not really set. Therefore, call set_option_value() which
will trigger OptionSet autocommands.

This allows the user to have specific option triggered on entering diff
mode. (see e.g. https://vi.stackexchange.com/q/12847). Add a test to
verify the behaviour

Also convert the old style test test_autocmd_option.in to a new style test.
---
 runtime/doc/usr_41.txt |   1 +
 src/diff.c |  15 ++-
 src/testdir/Make_all.mak   |   1 -
 src/testdir/test_autocmd.vim   | 185 +++--
 src/testdir/test_autocmd_option.in |  77 ---
 src/testdir/test_autocmd_option.ok |  64 -
 6 files changed, 189 insertions(+), 154 deletions(-)
 delete mode 100644 src/testdir/test_autocmd_option.in
 delete mode 100644 src/testdir/test_autocmd_option.ok

diff --git a/runtime/doc/usr_41.txt b/runtime/doc/usr_41.txt
index d675c5e0b..069a719af 100644
--- a/runtime/doc/usr_41.txt
+++ b/runtime/doc/usr_41.txt
@@ -933,6 +933,7 @@ Testing:*test-functions*
 	test_null_list()	return a null List
 	test_null_partial()	return a null Partial function
 	test_null_string()	return a null String
+	test_override()		set an internal Vim flag for testing
 	test_settime()		set the time Vim uses internally
 
 Inter-process communication:		*channel-functions*
diff --git a/src/diff.c b/src/diff.c
index dfc968f83..29887b093 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -1198,10 +1198,14 @@ diff_win_options(
 if (vim_strchr(p_sbo, 'h') == NULL)
 	do_cmdline_cmd((char_u *)"set sbo+=hor");
 #endif
-/* Saved the current values, to be restored in ex_diffoff(). */
+/* Save the current values, to be restored in ex_diffoff(). */
 wp->w_p_diff_saved = TRUE;
 
-wp->w_p_diff = TRUE;
+curwin = wp;
+curbuf = curwin->w_buffer;
+set_option_value((char_u *)"diff", 1L, NULL, OPT_LOCAL);
+curwin = old_curwin;
+curbuf = curwin->w_buffer;
 
 if (addbuf)
 	diff_buf_add(wp->w_buffer);
@@ -1219,6 +1223,7 @@ ex_diffoff(exarg_T *eap)
 #ifdef FEAT_SCROLLBIND
 int		diffwin = FALSE;
 #endif
+win_T *old_curwin = curwin;
 
 FOR_ALL_WINDOWS(wp)
 {
@@ -1227,7 +1232,11 @@ ex_diffoff(exarg_T *eap)
 	/* Set 'diff' off. If option values were saved in
 	 * diff_win_options(), restore the ones whose settings seem to have
 	 * been left over from diff mode.  */
-	wp->w_p_diff = FALSE;
+	curwin = wp;
+	curbuf = curwin->w_buffer;
+	set_option_value((char_u *)"diff", 0L, NULL, OPT_LOCAL);
+	curwin = old_curwin;
+	curbuf = curwin->w_buffer;
 
 	if (wp->w_p_diff_saved)
 	{
diff --git a/src/testdir/Make_all.mak b/src/testdir/Make_all.mak
index 9a3cafd37..defb707dd 100644
--- a/src/testdir/Make_all.mak
+++ b/src/testdir/Make_all.mak
@@ -71,7 +71,6 @@ SCRIPTS_ALL = \
 	test104.out \
 	test107.out \
 	test108.out \
-	test_autocmd_option.out \
 	test_autoformat_join.out \
 	test_changelist.out \
 	test_close_count.out \
diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim
index ef280340c..371b81175 100644
--- a/src/testdir/test_autocmd.vim
+++ b/src/testdir/test_autocmd.vim
@@ -2,13 +2,13 @@
 
 set belloff=all
 
-function! s:cleanup_buffers() abort
+func! s:cleanup_buffers() abort
   for bnr in range(1, bufnr('$'))
 if bufloaded(bnr) && bufnr('%') != bnr
   execute 'bd! ' . bnr
 endif
   endfor
-endfunction
+endfunc
 
 func Test_vim_did_enter()
   call assert_false(v:vim_did_enter)
@@ -49,7 +49,7 @@ if has('timers')
   endfunc
 endif
 
-function Test_bufunload()
+func Test_bufunload()
   augroup test_bufunload_group
 autocmd!
 autocmd 

Re: Inconsistent help for the new terminal feature

2017-07-07 Fir de Conversatie Bram Moolenaar

Tony Mechelynck wrote:

> After setting $CONF_OPT_TERMINAL to '--enable-terminal' then running
> "make reconfig" followed by "make install" I notice the following in
> gvim:
> 
> - Help tags are not defined yet for 'termkey' 'termsize'
> term_getsize() and term_setsize()
> 
> - The output of
> :echo exists('+termkey') exists('+termsize')
> exists('*term_getsize') exists('*term_setsize')
> is
> 0 1 0 0

There is a long list of todo items in src/terminal.c

-- 
hundred-and-one symptoms of being an internet addict:
124. You begin conversations with, "Who is your internet service provider?"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0693

2017-07-07 Fir de Conversatie Bram Moolenaar

James McCoy wrote:

> On Fri, Jul 07, 2017 at 11:54:43AM +0200, Bram Moolenaar wrote:
> > 
> > Patch 8.0.0693
> > Problem:No terminal emulator support.  Cannot properly run commands in 
> > the
> > GUI.  Cannot run a job interactively with an ssh connection.
> > Solution:   Very early implementation of the :terminal command.  Includes
> > libvterm converted to ANSI C.  Many parts still missing.
> 
> Why did you choose to bundle libvterm instead of building against the
> system library as is done with all other dependencies?

The library is not widely available.  And some changes will be required.
So far only conversion from C99 to C90.

Paul evans said he will probably include my changes, but it will lag
behind.  If eventually the distributed libvterm catches up and is
available in enough places, we can go back to including that.

-- 
hundred-and-one symptoms of being an internet addict:
122. You ask if the Netaholics Anonymous t-shirt you ordered can be
 sent to you via e-mail.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 8.0.0698

2017-07-07 Fir de Conversatie Bram Moolenaar

Patch 8.0.0698
Problem:When a timer uses ":pyeval" or another Python command and it
happens to be triggered while exiting a Crash may happen.
(Ricky Zhou)
Solution:   Avoid running a Python command after python_end() was called.
Do not trigger timers while exiting.  (closes #1824)
Files:  src/if_python.c, src/if_python3.c, src/ex_cmds2.c


*** ../vim-8.0.0697/src/if_python.c 2017-01-28 15:58:45.348197250 +0100
--- src/if_python.c 2017-07-07 14:38:58.636443739 +0200
***
*** 779,784 
--- 779,785 
  
  static int initialised = 0;
  #define PYINITIALISED initialised
+ static int python_end_called = FALSE;
  
  #define DESTRUCTOR_FINISH(self) self->ob_type->tp_free((PyObject*)self);
  
***
*** 878,883 
--- 879,885 
  if (recurse != 0)
return;
  
+ python_end_called = TRUE;
  ++recurse;
  
  #ifdef DYNAMIC_PYTHON
***
*** 1040,1045 
--- 1042,1049 
  }
  ++recursive;
  #endif
+ if (python_end_called)
+   return;
  
  #if defined(MACOS) && !defined(MACOS_X_UNIX)
  GetPort();
***
*** 1568,1574 
(rangeinitializer) init_range_eval,
(runner) run_eval,
(void *) rettv);
! switch(rettv->v_type)
  {
case VAR_DICT: ++rettv->vval.v_dict->dv_refcount; break;
case VAR_LIST: ++rettv->vval.v_list->lv_refcount; break;
--- 1572,1578 
(rangeinitializer) init_range_eval,
(runner) run_eval,
(void *) rettv);
! switch (rettv->v_type)
  {
case VAR_DICT: ++rettv->vval.v_dict->dv_refcount; break;
case VAR_LIST: ++rettv->vval.v_list->lv_refcount; break;
*** ../vim-8.0.0697/src/if_python3.c2017-01-28 15:58:45.348197250 +0100
--- src/if_python3.c2017-07-07 14:46:21.049114965 +0200
***
*** 733,740 
  #endif /* DYNAMIC_PYTHON3 */
  
  static int py3initialised = 0;
- 
  #define PYINITIALISED py3initialised
  
  #define DESTRUCTOR_FINISH(self) Py_TYPE(self)->tp_free((PyObject*)self)
  
--- 733,740 
  #endif /* DYNAMIC_PYTHON3 */
  
  static int py3initialised = 0;
  #define PYINITIALISED py3initialised
+ static int python_end_called = FALSE;
  
  #define DESTRUCTOR_FINISH(self) Py_TYPE(self)->tp_free((PyObject*)self)
  
***
*** 817,822 
--- 817,823 
  if (recurse != 0)
return;
  
+ python_end_called = TRUE;
  ++recurse;
  
  #ifdef DYNAMIC_PYTHON3
***
*** 938,943 
--- 939,947 
  PyObject  *cmdbytes;
  PyGILState_STATE  pygilstate;
  
+ if (python_end_called)
+   goto theend;
+ 
  #if defined(MACOS) && !defined(MACOS_X_UNIX)
  GetPort();
  /* Check if the Python library is available */
*** ../vim-8.0.0697/src/ex_cmds2.c  2017-06-27 14:43:51.203020467 +0200
--- src/ex_cmds2.c  2017-07-07 14:45:32.265482186 +0200
***
*** 1183,1188 
--- 1183,1189 
  /*
   * Call timers that are due.
   * Return the time in msec until the next timer is due.
+  * Returns -1 if there are no pending timers.
   */
  long
  check_due_timer(void)
***
*** 1197,1202 
--- 1198,1207 
  # ifdef WIN3264
  LARGE_INTEGER   fr;
  
+ /* Don't run any timers while exiting. */
+ if (exiting)
+   return next_due;
+ 
  QueryPerformanceFrequency();
  # endif
  profile_start();
*** ../vim-8.0.0697/src/version.c   2017-07-07 13:32:10.866905242 +0200
--- src/version.c   2017-07-07 14:44:58.941733011 +0200
***
*** 766,767 
--- 766,769 
  {   /* Add new patch number below this line */
+ /**/
+ 698,
  /**/

-- 
Would you care for a drink?   I mean, if it were, like,
disabled and you had to look after it?

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Inconsistent help for the new terminal feature

2017-07-07 Fir de Conversatie Tony Mechelynck
After setting $CONF_OPT_TERMINAL to '--enable-terminal' then running
"make reconfig" followed by "make install" I notice the following in
gvim:

- Help tags are not defined yet for 'termkey' 'termsize'
term_getsize() and term_setsize()

- The output of
:echo exists('+termkey') exists('+termsize')
exists('*term_getsize') exists('*term_setsize')
is
0 1 0 0


Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Off-by-one error for 'cmdheight' after patches 8.0.693 to 695

2017-07-07 Fir de Conversatie Tony Mechelynck
On Fri, Jul 7, 2017 at 1:53 PM, Christian Brabandt  wrote:
>
> On Fr, 07 Jul 2017, Tony Mechelynck wrote:
>
>> On Fri, Jul 7, 2017 at 1:41 PM, Christian Brabandt  
>> wrote:
>> > Is there an easy way to reproduce this issue?
>> >
>> Meaning you can't reproduce it by just running gvim? I don't know.
>> I'll try restarting gvim and see if the problem goes away.
>
> Well, if I recall correctly, you have mentioned that problem in the
> past. I just looked at it again and couldn't reproduce it and therefore,
> I wondered if it might be related to your session file?
>
> Best,
> Christian

My session file is handwritten, not created by :mksession, and it
rarely changes. FWIW, here it is. Most of the editfiles are local, and
the session doesn't change much:

" Vim session file
" This one was not generated by :mksession.

e ~/.mozilla/seamonkey/eiox68r9.default/user.js
lcd %:h
new chrome/userChrome.css
new chrome/userContent.css
lcd %:h
new $VIM/vimfiles/keymap/russian-phonetic_utf-8.vim
cd ~
new pub/slovarj/ru-fr.css
setl keymap=russian-phonetic imi=0
lcd %:h
new ru-fr.abbrev.html
setl imi=0
new ru-fr.12.html
split
new ~/Session.vim
lcd ~
bot h
" lcd ~
if exists('+switchbuf')
 set swb=useopen
 sb ~/pub/slovarj/ru-fr.abbrev.html
 wincmd w
else
 wincmd W
 wincmd W
 wincmd W
endif
normal N

Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0693

2017-07-07 Fir de Conversatie Christian Brabandt

On Fr, 07 Jul 2017, James McCoy wrote:

> On Fri, Jul 07, 2017 at 11:54:43AM +0200, Bram Moolenaar wrote:
> > 
> > Patch 8.0.0693
> > Problem:No terminal emulator support.  Cannot properly run commands in 
> > the
> > GUI.  Cannot run a job interactively with an ssh connection.
> > Solution:   Very early implementation of the :terminal command.  Includes
> > libvterm converted to ANSI C.  Many parts still missing.
> 
> Why did you choose to bundle libvterm instead of building against the
> system library as is done with all other dependencies?

Probably because it has been changed?

Best,
Christian
-- 
Viele Menschen halten ihre Phantasie für ihr Gedächtnis.
-- Josh Billings (eigentlich: Henry Wheeler Shaw)

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0693

2017-07-07 Fir de Conversatie James McCoy
On Fri, Jul 07, 2017 at 11:54:43AM +0200, Bram Moolenaar wrote:
> 
> Patch 8.0.0693
> Problem:No terminal emulator support.  Cannot properly run commands in the
> GUI.  Cannot run a job interactively with an ssh connection.
> Solution:   Very early implementation of the :terminal command.  Includes
> libvterm converted to ANSI C.  Many parts still missing.

Why did you choose to bundle libvterm instead of building against the
system library as is done with all other dependencies?

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Off-by-one error for 'cmdheight' after patches 8.0.693 to 695

2017-07-07 Fir de Conversatie Christian Brabandt

On Fr, 07 Jul 2017, Tony Mechelynck wrote:

> On Fri, Jul 7, 2017 at 1:41 PM, Christian Brabandt  wrote:
> > Is there an easy way to reproduce this issue?
> >
> Meaning you can't reproduce it by just running gvim? I don't know.
> I'll try restarting gvim and see if the problem goes away.

Well, if I recall correctly, you have mentioned that problem in the 
past. I just looked at it again and couldn't reproduce it and therefore, 
I wondered if it might be related to your session file?

Best,
Christian
-- 
Wenn ein gutes Wort eine gute Statt findet, so findet ein 
frommes Wort gewiss noch eine bessere.
-- Goethe, Maximen und Reflektionen, Nr. 631

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Off-by-one error for 'cmdheight' after patches 8.0.693 to 695

2017-07-07 Fir de Conversatie Tony Mechelynck
On Fri, Jul 7, 2017 at 1:48 PM, Tony Mechelynck
 wrote:
> On Fri, Jul 7, 2017 at 1:41 PM, Christian Brabandt  wrote:
>> Is there an easy way to reproduce this issue?
>>
>> Best,
>> Christian
>
> Meaning you can't reproduce it by just running gvim? I don't know.
> I'll try restarting gvim and see if the problem goes away.

Well it did go away. No idea what might have caused it.
>
> Oh, and BTW there are no helptags yet for 'termkey' 'termsize'
> term_getsize() and term_setsize()
>
>
> Best regards,
> Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Off-by-one error for 'cmdheight' after patches 8.0.693 to 695

2017-07-07 Fir de Conversatie Tony Mechelynck
On Fri, Jul 7, 2017 at 1:41 PM, Christian Brabandt  wrote:
> Is there an easy way to reproduce this issue?
>
> Best,
> Christian

Meaning you can't reproduce it by just running gvim? I don't know.
I'll try restarting gvim and see if the problem goes away.

Oh, and BTW there are no helptags yet for 'termkey' 'termsize'
term_getsize() and term_setsize()


Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Off-by-one error for 'cmdheight' after patches 8.0.693 to 695

2017-07-07 Fir de Conversatie Christian Brabandt

On Fr, 07 Jul 2017, Tony Mechelynck wrote:

> After manually adding symlinks in my shadow directories for
> ../libvterm and ../terminal.c I could successfully compile a Tiny and
> a Huge build. No change in configure settings, which for the Huge
> build are set as follows before running make:
> 
> export CONF_OPT_GUI='--enable-gui=gtk3 --enable-gnome-check'
> export CONF_OPT_PERL='--enable-perlinterp'
> export CONF_OPT_PYTHON='--enable-pythoninterp'
> export CONF_OPT_PYTHON3='--disable-python3interp'
> export CONF_OPT_TCL='--enable-tclinterp'
> # /usr/bin/tclsh (softlink) is correctly set
> export CONF_OPT_RUBY='--enable-rubyinterp'
> export CONF_OPT_LUA='--enable-luainterp'
> export CONF_OPT_MZSCHEME='--disable-mzschemeinterp'
> #export CONF_OPT_PLTHOME='--with-plthome=/usr/local/plt'
> export CONF_OPT_CSCOPE='--enable-cscope'
> export CONF_OPT_MULTIBYTE='--enable-multibyte'
> export CONF_OPT_FEAT='--with-features=huge'
> export CONF_OPT_COMPBY='"--with-compiledby=antoine.mechely...@gmail.com"'
> 
> Then after running "make install" I start this Huge build as gvim with
> my usual session file. 'cmdheight' is set to 2 but the command-line
> height is only 1 line. After ":set ch+=1" the option is set to 3 but I
> see only 2 lines of command-line space.

Is there an easy way to reproduce this issue?

Best,
Christian
-- 
Ungeduld hat häufig Schuld.
-- Wilhelm Busch

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0695

2017-07-07 Fir de Conversatie Bram Moolenaar

Kazunobu Kuriyama wrote:

> 2017-07-07 20:06 GMT+09:00 skywind3000 :
> 
> > "E319: Sorry, the command is not available in this version"
> >
> 
> Probably, you forgot to add --enable-terminal when you run the configure
> script, didn't you?

It's not really doing anything yet...

-- 
hundred-and-one symptoms of being an internet addict:
121. You ask for e-mail adresses instead of telephone numbers.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 8.0.0697

2017-07-07 Fir de Conversatie Bram Moolenaar

Patch 8.0.0697
Problem:Recorded key sequences may become invalid.
Solution:   Add back KE_SNIFF removed in 7.4.1433. Use fixed numbers for the
key_extra enum.
Files:  src/keymap.h


*** ../vim-8.0.0696/src/keymap.h2017-06-22 22:37:53.588267735 +0200
--- src/keymap.h2017-07-07 12:54:02.952289452 +0200
***
*** 112,118 
  
  /* Used for the sgr mouse. */
  #define KS_SGR_MOUSE  237
! #define KS_SGR_MOUSE_RELEASE  236 /* Release */
  
  /*
   * Filler used after KS_SPECIAL and others
--- 112,118 
  
  /* Used for the sgr mouse. */
  #define KS_SGR_MOUSE  237
! #define KS_SGR_MOUSE_RELEASE  236
  
  /*
   * Filler used after KS_SPECIAL and others
***
*** 140,145 
--- 140,147 
  
  /*
   * Codes for keys that do not have a termcap name.
+  * The numbers are fixed to make sure that recorded key sequences remain 
valid.
+  * Add new entries at the end, not halfway.
   *
   * K_SPECIAL KS_EXTRA KE_xxx
   */
***
*** 147,271 
  {
  KE_NAME = 3   /* name of this terminal entry */
  
! , KE_S_UP /* shift-up */
! , KE_S_DOWN   /* shift-down */
  
! , KE_S_F1 /* shifted function keys */
! , KE_S_F2
! , KE_S_F3
! , KE_S_F4
! , KE_S_F5
! , KE_S_F6
! , KE_S_F7
! , KE_S_F8
! , KE_S_F9
! , KE_S_F10
! 
! , KE_S_F11
! , KE_S_F12
! , KE_S_F13
! , KE_S_F14
! , KE_S_F15
! , KE_S_F16
! , KE_S_F17
! , KE_S_F18
! , KE_S_F19
! , KE_S_F20
! 
! , KE_S_F21
! , KE_S_F22
! , KE_S_F23
! , KE_S_F24
! , KE_S_F25
! , KE_S_F26
! , KE_S_F27
! , KE_S_F28
! , KE_S_F29
! , KE_S_F30
! 
! , KE_S_F31
! , KE_S_F32
! , KE_S_F33
! , KE_S_F34
! , KE_S_F35
! , KE_S_F36
! , KE_S_F37
  
! , KE_MOUSE/* mouse event start */
  
  /*
   * Symbols for pseudo keys which are translated from the real key symbols
   * above.
   */
! , KE_LEFTMOUSE/* Left mouse button click */
! , KE_LEFTDRAG /* Drag with left mouse button down */
! , KE_LEFTRELEASE  /* Left mouse button release */
! , KE_MIDDLEMOUSE  /* Middle mouse button click */
! , KE_MIDDLEDRAG   /* Drag with middle mouse button down */
! , KE_MIDDLERELEASE/* Middle mouse button release */
! , KE_RIGHTMOUSE   /* Right mouse button click */
! , KE_RIGHTDRAG/* Drag with right mouse button down */
! , KE_RIGHTRELEASE /* Right mouse button release */
! 
! , KE_IGNORE   /* Ignored mouse drag/release */
! 
! , KE_TAB  /* unshifted TAB key */
! , KE_S_TAB_OLD/* shifted TAB key (no longer used) */
! 
! , KE_XF1  /* extra vt100 function keys for xterm */
! , KE_XF2
! , KE_XF3
! , KE_XF4
! , KE_XEND /* extra (vt100) end key for xterm */
! , KE_ZEND /* extra (vt100) end key for xterm */
! , KE_XHOME/* extra (vt100) home key for xterm */
! , KE_ZHOME/* extra (vt100) home key for xterm */
! , KE_XUP  /* extra vt100 cursor keys for xterm */
! , KE_XDOWN
! , KE_XLEFT
! , KE_XRIGHT
! 
! , KE_LEFTMOUSE_NM /* non-mappable Left mouse button click */
! , KE_LEFTRELEASE_NM   /* non-mappable left mouse button release */
! 
! , KE_S_XF1/* extra vt100 shifted function keys for xterm 
*/
! , KE_S_XF2
! , KE_S_XF3
! , KE_S_XF4
  
  /* NOTE: The scroll wheel events are inverted: i.e. UP is the same as
   * moving the actual scroll wheel down, LEFT is the same as moving the
   * scroll wheel right. */
! , KE_MOUSEDOWN/* scroll wheel pseudo-button Down */
! , KE_MOUSEUP  /* scroll wheel pseudo-button Up */
! , KE_MOUSELEFT/* scroll wheel pseudo-button Left */
! , KE_MOUSERIGHT   /* scroll wheel pseudo-button Right */
! 
! , KE_KINS /* keypad Insert key */
! , KE_KDEL /* keypad Delete key */
! 
! , KE_CSI  /* CSI typed directly */
! , KE_SNR  /*  */
! , KE_PLUG /*  */
! , KE_CMDWIN   /* open command-line window from Command-line 
Mode */
! 
! , KE_C_LEFT   /* control-left */
! , KE_C_RIGHT  /* control-right */
! , KE_C_HOME   /* control-home */
! , KE_C_END/* control-end */
! 
! , KE_X1MOUSE  /* X1/X2 mouse-buttons */
! , KE_X1DRAG
! , KE_X1RELEASE
! , KE_X2MOUSE
! , KE_X2DRAG
! , KE_X2RELEASE
! 
! , KE_DROP /* DnD data is available */
! , KE_CURSORHOLD   /* CursorHold event */
! , KE_NOP  /* doesn't do something */
! , KE_FOCUSGAINED  /* focus gained */
! , KE_FOCUSLOST/* focus lost */
  };
  
  /*
--- 149,274 
  {
  KE_NAME = 3   /* name of this terminal entry */
  
! , KE_S_UP = 4 /* 

Off-by-one error for 'cmdheight' after patches 8.0.693 to 695

2017-07-07 Fir de Conversatie Tony Mechelynck
After manually adding symlinks in my shadow directories for
../libvterm and ../terminal.c I could successfully compile a Tiny and
a Huge build. No change in configure settings, which for the Huge
build are set as follows before running make:

export CONF_OPT_GUI='--enable-gui=gtk3 --enable-gnome-check'
export CONF_OPT_PERL='--enable-perlinterp'
export CONF_OPT_PYTHON='--enable-pythoninterp'
export CONF_OPT_PYTHON3='--disable-python3interp'
export CONF_OPT_TCL='--enable-tclinterp'
# /usr/bin/tclsh (softlink) is correctly set
export CONF_OPT_RUBY='--enable-rubyinterp'
export CONF_OPT_LUA='--enable-luainterp'
export CONF_OPT_MZSCHEME='--disable-mzschemeinterp'
#export CONF_OPT_PLTHOME='--with-plthome=/usr/local/plt'
export CONF_OPT_CSCOPE='--enable-cscope'
export CONF_OPT_MULTIBYTE='--enable-multibyte'
export CONF_OPT_FEAT='--with-features=huge'
export CONF_OPT_COMPBY='"--with-compiledby=antoine.mechely...@gmail.com"'

Then after running "make install" I start this Huge build as gvim with
my usual session file. 'cmdheight' is set to 2 but the command-line
height is only 1 line. After ":set ch+=1" the option is set to 3 but I
see only 2 lines of command-line space.

Best regards,
Tony.

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0695

2017-07-07 Fir de Conversatie Kazunobu Kuriyama
2017-07-07 20:06 GMT+09:00 skywind3000 :

> "E319: Sorry, the command is not available in this version"
>

Probably, you forgot to add --enable-terminal when you run the configure
script, didn't you?


>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0695

2017-07-07 Fir de Conversatie skywind3000
"E319: Sorry, the command is not available in this version" 

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 8.0.0696

2017-07-07 Fir de Conversatie Bram Moolenaar

Patch 8.0.0696
Problem:The .inc files are missing in git. (Nazri Ramliy)
Solution:   Remove the .inc line from .gitignore.
Files:  src/libvterm/.gitignore


*** ../vim-8.0.0695/src/libvterm/.gitignore 2017-07-07 11:53:29.515876528 
+0200
--- src/libvterm/.gitignore 2017-07-07 13:02:43.900363952 +0200
***
*** 4,10 
  tags
  src/*.o
  src/*.lo
- src/encoding/*.inc
  
  libvterm.la
  bin/unterm
--- 4,9 
*** ../vim-8.0.0695/src/version.c   2017-07-07 12:42:36.317480270 +0200
--- src/version.c   2017-07-07 13:03:43.611913771 +0200
***
*** 766,767 
--- 766,769 
  {   /* Add new patch number below this line */
+ /**/
+ 696,
  /**/

-- 
An actual excerpt from a classified section of a city newspaper:
"Illiterate?  Write today for free help!"

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0694

2017-07-07 Fir de Conversatie Bram Moolenaar

Nazri Ramliy wrote:

> On Fri, Jul 7, 2017 at 6:23 PM, Bram Moolenaar  wrote:
> >
> > Patch 8.0.0694
> > Problem:Building in shadow directory does not work.  Running Vim fails.
> > Solution:   Add the new libvterm directory.  Add missing change in command
> > list.
> 
> I'm getting this error when building:
> 
> libvterm/src/encoding.c:208:10: fatal error: 'encoding/DECdrawing.inc'
> file not found
> #include "encoding/DECdrawing.inc"
> 
> I ran configure with the --enable-terminal.

The files were in the patch...  Ah, the .gitignore file caused them not
to be included in git.  I decided to include the generated files, so
that we don't depend on perl.

-- 
"A clear conscience is usually the sign of a bad memory."
 -- Steven Wright

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0693

2017-07-07 Fir de Conversatie Bram Moolenaar

Nazri Ramliy wrote:

> On Fri, Jul 7, 2017 at 5:54 PM, Bram Moolenaar  wrote:
> >
> > Patch 8.0.0693
> > Problem:No terminal emulator support.  Cannot properly run commands in 
> > the
> > GUI.  Cannot run a job interactively with an ssh connection.
> > Solution:   Very early implementation of the :terminal command.  Includes
> > libvterm converted to ANSI C.  Many parts still missing.
> 
> Did you forget to include the result of "make cmdidxs"?
> 
> My vim installation is now in chicken-and-egg state:
> 
> $ vim
> E943: Command table needs to be updated, run 'make cmdidxs'
> $ make cmdidxs
> vim -u NONE -i NONE -X -S create_cmdidxs.vim
> make: *** [cmdidxs] Error 1
> $ vim -u NONE -i NONE -X -S create_cmdidxs.vim
> $ echo $?
> 1

I carefully checked to include the new cmdidxs, but forgot the change
that added the :terminal command...
Patch on the way.

-- 
hundred-and-one symptoms of being an internet addict:
118. You are on a first-name basis with your ISP's staff.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 8.0.0695

2017-07-07 Fir de Conversatie Bram Moolenaar

Patch 8.0.0695
Problem:Missing dependencies breaks parallel make.
Solution:   Add dependencies for terminal.o.
Files:  src/Makefile


*** ../vim-8.0.0694/src/Makefile2017-07-07 12:22:51.594469896 +0200
--- src/Makefile2017-07-07 12:39:24.550924329 +0200
***
*** 3554,3560 
  objects/os_unix.o: os_unix.c vim.h auto/config.h feature.h os_unix.h 
auto/osdef.h \
   ascii.h keymap.h term.h macros.h option.h structs.h regexp.h gui.h \
   gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h proto.h \
!  globals.h farsi.h arabic.h if_mzsch.h os_unixx.h
  objects/pathdef.o: auto/pathdef.c vim.h auto/config.h feature.h os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
--- 3554,3560 
  objects/os_unix.o: os_unix.c vim.h auto/config.h feature.h os_unix.h 
auto/osdef.h \
   ascii.h keymap.h term.h macros.h option.h structs.h regexp.h gui.h \
   gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h proto.h \
!  globals.h farsi.h arabic.h os_unixx.h
  objects/pathdef.o: auto/pathdef.c vim.h auto/config.h feature.h os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
***
*** 3603,3608 
--- 3603,3612 
   ascii.h keymap.h term.h macros.h option.h structs.h regexp.h gui.h \
   gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h proto.h \
   globals.h farsi.h arabic.h
+ objects/terminal.o: terminal.c vim.h auto/config.h feature.h os_unix.h \
+  auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
+  regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
+  proto.h globals.h farsi.h arabic.h
  objects/ui.o: ui.c vim.h auto/config.h feature.h os_unix.h auto/osdef.h 
ascii.h \
   keymap.h term.h macros.h option.h structs.h regexp.h gui.h gui_beval.h \
   proto/gui_beval.pro alloc.h ex_cmds.h spell.h proto.h globals.h farsi.h \
***
*** 3712,3718 
  objects/kword_test.o: kword_test.c main.c vim.h auto/config.h feature.h 
os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
!  proto.h globals.h farsi.h arabic.h charset.c mbyte.c
  objects/memfile_test.o: memfile_test.c main.c vim.h auto/config.h feature.h \
   os_unix.h auto/osdef.h ascii.h keymap.h term.h macros.h option.h \
   structs.h regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h \
--- 3716,3722 
  objects/kword_test.o: kword_test.c main.c vim.h auto/config.h feature.h 
os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
!  proto.h globals.h farsi.h arabic.h charset.c
  objects/memfile_test.o: memfile_test.c main.c vim.h auto/config.h feature.h \
   os_unix.h auto/osdef.h ascii.h keymap.h term.h macros.h option.h \
   structs.h regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h \
***
*** 3732,3738 
  objects/if_mzsch.o: if_mzsch.c vim.h auto/config.h feature.h os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
!  proto.h globals.h farsi.h arabic.h if_mzsch.h mzscheme_base.c
  objects/if_perl.o: auto/if_perl.c vim.h auto/config.h feature.h os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
--- 3736,3742 
  objects/if_mzsch.o: if_mzsch.c vim.h auto/config.h feature.h os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
!  proto.h globals.h farsi.h arabic.h if_mzsch.h
  objects/if_perl.o: auto/if_perl.c vim.h auto/config.h feature.h os_unix.h \
   auto/osdef.h ascii.h keymap.h term.h macros.h option.h structs.h \
   regexp.h gui.h gui_beval.h proto/gui_beval.pro alloc.h ex_cmds.h spell.h \
*** ../vim-8.0.0694/src/version.c   2017-07-07 12:22:51.594469896 +0200
--- src/version.c   2017-07-07 12:41:50.213826958 +0200
***
*** 766,767 
--- 766,769 
  {   /* Add new patch number below this line */
+ /**/
+ 695,
  /**/

-- 
Support your right to bare arms!  Wear short sleeves!

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit 

Re: Patch 8.0.0694

2017-07-07 Fir de Conversatie Dominique Pellé
Bram Mooolenaar wrote:

> Patch 8.0.0694
> Problem:Building in shadow directory does not work.  Running Vim fails.
> Solution:   Add the new libvterm directory.  Add missing change in command
> list.
> Files:  src/Makefile, src/ex_cmds.h


I get a compilation error:

$ CC=gcc-7 ./configure --with-features=huge --enable-terminal \
   --enable-gui=gtk3 --enable-python3interp=yes

$ make
...snip...
gcc-7 -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -pthread
-I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0
-I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0
-I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -I/usr/include/gtk-3.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/mirclient
-I/usr/include/mircore -I/usr/include/mircookie -I/usr/include/cairo
-I/usr/include/pango-1.0 -I/usr/include/harfbuzz
-I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo
-I/usr/include/pixman-1 -I/usr/include/freetype2
-I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/libpng12 -I/usr/include/glib-2.0
-I/usr/lib/x86_64-linux-gnu/glib-2.0/include   -g -O2
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1   -DEXITFREE
-DABORT_ON_INTERNAL_ERROR-Ilibvterm/include -DINLINE="" -o
objects/term_encoding.o libvterm/src/encoding.c
libvterm/src/encoding.c:208:10: fatal error: encoding/DECdrawing.inc:
No such file or directory
 #include "encoding/DECdrawing.inc"
  ^
compilation terminated.
Makefile:3283: recipe for target 'objects/term_encoding.o' failed
make: *** [objects/term_encoding.o] Error 1

Shoudl DECdraing.inc be in git?  Did I miss any sep to build Vim with
the :terminal command ?

Dominique

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0694

2017-07-07 Fir de Conversatie Nazri Ramliy
On Fri, Jul 7, 2017 at 6:23 PM, Bram Moolenaar  wrote:
>
> Patch 8.0.0694
> Problem:Building in shadow directory does not work.  Running Vim fails.
> Solution:   Add the new libvterm directory.  Add missing change in command
> list.

I'm getting this error when building:

libvterm/src/encoding.c:208:10: fatal error: 'encoding/DECdrawing.inc'
file not found
#include "encoding/DECdrawing.inc"

I ran configure with the --enable-terminal.

nazri

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Patch 8.0.0694

2017-07-07 Fir de Conversatie Bram Moolenaar

Patch 8.0.0694
Problem:Building in shadow directory does not work.  Running Vim fails.
Solution:   Add the new libvterm directory.  Add missing change in command
list.
Files:  src/Makefile, src/ex_cmds.h


*** ../vim-8.0.0693/src/Makefile2017-07-07 11:53:29.499876650 +0200
--- src/Makefile2017-07-07 12:17:13.273050367 +0200
***
*** 2810,2816 
  
  shadow:   runtime pixmaps
$(MKDIR_P) $(SHADOWDIR)
!   cd $(SHADOWDIR); ln -s ../*.[chm] ../*.in ../*.sh ../*.xs ../*.xbm 
../gui_gtk_res.xml ../toolcheck ../proto ../vimtutor ../gvimtutor ../install-sh 
.
mkdir $(SHADOWDIR)/auto
cd $(SHADOWDIR)/auto; ln -s ../../auto/configure .
$(MKDIR_P) $(SHADOWDIR)/po
--- 2810,2816 
  
  shadow:   runtime pixmaps
$(MKDIR_P) $(SHADOWDIR)
!   cd $(SHADOWDIR); ln -s ../*.[chm] ../*.in ../*.sh ../*.xs ../*.xbm 
../gui_gtk_res.xml ../toolcheck ../proto ../libvterm ../vimtutor ../gvimtutor 
../install-sh .
mkdir $(SHADOWDIR)/auto
cd $(SHADOWDIR)/auto; ln -s ../../auto/configure .
$(MKDIR_P) $(SHADOWDIR)/po
*** ../vim-8.0.0693/src/ex_cmds.h   2017-06-28 22:26:49.566720272 +0200
--- src/ex_cmds.h   2017-07-02 20:16:04.549007530 +0200
***
*** 1483,1488 
--- 1483,1491 
  EX(CMD_tearoff,   "tearoff",  ex_tearoff,
NEEDARG|EXTRA|TRLBAR|NOTRLCOM|CMDWIN,
ADDR_LINES),
+ EX(CMD_terminal,  "terminal", ex_terminal,
+   RANGE|NOTADR|EXTRA|TRLBAR|CMDWIN,
+   ADDR_OTHER),
  EX(CMD_tfirst,"tfirst",   ex_tag,
RANGE|NOTADR|BANG|TRLBAR|ZEROR,
ADDR_LINES),
*** ../vim-8.0.0693/src/version.c   2017-07-07 11:53:29.527876436 +0200
--- src/version.c   2017-07-07 12:22:07.014809862 +0200
***
*** 766,767 
--- 766,769 
  {   /* Add new patch number below this line */
+ /**/
+ 694,
  /**/

-- 
hundred-and-one symptoms of being an internet addict:
117. You are more comfortable typing in html.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0693

2017-07-07 Fir de Conversatie Nazri Ramliy
On Fri, Jul 7, 2017 at 6:09 PM, Nazri Ramliy  wrote:
> Did you forget to include the result of "make cmdidxs"?
>
> My vim installation is now in chicken-and-egg state:
>
> $ vim
> E943: Command table needs to be updated, run 'make cmdidxs'
> $ make cmdidxs
> vim -u NONE -i NONE -X -S create_cmdidxs.vim
> make: *** [cmdidxs] Error 1
> $ vim -u NONE -i NONE -X -S create_cmdidxs.vim
> $ echo $?
> 1

I checked out to v8.0.0692 and rebuild my vim to fix the chicken-and-egg issue.

phew.

nazri

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: Patch 8.0.0693

2017-07-07 Fir de Conversatie Nazri Ramliy
On Fri, Jul 7, 2017 at 5:54 PM, Bram Moolenaar  wrote:
>
> Patch 8.0.0693
> Problem:No terminal emulator support.  Cannot properly run commands in the
> GUI.  Cannot run a job interactively with an ssh connection.
> Solution:   Very early implementation of the :terminal command.  Includes
> libvterm converted to ANSI C.  Many parts still missing.

Did you forget to include the result of "make cmdidxs"?

My vim installation is now in chicken-and-egg state:

$ vim
E943: Command table needs to be updated, run 'make cmdidxs'
$ make cmdidxs
vim -u NONE -i NONE -X -S create_cmdidxs.vim
make: *** [cmdidxs] Error 1
$ vim -u NONE -i NONE -X -S create_cmdidxs.vim
$ echo $?
1

nazri

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.