Re: [vim/vim] winlayout() returns different results depending on the screen width (#5251)

[Yegappan Lakshmanan]

Hi Bram,

On Tue, Nov 19, 2019 at 2:25 PM Bram Moolenaar 
wrote:

> I had already included #5244 
> before I saw this pull request. Is this one better, or can we just keep
> what we have now?
>
>
>
We can keep what is there now. If we run into this issue with winlayout()
again in the
future in some other environment (with different terminal or terminal
size), we can then
use this.

- Yegappan

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/CAAW7x7m6x64Yk4%3Dy0iSUbC7MkX%3DpHAt-z4tq_BT5hZyt4N14uA%40mail.gmail.com.

Patch 8.1.2323

[Bram Moolenaar]

Patch 8.1.2323
Problem:Old MSVC version no longer tested.
Solution:   Drop support for MSCV 2008 and older. (Ken Takata, closes #5248)
Files:  src/INSTALLpc.txt, src/Make_mvc.mak, src/gui_w32.c, src/os_win32.c


*** ../vim-8.1.2322/src/INSTALLpc.txt   2019-09-27 13:07:59.573833437 +0200
--- src/INSTALLpc.txt   2019-11-19 22:56:46.752787940 +0100
***
*** 44,50 
  The currently recommended way (that means it has been verified to work) is
  using the "Visual Studio Community 2015" installation.  This includes the SDK
  needed to target Windows XP.  But not older Windows versions (95, 98), see
! |msvc-2008-express| below for that
  
  
  1. Microsoft Visual C++
--- 44,50 
  The currently recommended way (that means it has been verified to work) is
  using the "Visual Studio Community 2015" installation.  This includes the SDK
  needed to target Windows XP.  But not older Windows versions (95, 98), see
! "OLDER VERSIONS" below for that.
  
  
  1. Microsoft Visual C++
***
*** 62,73 
  Visual Studio
  -
  
! Building with Visual Studio (VS 98, VS .NET, VS .NET 2003, VS 2005, VS 2008,
! VS2010, VS2012, VS2013 and VS2015) is straightforward. (These instructions
! should also work for VS 4 and VS 5.)
! 
! Using VS C++ 2008 Express is recommended if you need the binary to run on
! Windows 95 or 97, see |msvc-2008-express| below.
  
  To build Vim from the command line with MSVC, use Make_mvc.mak.
  Visual Studio installed a batch file called vcvars32.bat, which you must
--- 62,69 
  Visual Studio
  -
  
! Building with Visual Studio (VS2010, VS2012, VS2013, VS2015, VS2017 and 
VS2019)
! is straightforward.
  
  To build Vim from the command line with MSVC, use Make_mvc.mak.
  Visual Studio installed a batch file called vcvars32.bat, which you must
***
*** 82,88 
  Make_mvc.mak allows a Vim to be built with various different features and
  debug support.
  
! For compiling Gvim with IME support on far-east Windows, add IME=yes
  to the parameters you pass to Make_mvc.mak.
  
  See the specific files for comments and options.
--- 78,84 
  Make_mvc.mak allows a Vim to be built with various different features and
  debug support.
  
! For compiling gVim with IME support on far-east Windows, add IME=yes
  to the parameters you pass to Make_mvc.mak.
  
  See the specific files for comments and options.
***
*** 91,116 
  Ron Aaron; they have been tested.
  
  
- Visual C++ 2008 Express Edition   *msvc-2008-express*
- ---
- 
- Visual C++ 2008 Express Edition can be downloaded for free from:
- http://www.microsoft.com/express/downloads/
- This includes the IDE and the debugger.
- 
- To set the environment execute the msvc2008.bat script.  You can then build
- Vim with Make_mvc.mak.
- 
- For building 64 bit binaries you also need to install the SDK:
- "Microsoft Windows SDK for Windows 7 and .NET Framework 3.5 SP1"
- You don't need the examples and documentation.
- 
- If you get an error that Win32.mak can't be found, you have to set the
- variable SDK_INCLUDE_DIR.  For example, on Windows 10, installation of MSVC
- puts include files in the following directory:
- set SDK_INCLUDE_DIR=C:\Program Files\Microsoft SDKs\Windows\v6.0A\Include
- 
- 
  Visual C++ 2010 Express Edition   *msvc-2010-express*
  ---
  
--- 87,92 
***
*** 162,167 
--- 138,146 
  The following Visual C++ team blog can serve as a reference page:
  
http://blogs.msdn.com/b/vcblog/archive/2012/10/08/windows-xp-targeting-with-c-in-visual-studio-2012.aspx
  
+ VC 2019 dropped support for targeting Windows XP.  If you want a binary that
+ targeting Windows XP, use VC 2017 or earlier.
+ 
  
  Cross compile support for Windows on ARM64
  --
***
*** 178,188 
  might still work, but these instructions might be outdated.
  
  If you need the executable to run on Windows 98 or ME, use the 2003 one
! |msvc-2003-toolkit|.
  
  Visual C++ Toolkit 2003   *msvc-2003-toolkit*
  ---
  
  You could download the Microsoft Visual C++ Toolkit 2003 from
  http://msdn.microsoft.com/visualc/vctoolkit2003/
  Unfortunately this URL is no longer valid.  Unofficial downloads appear to be
--- 157,170 
  might still work, but these instructions might be outdated.
  
  If you need the executable to run on Windows 98 or ME, use the 2003 one
! |msvc-2003-toolkit| or |msvc-2005-express|, and use the source code before
! 8.0.0029.
  
  Visual C++ Toolkit 2003   *msvc-2003-toolkit*
  ---
  
+ NOTE: this most likely does not work
+ 
  You could download the Microsoft Visual C++ Toolkit 2003 from
  http://msdn.microsoft.com/visualc/vctoolkit2003/
  Unfortunately this URL is no longer valid.  Unofficial downloads appear to be

Patch 8.1.2322

[Bram Moolenaar]

Patch 8.1.2322 (after 8.1.2320)
Problem:Quickfix test fails in very big terminal.
Solution:   Adjust the expected result for the width. (Masato Nishihata,
closes #5244)
Files:  src/testdir/test_quickfix.vim


*** ../vim-8.1.2321/src/testdir/test_quickfix.vim   2019-11-18 
22:02:12.808155010 +0100
--- src/testdir/test_quickfix.vim   2019-11-19 22:36:06.229200839 +0100
***
*** 619,626 
let w3 = win_getid()
call assert_true( == 'help')
call assert_true(winnr() == 1)
!   call assert_equal(['col', [['leaf', w3],
! \ ['row', [['leaf', w2], ['leaf', w1], winlayout())
  
new | only
set buftype=help
--- 619,633 
let w3 = win_getid()
call assert_true( == 'help')
call assert_true(winnr() == 1)
!   " See jump_to_help_window() for details
!   let w2_width = winwidth(w2)
!   if w2_width !=  && w2_width < 80
! call assert_equal(['col', [['leaf', w3],
!   \ ['row', [['leaf', w2], ['leaf', w1], winlayout())
!   else
! call assert_equal(['row', [['col', [['leaf', w3], ['leaf', w2]]],
!   \ ['leaf', w1]]] , winlayout())
!   endif
  
new | only
set buftype=help
*** ../vim-8.1.2321/src/version.c   2019-11-18 23:31:44.964227445 +0100
--- src/version.c   2019-11-19 22:38:36.988633737 +0100
***
*** 743,744 
--- 743,746 
  {   /* Add new patch number below this line */
+ /**/
+ 2322,
  /**/

-- 
I AM THANKFUL...
...for a lawn that needs mowing, windows that need cleaning
and gutters that need fixing because it means I have a home.

 /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net   \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org///
 \\\help me help AIDS victims -- http://ICCF-Holland.org///

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/201911192145.xAJLj0LG026429%40masaka.moolenaar.net.

Re: Patch 8.1.2320

[Ken Takata]

Hi,

2019/11/19 Tue 18:04:35 UTC+9 Elimar Riesebieter wrote:
>
> * Elimar Riesebieter > [2019-11-19 09:44 
> +0100]: 
>
> > * Bram Moolenaar > [2019-11-18 22:02 
> +0100]: 
> > 
> > > 
> > > Patch 8.1.2320 
> > > Problem:Insufficient test coverage for quickfix. 
> > > Solution:   Add more tests.  Fix uncovered problem. (Yegappan 
> Lakshmanan, 
> > > closes #5238) 
> > > Files:src/quickfix.c, src/testdir/test_quickfix.vim 
> > 
> > Building on amd64 I get: 
> > 
> > Failures: 
> > From test_quickfix.vim: 
> > Found errors in Test_helpgrep(): 
> > function RunTheTest[40]..Test_helpgrep[1]..5_test_xhelpgrep 
> line 42: Expected ['col', [['leaf', 1067], ['row', [['leaf', 1066], 
> ['leaf', 1065] but got ['row', [['col', [['leaf', 1067], ['leaf 
> > ', 1066]]], ['leaf', 1065]]] 
> > function RunTheTest[40]..Test_helpgrep[3]..5_test_xhelpgrep 
> line 42: Expected ['col', [['leaf', 1075], ['row', [['leaf', 1074], 
> ['leaf', 1073] but got ['row', [['col', [['leaf', 1075], ['leaf 
> > ', 1074]]], ['leaf', 1073]] 
>
> This is on i386 and powerps as well. 
>
>
Looks like the same with https://github.com/vim/vim/pull/5244.

Regards,
Ken Takata

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/8a812f84-b45d-485e-8183-5cc6b0041344%40googlegroups.com.

Re: Patch 8.1.2320

[Elimar Riesebieter]

* Elimar Riesebieter  [2019-11-19 09:44 +0100]:

> * Bram Moolenaar  [2019-11-18 22:02 +0100]:
> 
> > 
> > Patch 8.1.2320
> > Problem:Insufficient test coverage for quickfix.
> > Solution:   Add more tests.  Fix uncovered problem. (Yegappan Lakshmanan,
> > closes #5238)
> > Files:  src/quickfix.c, src/testdir/test_quickfix.vim
> 
> Building on amd64 I get:
> 
> Failures:
> From test_quickfix.vim:
> Found errors in Test_helpgrep():
> function RunTheTest[40]..Test_helpgrep[1]..5_test_xhelpgrep line 
> 42: Expected ['col', [['leaf', 1067], ['row', [['leaf', 1066], ['leaf', 
> 1065] but got ['row', [['col', [['leaf', 1067], ['leaf
> ', 1066]]], ['leaf', 1065]]]
> function RunTheTest[40]..Test_helpgrep[3]..5_test_xhelpgrep line 
> 42: Expected ['col', [['leaf', 1075], ['row', [['leaf', 1074], ['leaf', 
> 1073] but got ['row', [['col', [['leaf', 1075], ['leaf
> ', 1074]]], ['leaf', 1073]]

This is on i386 and powerps as well.

Elimar
-- 
.~.
/V\   L   I   N   U   X
   /( )\ >Phear the Penguin<
   ^^-^^

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20191119090431.44jche76mf6bgylf%40toy.home.lxtec.de.

Re: Patch 8.1.2320

[Elimar Riesebieter]

* Bram Moolenaar  [2019-11-18 22:02 +0100]:

> 
> Patch 8.1.2320
> Problem:Insufficient test coverage for quickfix.
> Solution:   Add more tests.  Fix uncovered problem. (Yegappan Lakshmanan,
> closes #5238)
> Files:src/quickfix.c, src/testdir/test_quickfix.vim

Building on amd64 I get:

Failures:
From test_quickfix.vim:
Found errors in Test_helpgrep():
function RunTheTest[40]..Test_helpgrep[1]..5_test_xhelpgrep line 
42: Expected ['col', [['leaf', 1067], ['row', [['leaf', 1066], ['leaf', 
1065] but got ['row', [['col', [['leaf', 1067], ['leaf
', 1066]]], ['leaf', 1065]]]
function RunTheTest[40]..Test_helpgrep[3]..5_test_xhelpgrep line 
42: Expected ['col', [['leaf', 1075], ['row', [['leaf', 1074], ['leaf', 
1073] but got ['row', [['col', [['leaf', 1075], ['leaf
', 1074]]], ['leaf', 1073]]


Elimar
-- 
  355/113: Not the famous irrational number pi,
   but an incredible simulation!
-unknown

-- 
-- 
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php

--- 
You received this message because you are subscribed to the Google Groups 
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/vim_dev/20191119084427.q5acjvh35ygeiypv%40toy.home.lxtec.de.