Re: Patch 8.2.0452
This change has broken govim which relies on recursive calls working. I'll
submit an issue with further details tomorrow
On Thu, 26 Mar 2020, 15:05 Bram Moolenaar, wrote:
>
> Patch 8.2.0452
> Problem:channel_parse_messages() fails when called recursively.
> Solution: Return for a recursive call. (closes #5835)
> Files: src/channel.c
>
>
> *** ../vim-8.2.0451/src/channel.c 2020-03-24 20:35:14.741080390 +0100
> --- src/channel.c 2020-03-26 15:56:02.939711511 +0100
> ***
> *** 4428,4441
> int ret = FALSE;
> int r;
> ch_part_T part = PART_SOCK;
> #ifdef ELAPSED_FUNC
> elapsed_T start_tv;
> -
> - ELAPSED_INIT(start_tv);
> #endif
>
> ++safe_to_invoke_callback;
>
> // Only do this message when another message was given, otherwise we
> get
> // lots of them.
> if ((did_repeated_msg & REPEATED_MSG_LOOKING) == 0)
> --- 4428,4449
> int ret = FALSE;
> int r;
> ch_part_T part = PART_SOCK;
> + static intrecursive = FALSE;
> #ifdef ELAPSED_FUNC
> elapsed_T start_tv;
> #endif
>
> + // The code below may invoke callbacks, which might call us back.
> + // That doesn't work well, just return without doing anything.
> + if (recursive)
> + return FALSE;
> + recursive = TRUE;
> ++safe_to_invoke_callback;
>
> + #ifdef ELAPSED_FUNC
> + ELAPSED_INIT(start_tv);
> + #endif
> +
> // Only do this message when another message was given, otherwise we
> get
> // lots of them.
> if ((did_repeated_msg & REPEATED_MSG_LOOKING) == 0)
> ***
> *** 4513,4518
> --- 4521,4527
> }
>
> --safe_to_invoke_callback;
> + recursive = FALSE;
>
> return ret;
> }
> *** ../vim-8.2.0451/src/version.c 2020-03-26 15:39:50.223238189 +0100
> --- src/version.c 2020-03-26 15:56:59.759509505 +0100
> ***
> *** 740,741
> --- 740,743
> { /* Add new patch number below this line */
> + /**/
> + 452,
> /**/
>
> --
> Windows
> M!uqoms
>
> /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net
> \\\
> ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/
> \\\
> \\\ an exciting new programming language -- http://www.Zimbu.org
> ///
> \\\help me help AIDS victims -- http://ICCF-Holland.org
> ///
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups
> "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to vim_dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/vim_dev/202003261505.02QF5V0c000459%40masaka.moolenaar.net
> .
>
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/CACoUkn4_8-XO79u3v2dRT5ay07Ndb0W45d9%3DcDdxTo%3Drz3RE9Q%40mail.gmail.com.
Re: Patch 8.2.0460
On 28-Mar-2020 06:53, Bram Moolenaar wrote: John Marriott wrote: On 27-Mar-2020 09:14, Bram Moolenaar wrote: Patch 8.2.0460 (after 8.2.0459) Problem:Build failure because of wrong feature name. Solution: Correct feature name. Files: src/evalfunc.c I'm actually surprised it doesn't fail on more systems. Since t_channel and t_job are always defined, might as well do the same for t_float. Then we can remove the #ifdef's. Hi Bram, 8.2.0463 fixed it for me. Cheers John -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/d7b5212d-c104-a90f-bd4e-cdcf8ceaac2b%40internode.on.net.
Re: Patch 8.2.0463
I wrote: > Patch 8.2.0463 > Problem:Build error without float and channel feature. (John Marriott) > Solution: Define return types always. > Files: src/globals.h, src/evalfunc.c Somehow the git commit got the wrong description and tag. Don't think that can be fixed afterwards. -- FATHER:You killed eight wedding guests in all! LAUNCELOT: Er, Well ... the thing is ... I thought your son was a lady. FATHER:I can understand that. "Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202003272009.02RK9Cdf032360%40masaka.moolenaar.net.
Patch 8.2.0464
Patch 8.2.0464
Problem:Typos and other small problems.
Solution: Fix the typos. Add missing files to the distribution.
Files: Filelist, src/buffer.c, src/drawline.c, src/gui_gtk_x11.c,
src/os_unixx.h, src/proto/popupwin.pro
*** ../vim-8.2.0463/Filelist2020-03-25 20:16:23.647676279 +0100
--- Filelist2020-03-27 20:41:58.848482303 +0100
***
*** 12,17
--- 12,18
appveyor.yml \
ci/appveyor.bat \
ci/if_ver*.vim \
+ ci/load-snd-dummy.sh \
src/Make_all.mak \
src/README.md \
src/alloc.h \
***
*** 151,167
src/testdir/*.py \
src/testdir/lsan-suppress.txt \
src/testdir/sautest/autoload/*.vim \
- src/testdir/runtest.vim \
- src/testdir/summarize.vim \
src/testdir/check.vim \
! src/testdir/shared.vim \
src/testdir/screendump.vim \
- src/testdir/view_util.vim \
- src/testdir/term_util.vim \
src/testdir/setup.vim \
- src/testdir/gui_init.vim \
src/testdir/setup_gui.vim \
! src/testdir/gui_preinit.vim \
src/testdir/test[0-9]*.ok \
src/testdir/test[0-9]*a.ok \
src/testdir/test_[a-z]*.ok \
--- 152,169
src/testdir/*.py \
src/testdir/lsan-suppress.txt \
src/testdir/sautest/autoload/*.vim \
src/testdir/check.vim \
! src/testdir/gui_init.vim \
! src/testdir/gui_preinit.vim \
! src/testdir/mouse.vim \
! src/testdir/runtest.vim \
src/testdir/screendump.vim \
src/testdir/setup.vim \
src/testdir/setup_gui.vim \
! src/testdir/shared.vim \
! src/testdir/summarize.vim \
! src/testdir/term_util.vim \
! src/testdir/view_util.vim \
src/testdir/test[0-9]*.ok \
src/testdir/test[0-9]*a.ok \
src/testdir/test_[a-z]*.ok \
*** ../vim-8.2.0463/src/buffer.c2020-03-11 14:19:53.480369957 +0100
--- src/buffer.c2020-03-27 20:55:07.017723805 +0100
***
*** 2014,2020
--- 2014,2023
apply_autocmds(EVENT_BUFWIPEOUT, NULL, NULL, FALSE, curbuf);
#ifdef FEAT_EVAL
if (aborting()) // autocmds may abort script processing
+ {
+ vim_free(ffname);
return NULL;
+ }
#endif
if (buf == curbuf)
{
*** ../vim-8.2.0463/src/drawline.c 2020-02-23 15:29:43.013454555 +0100
--- src/drawline.c 2020-02-28 21:39:30.338626049 +0100
***
*** 270,276
int tocol = MAXCOL; // end of inverting
int fromcol_prev = -2; // start of inverting after
cursor
int noinvcur = FALSE; // don't invert the cursor
- pos_T *top, *bot;
int lnum_in_visual_area = FALSE;
pos_T pos;
long v;
--- 270,275
***
*** 535,540
--- 534,541
// handle Visual active in this window
if (VIsual_active && wp->w_buffer == curwin->w_buffer)
{
+ pos_T *top, *bot;
+
if (LTOREQ_POS(curwin->w_cursor, VIsual))
{
// Visual is after curwin->w_cursor
*** ../vim-8.2.0463/src/gui_gtk_x11.c 2019-12-01 22:07:57.0 +0100
--- src/gui_gtk_x11.c 2020-03-22 17:44:33.930845872 +0100
***
*** 4743,4748
--- 4743,4750
PangoCoverage *coverage;
gunicharuc;
+ // Valgrind reports a leak for pango_language_from_string(), but the
+ // documentation says "This is owned by Pango and should not be freed".
coverage = pango_font_get_coverage(
font, pango_language_from_string(cjk_langs[i]));
*** ../vim-8.2.0463/src/os_unixx.h 2019-11-30 18:52:25.0 +0100
--- src/os_unixx.h 2020-03-16 22:50:46.821360027 +0100
***
*** 47,59
#endif // !USE_SYSTEM
#ifdef HAVE_STROPTS_H
! #ifdef sinix
! #define buf_T __system_buf_t__
! #endif
# include
! #ifdef sinix
! #undef buf_T
! #endif
#endif
#ifdef HAVE_STRING_H
--- 47,59
#endif // !USE_SYSTEM
#ifdef HAVE_STROPTS_H
! # ifdef sinix
! # define buf_T __system_buf_t__
! # endif
# include
! # ifdef sinix
! # undef buf_T
! # endif
#endif
#ifdef HAVE_STRING_H
*** ../vim-8.2.0463/src/proto/popupwin.pro 2020-02-01 23:04:20.120422629
+0100
--- src/proto/popupwin.pro 2020-03-20 22:18:21.543100629 +0100
***
*** 33,38
--- 33,39
void popup_show(win_T *wp);
void f_popup_show(typval_T *argvars, typval_T *rettv);
void f_popup_settext(typval_T *argvars,
Patch 8.2.0463
Patch 8.2.0463
Problem:Build error without float and channel feature. (John Marriott)
Solution: Define return types always.
Files: src/globals.h, src/evalfunc.c
*** ../vim-8.2.0463/src/globals.h 2020-02-26 16:15:31.068386966 +0100
--- src/globals.h 2020-03-27 20:46:16.595576172 +0100
***
*** 384,392
EXTERN type_T t_bool INIT4(VAR_BOOL, 0, NULL, NULL);
EXTERN type_T t_special INIT4(VAR_SPECIAL, 0, NULL, NULL);
EXTERN type_T t_number INIT4(VAR_NUMBER, 0, NULL, NULL);
- # ifdef FEAT_FLOAT
EXTERN type_T t_float INIT4(VAR_FLOAT, 0, NULL, NULL);
- # endif
EXTERN type_T t_string INIT4(VAR_STRING, 0, NULL, NULL);
EXTERN type_T t_blob INIT4(VAR_BLOB, 0, NULL, NULL);
EXTERN type_T t_job INIT4(VAR_JOB, 0, NULL, NULL);
--- 384,390
*** ../vim-8.2.0463/src/evalfunc.c 2020-03-26 23:13:30.067551209 +0100
--- src/evalfunc.c 2020-03-27 20:46:36.551506225 +0100
***
*** 280,292
{
return _number;
}
- #ifdef FEAT_FLOAT
static type_T *
ret_float(int argcount UNUSED, type_T **argtypes UNUSED)
{
return _float;
}
- #endif
static type_T *
ret_string(int argcount UNUSED, type_T **argtypes UNUSED)
{
--- 280,290
***
*** 336,342
{
return _partial_void;
}
- #ifdef FEAT_JOB_CHANNEL
static type_T *
ret_channel(int argcount UNUSED, type_T **argtypes UNUSED)
{
--- 334,339
***
*** 347,353
{
return _job;
}
- #endif
static type_T *ret_f_function(int argcount, type_T **argtypes);
--- 344,349
*** ../vim-8.2.0463/src/version.c 2020-03-27 20:51:29.206483028 +0100
--- src/version.c 2020-03-27 20:50:11.930752775 +0100
***
*** 740,741
--- 740,743
{ /* Add new patch number below this line */
+ /**/
+ 463,
/**/
--
-rwxr-xr-x 1 root 24 Oct 29 1929 /bin/ed
-rwxr-xr-t 4 root 131720 Jan 1 1970 /usr/ucb/vi
-rwxr-xr-x 1 root 5.89824e37 Oct 22 1990 /usr/bin/emacs
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202003271953.02RJrOPj028865%40masaka.moolenaar.net.
Re: Patch 8.2.0460
John Marriott wrote: > On 27-Mar-2020 09:14, Bram Moolenaar wrote: > > Patch 8.2.0460 (after 8.2.0459) > > Problem:Build failure because of wrong feature name. > > Solution: Correct feature name. > > Files: src/evalfunc.c > > > > > > > After applying patches 8.2.0449 to 8.2.0460, HP-UX throws this error if > FEAT_FLOAT and FEAT_JOB_CHANNEL are not defined (I get an error to the > same effect from mingw64): > > cc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -D_REENTRANT -o > objects/evalfunc.o evalfunc.c > cc: "evalfunc.c", line 421: error 1588: "ret_float" undefined. > cc: "evalfunc.c", line 421: error 1521: Incorrect initialization. > cc: "evalfunc.c", line 430: error 1521: Incorrect initialization. > cc: "evalfunc.c", line 443: error 1521: Incorrect initialization. > cc: "evalfunc.c", line 444: error 1521: Incorrect initialization. > cc: "evalfunc.c", line 484: error 1521: Incorrect initialization. > cc: "evalfunc.c", line 491: error 1588: "ret_job" undefined. > cc: "evalfunc.c", line 491: error 1521: Incorrect initialization. > cc: "evalfunc.c", line 495: error 1588: "ret_channel" undefined. > cc: "evalfunc.c", line 495: error 1521: Incorrect initialization. [...] > I'm not sure of the correct fix, so I have put together three different > possibilities, all of which appear to fix the problem both on HP-UX and > mingw64. I'm actually surprised it doesn't fail on more systems. Since t_channel and t_job are always defined, might as well do the same for t_float. Then we can remove the #ifdef's. -- BLACK KNIGHT: Come on you pansy! [hah] [parry thrust] [ARTHUR chops the BLACK KNIGHT's right arm off] ARTHUR:Victory is mine! [kneeling] We thank thee Lord, that in thy merc- [Black Knight kicks Arthur in the head while he is praying] The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202003271953.02RJrPht028871%40masaka.moolenaar.net.
Patch 8.2.0462
Patch 8.2.0462
Problem:Previewwindow test fails on some systems. (James McCoy)
Solution: Wait a bit after sending the "o". (closes #5849)
Files: src/testdir/test_popup.vim,
src/testdir/dumps/Test_popup_and_previewwindow_01.dump
*** ../vim-8.2.0461/src/testdir/test_popup.vim 2020-03-15 16:12:16.552208654
+0100
--- src/testdir/test_popup.vim 2020-03-27 20:23:15.056540606 +0100
***
*** 743,757
let lines =<< trim END
set previewheight=9
silent! pedit
! call setline(1, map(repeat(["ab"], 10), "v:val. v:key"))
exec "norm! G\\"
END
call writefile(lines, 'Xscript')
let buf = RunVimInTerminal('-S Xscript', {})
" Test that popup and previewwindow do not overlap.
! call term_sendkeys(buf, "o\\")
! sleep 100m
call VerifyScreenDump(buf, 'Test_popup_and_previewwindow_01', {})
call term_sendkeys(buf, "\u")
--- 743,761
let lines =<< trim END
set previewheight=9
silent! pedit
! call setline(1, map(repeat(["ab"], 10), "v:val .. v:key"))
exec "norm! G\\"
END
call writefile(lines, 'Xscript')
let buf = RunVimInTerminal('-S Xscript', {})
+ " wait for the script to finish
+ call term_wait(buf)
+
" Test that popup and previewwindow do not overlap.
! call term_sendkeys(buf, "o")
! call term_wait(buf, 100)
! call term_sendkeys(buf, "\\")
call VerifyScreenDump(buf, 'Test_popup_and_previewwindow_01', {})
call term_sendkeys(buf, "\u")
*** ../vim-8.2.0461/src/testdir/dumps/Test_popup_and_previewwindow_01.dump
2018-12-01 11:47:11.0 +0100
--- src/testdir/dumps/Test_popup_and_previewwindow_01.dump 2020-03-27
20:13:15.530558554 +0100
***
*** 16,20
|a+0#001#ffd7ff255|b|6| @11| +0#000#a8a8a8255|
Re: Patch 8.2.0460
On 27-Mar-2020 09:14, Bram Moolenaar wrote:
Patch 8.2.0460 (after 8.2.0459)
Problem:Build failure because of wrong feature name.
Solution: Correct feature name.
Files: src/evalfunc.c
After applying patches 8.2.0449 to 8.2.0460, HP-UX throws this error if
FEAT_FLOAT and FEAT_JOB_CHANNEL are not defined (I get an error to the
same effect from mingw64):
cc -c -I. -Iproto -DHAVE_CONFIG_H -O2 -D_REENTRANT -o
objects/evalfunc.o evalfunc.c
cc: "evalfunc.c", line 421: error 1588: "ret_float" undefined.
cc: "evalfunc.c", line 421: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 430: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 443: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 444: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 484: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 491: error 1588: "ret_job" undefined.
cc: "evalfunc.c", line 491: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 495: error 1588: "ret_channel" undefined.
cc: "evalfunc.c", line 495: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 515: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 516: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 543: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 555: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 556: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 642: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 645: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 666: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 667: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 736: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 782: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 795: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 852: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 853: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 863: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 866: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 910: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 911: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 926: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 957: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 959: error 1521: Incorrect initialization.
cc: "evalfunc.c", line 987: error 1521: Incorrect initialization.
*** Error exit code 1
Stop.
*** Error exit code 1
Stop.
I'm not sure of the correct fix, so I have put together three different
possibilities, all of which appear to fix the problem both on HP-UX and
mingw64.
Regards
John
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups "vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/1c3dae00-776c-979b-0448-0835d5b6104b%40internode.on.net.
--- evalfunc.c.orig 2020-03-27 09:22:12.0 +1100
+++ evalfunc.c 2020-03-27 09:30:05.777314100 +1100
@@ -418,7 +418,9 @@
static funcentry_T global_functions[] =
{
{"abs",1, 1, FEARG_1,ret_any, FLOAT_FUNC(f_abs)},
+#ifdef FEAT_FLOAT
{"acos", 1, 1, FEARG_1,ret_float,FLOAT_FUNC(f_acos)},
+#endif
{"add",2, 2, FEARG_1,ret_any, f_add},
{"and",2, 2, FEARG_1,ret_number, f_and},
{"append", 2, 2, FEARG_LAST, ret_number, f_append},
@@ -427,7 +429,9 @@
{"argidx", 0, 0, 0, ret_number, f_argidx},
{"arglistid", 0, 2, 0, ret_number, f_arglistid},
{"argv", 0, 2, 0, ret_any, f_argv},
+#ifdef FEAT_FLOAT
{"asin", 1, 1, FEARG_1,ret_float,FLOAT_FUNC(f_asin)},
+#endif
{"assert_beeps", 1, 2, FEARG_1,ret_number, f_assert_beeps},
{"assert_equal", 2, 3, FEARG_2,ret_number, f_assert_equal},
{"assert_equalfile", 2, 2, FEARG_1, ret_number,
f_assert_equalfile},
@@ -440,8 +444,10 @@
{"assert_notmatch",2, 3, FEARG_2,ret_number,
f_assert_notmatch},
{"assert_report", 1, 1, FEARG_1,ret_number, f_assert_report},
{"assert_true",1, 2, FEARG_1,ret_number, f_assert_true},
+#ifdef FEAT_FLOAT
{"atan", 1, 1, FEARG_1,ret_float,FLOAT_FUNC(f_atan)},
{"atan2", 2, 2, FEARG_1,ret_float,FLOAT_FUNC(f_atan2)},
+#endif
{"balloon_gettext",0, 0, 0, ret_string,
#ifdef FEAT_BEVAL
Patch 8.2.0461
Patch 8.2.0461
Problem:Confirm test fails on amd64 system. (Alimar Riesebieter)
Solution: Add an extra WaitForAssert(). (Dominique Pelle)
Files: src/testdir/test_excmd.vim
*** ../vim-8.2.0460/src/testdir/test_excmd.vim 2020-03-26 22:09:47.981372814
+0100
--- src/testdir/test_excmd.vim 2020-03-27 19:36:27.297713219 +0100
***
*** 264,269
--- 264,271
call WaitForAssert({-> assert_match('^\[Y\]es, (N)o, (C)ancel: *$',
\ term_getline(buf, 20))}, 1000)
call term_sendkeys(buf, "N")
+ call WaitForAssert({-> assert_match('^ *0,0-1 All$',
+ \ term_getline(buf, 20))}, 1000)
call StopVimInTerminal(buf)
endfunc
*** ../vim-8.2.0460/src/version.c 2020-03-26 23:13:30.067551209 +0100
--- src/version.c 2020-03-27 19:40:44.636787175 +0100
***
*** 740,741
--- 740,743
{ /* Add new patch number below this line */
+ /**/
+ 461,
/**/
--
"It's so simple to be wise. Just think of something stupid to say
and then don't say it."-- Sam Levenson
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202003271841.02RIfZhQ014948%40masaka.moolenaar.net.
Re: Test failures on amd64
Dominique wrote: > Elimar Riesebieter wrote: > > > Hi, > > > > building v8.2.0460 gives the following test failures an amd64: > > > > Failures: > > From test_excmd.vim: > > Found errors in Test_confirm_cmd_cancel(): > > Run 1: > > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn= > Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16 line 1= > : Expected 'finished' but got 'running' > > Run 2: > > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn= > Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20 line 1= > : Expected 'finished' but got 'running' > > Run 3: > > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn= > Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24 line 1= > : Expected 'finished' but got 'running' > > Run 4: > > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn= > Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28 line 1= > : Expected 'finished' but got 'running' > > Run 5: > > function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimIn= > Terminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32 line 1= > : Expected 'finished' but got 'running' > > Flaky test failed too often, giving up > > From test_alot.vim: > > Found errors in Test_compiler(): > > function RunTheTest[40]..Test_compiler line 23: command did not= > fail: clist > > function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\= > d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does n= > ot match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symb= > ol "$foo" requires explicit package name (did you forget to declare "my $fo= > o"?)' > > I see the same failure in Test_confirm_cmd_cancel() > on one of my 2 machines. The attached patch fixes > it for me. Can you also check? Thanks! Such a WaitFor is nicer than a simple delay. But it's hard to do without being able to reproduce. > All other test pass for me. I don't see the failure > in Test_compiler(). What does "/usr/bin/perl --version" > say on your machine? Mine says: > > $ /usr/bin/perl --version > > This is perl 5, version 26, subversion 1 (v5.26.1) built for > x86_64-linux-gnu-thread-multi > (with 67 registered patches, see perl -V for more detail) > ...snip... Strangely, the "does not match" text seems to have part of the error repeated. Would work to add a ".*" around "explicit", but that would be weird. -- No letters of the alphabet were harmed in the creation of this message. /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202003271841.02RIfZEf014954%40masaka.moolenaar.net.
Re: Test failures on amd64
* Dominique Pellé [2020-03-27 14:07 +0100]: > Elimar Riesebieter wrote: > > > Hi, > > > > building v8.2.0460 gives the following test failures an amd64: > > > > Failures: > > From test_excmd.vim: > > Found errors in Test_confirm_cmd_cancel(): > > Run 1: > > function > > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16 > > line 1: Expected 'finished' but got 'running' > > Run 2: > > function > > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20 > > line 1: Expected 'finished' but got 'running' > > Run 3: > > function > > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24 > > line 1: Expected 'finished' but got 'running' > > Run 4: > > function > > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28 > > line 1: Expected 'finished' but got 'running' > > Run 5: > > function > > RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32 > > line 1: Expected 'finished' but got 'running' > > Flaky test failed too often, giving up > > From test_alot.vim: > > Found errors in Test_compiler(): > > function RunTheTest[40]..Test_compiler line 23: command did not > > fail: clist > > function RunTheTest[40]..Test_compiler line 29: Pattern '\\n > > \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does > > not match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global > > symbol "$foo" requires explicit package name (did you forget to declare "my > > $foo"?)' > > I see the same failure in Test_confirm_cmd_cancel() > on one of my 2 machines. The attached patch fixes > it for me. Can you also check? Appying your patch mede the built successful :-) > > All other test pass for me. I don't see the failure > in Test_compiler(). What does "/usr/bin/perl --version" > say on your machine? Mine says: Mine says: This is perl 5, version 30, subversion 0 (v5.30.0) built for x86_64-linux-gnu-thread-multi (with 46 registered patches, see perl -V for more detail) Thanks for cooperation Elimar -- Alles, was viel bedacht wird, wird bedenklich!;-) Friedrich Nietzsche -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20200327134850.ukqp4gozxhgtwb57%40toy.home.lxtec.de.
Re: Test failures on amd64
Elimar Riesebieter wrote:
> Hi,
>
> building v8.2.0460 gives the following test failures an amd64:
>
> Failures:
> From test_excmd.vim:
> Found errors in Test_confirm_cmd_cancel():
> Run 1:
> function
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16
> line 1: Expected 'finished' but got 'running'
> Run 2:
> function
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20
> line 1: Expected 'finished' but got 'running'
> Run 3:
> function
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24
> line 1: Expected 'finished' but got 'running'
> Run 4:
> function
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28
> line 1: Expected 'finished' but got 'running'
> Run 5:
> function
> RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32
> line 1: Expected 'finished' but got 'running'
> Flaky test failed too often, giving up
> From test_alot.vim:
> Found errors in Test_compiler():
> function RunTheTest[40]..Test_compiler line 23: command did not
> fail: clist
> function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\d\\+
> Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not
> match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symbol
> "$foo" requires explicit package name (did you forget to declare "my $foo"?)'
I see the same failure in Test_confirm_cmd_cancel()
on one of my 2 machines. The attached patch fixes
it for me. Can you also check?
All other test pass for me. I don't see the failure
in Test_compiler(). What does "/usr/bin/perl --version"
say on your machine? Mine says:
$ /usr/bin/perl --version
This is perl 5, version 26, subversion 1 (v5.26.1) built for
x86_64-linux-gnu-thread-multi
(with 67 registered patches, see perl -V for more detail)
...snip...
Regards
Dominique
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/CAON-T_gZCumyJsOiZ3y1qLRUSrcyCXsZ1O1F5toqeeoLfPFF5w%40mail.gmail.com.
diff --git a/src/testdir/test_excmd.vim b/src/testdir/test_excmd.vim
index ec252a660..d5588d670 100644
--- a/src/testdir/test_excmd.vim
+++ b/src/testdir/test_excmd.vim
@@ -264,6 +264,8 @@ func Test_confirm_cmd_cancel()
call WaitForAssert({-> assert_match('^\[Y\]es, (N)o, (C)ancel: *$',
\ term_getline(buf, 20))}, 1000)
call term_sendkeys(buf, "N")
+ call WaitForAssert({-> assert_match('^ *0,0-1 All$',
+\ term_getline(buf, 20))}, 1000)
call StopVimInTerminal(buf)
endfunc
Test failures on amd64
Hi, building v8.2.0460 gives the following test failures an amd64: Failures: From test_excmd.vim: Found errors in Test_confirm_cmd_cancel(): Run 1: function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..16 line 1: Expected 'finished' but got 'running' Run 2: function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..20 line 1: Expected 'finished' but got 'running' Run 3: function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..24 line 1: Expected 'finished' but got 'running' Run 4: function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..28 line 1: Expected 'finished' but got 'running' Run 5: function RunTheTest[40]..Test_confirm_cmd_cancel[18]..StopVimInTerminal[10]..WaitForAssert[2]..7_WaitForCommon[11]..32 line 1: Expected 'finished' but got 'running' Flaky test failed too often, giving up From test_alot.vim: Found errors in Test_compiler(): function RunTheTest[40]..Test_compiler line 23: command did not fail: clist function RunTheTest[40]..Test_compiler line 29: Pattern '\\n \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not match '\n21 Xfoo.pl:3: Global symbol "$foo" requires expl:3: Global symbol "$foo" requires explicit package name (did you forget to declare "my $foo"?)' Thanks -- Elimar -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20200327124028.noqrzd3mn7luxwbm%40toy.home.lxtec.de.
Re: Patch 8.2.0459
Tony wrote: > Yeah, I see similar errors in Big and Normal, but not in Huge, Small > and Tiny, as follows. My Huge build is the only one with +terminal: > > linux-2iyu:~/.build/vim/vim-hg/src/shadow-big # (make || echo 'exit > status' $? ; date) 2>&1 |tee -a make.log > gcc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK -pthread > -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include > -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo > -I/usr/include/pixman-1 -I/usr/include/libdrm -I/usr/include/libpng16 > -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 > -I/usr/include/harfbuzz -I/usr/include/pango-1.0 > -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include > -I/usr/include/freetype2 -O2 -fno-strength-reduce -Wall -D_REENTRANT > -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1-o objects/evalfunc.o > evalfunc.c > evalfunc.c:919:6: error: ‘f_term_getansicolors’ undeclared here (not > in a function); did you mean ‘term_get_bg_color’? > f_term_getansicolors > ^~~~ > term_get_bg_color > evalfunc.c:938:6: error: ‘f_term_setansicolors’ undeclared here (not > in a function); did you mean ‘f_term_getansicolors’? > f_term_setansicolors > ^~~~ > f_term_getansicolors > make: *** [Makefile:3166: objects/evalfunc.o] Error 1 > exit status 2 > Thu 26 Mar 23:13:54 CET 2020 > linux-2iyu:~/.build/vim/vim-hg/src/shadow-big # Fixed by patch 8.2.0460. -- f y cn rd ths thn y cn hv grt jb n cmptr prgrmmng /// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\ ///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org/// \\\help me help AIDS victims -- http://ICCF-Holland.org/// -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/202003271124.02RBOv2c012377%40masaka.moolenaar.net.
