Typo fixes from maintainer Charles E. Campbell
Hey! Here are typo fixes from maintainer Charles E. Campbell. Their email
turned out to be invalid so I'm contacting the dev maillist instead. Not
sure what the standard operating procedure is for suggesting fixes over
mail, but I've attached a patch file for the fixes.
Dundar Göc.
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/CAGHYH3Cm4K24uD7ibGjoiLHVcWSjsCSqAt2z2-N4GhSrktpeKw%40mail.gmail.com.
From 2bd46d1c6a631f74f55f2269aa009e827f855c09 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dundar=20G=C3=B6c?=
Date: Sun, 5 Sep 2021 14:23:12 +0200
Subject: [PATCH] fix typos from maintainer Charles E. Campbell
---
runtime/autoload/netrw.vim | 8
runtime/autoload/tar.vim | 2 +-
runtime/autoload/zip.vim | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/runtime/autoload/netrw.vim b/runtime/autoload/netrw.vim
index 5ea8319cf..9660a053b 100644
--- a/runtime/autoload/netrw.vim
+++ b/runtime/autoload/netrw.vim
@@ -4267,7 +4267,7 @@ fun! s:NetrwGetBuffer(islocal,dirname)
endif
" call Decho(" bufnum#".bufnum,'~'.expand(""))
- " highjack the current buffer
+ " hijack the current buffer
" IF the buffer already has the desired name
" AND it is empty
let curbuf = bufname("%")
@@ -4275,7 +4275,7 @@ fun! s:NetrwGetBuffer(islocal,dirname)
let curbuf = getcwd()
endif
" call Dredir("ls!","NetrwGetFile (renamed buffer back to remote filename<".rfile."> : expand(%)<".expand("%").">)")
-" call Decho("deciding if netrw may highjack the current buffer#".bufnr("%")."<".curbuf.">",'~'.expand(""))
+" call Decho("deciding if netrw may hijack the current buffer#".bufnr("%")."<".curbuf.">",'~'.expand(""))
" call Decho("..dirname<".dirname."> IF dirname == bufname",'~'.expand(""))
" call Decho("..curbuf<".curbuf.">",'~'.expand(""))
" call Decho("..line($)=".line("$")." AND this is 1",'~'.expand(""))
@@ -4284,7 +4284,7 @@ fun! s:NetrwGetBuffer(islocal,dirname)
" call Dret("s:NetrwGetBuffer 0 : highjacking buffer#".bufnr("%"))
return 0
else " DEBUG
-" call Decho("..did NOT highjack buffer",'~'.expand(""))
+" call Decho("..did NOT hijack buffer",'~'.expand(""))
endif
" Aug 14, 2021: was thinking about looking for a [No Name] buffer here and using it, but that might cause problems
@@ -6845,7 +6845,7 @@ fun! s:NetrwMarkFile(islocal,fname)
" sanity check
if empty(a:fname)
-" call Dret("s:NetrwMarkFile : emtpy fname")
+" call Dret("s:NetrwMarkFile : empty fname")
return
endif
let curdir = s:NetrwGetCurdir(a:islocal)
diff --git a/runtime/autoload/tar.vim b/runtime/autoload/tar.vim
index b6c4c660b..e495e8262 100644
--- a/runtime/autoload/tar.vim
+++ b/runtime/autoload/tar.vim
@@ -778,7 +778,7 @@ fun! tar#Vimuntar(...)
elseif executable("gzip")
silent exe "!gzip -d ".shellescape(tartail)
else
-echoerr "unable to decompress<".tartail."> on this sytem"
+echoerr "unable to decompress<".tartail."> on this system"
if simplify(curdir) != simplify(tarhome)
" remove decompressed tarball, restore directory
" call Decho("delete(".tartail.".tar)")
diff --git a/runtime/autoload/zip.vim b/runtime/autoload/zip.vim
index f6b876df0..9588bbf4a 100644
--- a/runtime/autoload/zip.vim
+++ b/runtime/autoload/zip.vim
@@ -81,7 +81,7 @@ fun! zip#Browse(zipfile)
" sanity checks
if !exists("*fnameescape")
if > 1
-echoerr "the zip plugin is not available (your vim doens't support fnameescape())"
+echoerr "the zip plugin is not available (your vim doesn't support fnameescape())"
endif
return
endif
--
2.33.0
Patch 8.2.3408
Patch 8.2.3408
Problem:Can delete a numbered function. (Naohiro Ono)
Solution: Disallow deleting a numbered function. (closes #8760)
Files: src/userfunc.c, src/testdir/test_user_func.vim
*** ../vim-8.2.3407/src/userfunc.c 2021-09-05 16:36:20.235647849 +0200
--- src/userfunc.c 2021-09-06 20:55:38.984500156 +0200
***
*** 4669,4674
--- 4669,4681
if (eap->nextcmd != NULL)
*p = NUL;
+ if (isdigit(*name) && fudi.fd_dict == NULL)
+ {
+ if (!eap->skip)
+ semsg(_(e_invarg2), eap->arg);
+ vim_free(name);
+ return;
+ }
if (!eap->skip)
fp = find_func(name, is_global, NULL);
vim_free(name);
*** ../vim-8.2.3407/src/testdir/test_user_func.vim 2021-05-25
20:13:56.316778428 +0200
--- src/testdir/test_user_func.vim 2021-09-06 20:55:11.704583952 +0200
***
*** 434,439
--- 434,444
func d.fn()
return 1
endfunc
+
+ " cannot delete the dict function by number
+ let nr = substitute(execute('echo d'), '.*function(''\(\d\+\)'').*', '\1',
'')
+ call assert_fails('delfunction g:' .. nr, 'E475: Invalid argument: g:')
+
delfunc d.fn
call assert_equal({'a' : 10}, d)
endfunc
*** ../vim-8.2.3407/src/version.c 2021-09-06 19:19:41.595784061 +0200
--- src/version.c 2021-09-06 20:56:11.508400893 +0200
***
*** 757,758
--- 757,760
{ /* Add new patch number below this line */
+ /**/
+ 3408,
/**/
--
The average life of an organization chart is six months. You can safely
ignore any order from your boss that would take six months to complete.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202109061857.186IvR621436373%40masaka.moolenaar.net.
Patch 8.2.3407
Patch 8.2.3407
Problem:Using uninitialized memory with "let g:['bar'] = 2".
Solution: Initialize v_type of a new dict item.
Files: src/dict.c
*** ../vim-8.2.3406/src/dict.c 2021-08-12 19:27:46.458459623 +0200
--- src/dict.c 2021-09-06 19:18:18.427937934 +0200
***
*** 229,234
--- 229,235
STRCPY(di->di_key, key);
di->di_flags = DI_FLAGS_ALLOC;
di->di_tv.v_lock = 0;
+ di->di_tv.v_type = VAR_UNKNOWN;
}
return di;
}
*** ../vim-8.2.3406/src/version.c 2021-09-06 18:57:25.270231387 +0200
--- src/version.c 2021-09-06 19:18:37.427903206 +0200
***
*** 757,758
--- 757,760
{ /* Add new patch number below this line */
+ /**/
+ 3407,
/**/
--
A consultant is a person who takes your money and annoys your employees while
tirelessly searching for the best way to extend the consulting contract.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202109061720.186HKXVG1415269%40masaka.moolenaar.net.
Patch 8.2.3406
Patch 8.2.3406
Problem:On some systems tests fail without _REENTRANT. (Elimar
Riesebieter)
Solution: Add -D_REENTRANT in configure. (closes #7402)
Files: src/configure.ac, src/auto/configure
*** ../vim-8.2.3405/src/configure.ac2021-06-23 15:41:49.352102395 +0200
--- src/configure.ac2021-09-06 18:54:49.130622625 +0200
***
*** 4504,4509
--- 4504,4515
fi
fi
+ dnl On some systems REENTRANT needs to be defined. It should not hurt to use
+ dnl it everywhere.
+ if `echo "$CFLAGS" | grep -v D_REENTRANT >/dev/null`; then
+ CFLAGS="$CFLAGS -D_REENTRANT"
+ fi
+
dnl gcc 3.1 changed the meaning of -MM. The only solution appears to be to
dnl use "-isystem" instead of "-I" for all non-Vim include dirs.
dnl But only when making dependencies, cproto and lint don't take "-isystem".
*** ../vim-8.2.3405/src/auto/configure 2021-06-23 15:41:49.356102386 +0200
--- src/auto/configure 2021-09-06 18:53:33.258814628 +0200
***
*** 14960,14965
--- 14960,14969
fi
fi
+ if `echo "$CFLAGS" | grep -v D_XEENTRANT >/dev/null`; then
+ CFLAGS="$CFLAGS -D_REENTRANT"
+ fi
+
DEPEND_CFLAGS_FILTER=
if test "$GCC" = yes; then
{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for GCC 3 or later" >&5
*** ../vim-8.2.3405/src/version.c 2021-09-06 17:10:55.073336145 +0200
--- src/version.c 2021-09-06 18:56:31.946364458 +0200
***
*** 757,758
--- 757,760
{ /* Add new patch number below this line */
+ /**/
+ 3406,
/**/
--
If someone questions your market projections, simply point out that your
target market is "People who are nuts" and "People who will buy any damn
thing". Nobody is going to tell you there aren't enough of those people
to go around.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202109061658.186GwcLa1410460%40masaka.moolenaar.net.
Re: Test failure building 8.2.3404
* Dominique Pellé [2021-09-05 22:48 +0200]: > Bram Moolenaar wrote: > > > Elimar Riesebieter wrote: > > > > > Environment: amd64 > > > Shell: zsh > > > Term: tmux session > > > Compiler: clang-12 > > > LANG: C > > > > > > Hi all, > > > > > > Building 8.2.3404 gives me > > > > > > ### > > > Failures: > > > From test_signals.vim: > > > Found errors in Test_deadly_signal_TERM(): > > > Run 1: > > > command line..script > > > /source/vim/vim-8.2.3404/src/vim-nox/testdir/runtest.vim[486]..function > > > RunTheTest[44]..Test_deadly_signal_TERM line 35: Expected ['VimLeavePre > > > triggered', 'VimLeave triggered'] but got ['VimLeavePre triggered'] > > > Run 2: > > > command line..script > > > /source/vim/vim-8.2.3404/src/vim-nox/testdir/runtest.vim[520]..function > > > RunTheTest[44]..Test_deadly_signal_TERM line 35: Expected ['VimLeavePre > > > triggered', 'VimLeave triggered'] but got ['VimLeavePre triggered'] > > > Run 3: > > > command line..script > > > /source/vim/vim-8.2.3404/src/vim-nox/testdir/runtest.vim[520]..function > > > RunTheTest[44]..Test_deadly_signal_TERM line 35: Expected ['VimLeavePre > > > triggered', 'VimLeave triggered'] but got ['VimLeavePre triggered'] > > > Flaky test failed too often, giving up > > > > > > TEST FAILURE > > > ### > > > > It's unrelated to the 8.2.3404 patch, with what patch did it start > > failing? > > > > CI doesn't report this error. Does the failure go away when you change > > something in your setup? e.g. not use tmux or use another shell. > > This failure looks related or maybe similar to > https://github.com/vim/vim/issues/7402 > > There it was found that building Vim with `-D_REENTRANT` fixes it. > > Can you confirm Elimar? Indeed adding -D_REENTRANT to the CFLAGS (CPPFLAGS) fixes the issue. Thanks Elimar -- On the keyboard of life you have always to keep a finger at the escape key;-) -- -- You received this message from the "vim_dev" maillist. Do not top-post! Type your reply below the text you are replying to. For more information, visit http://www.vim.org/maillist.php --- You received this message because you are subscribed to the Google Groups "vim_dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/vim_dev/20210906153211.x236ukyt634hnfiq%40baumbart.home.lxtec.de.
Patch 8.2.3405
Patch 8.2.3405
Problem:Cannot have a comment line in a {} block of a user command.
Solution: Continue after the line break. (closes #8837)
Files: src/ex_docmd.c, src/testdir/test_usercommands.vim
*** ../vim-8.2.3404/src/ex_docmd.c 2021-08-24 21:55:58.337276558 +0200
--- src/ex_docmd.c 2021-09-06 17:09:25.213508642 +0200
***
*** 2807,2813
--- 2807,2822
// ignore comment and empty lines
if (comment_start(eap->cmd, starts_with_colon))
+ {
+ // a comment ends at a NL
+ if (eap->nextcmd == NULL)
+ {
+ eap->nextcmd = vim_strchr(eap->cmd, '\n');
+ if (eap->nextcmd != NULL)
+ ++eap->nextcmd;
+ }
return FAIL;
+ }
if (*eap->cmd == NUL)
{
if (!skip_only)
*** ../vim-8.2.3404/src/testdir/test_usercommands.vim 2021-08-05
20:39:59.354053658 +0200
--- src/testdir/test_usercommands.vim 2021-09-06 15:58:59.701206689 +0200
***
*** 624,630
func Test_usercmd_with_block()
command DoSomething {
! g:didit = 'yes'
g:didmore = 'more'
}
DoSomething
--- 624,631
func Test_usercmd_with_block()
command DoSomething {
! g:didit = 'yes' # comment
! # comment line
g:didmore = 'more'
}
DoSomething
*** ../vim-8.2.3404/src/version.c 2021-09-05 16:36:20.239647841 +0200
--- src/version.c 2021-09-06 17:10:36.073372626 +0200
***
*** 757,758
--- 757,760
{ /* Add new patch number below this line */
+ /**/
+ 3405,
/**/
--
I learned the customs and mannerisms of engineers by observing them, much the
way Jane Goodall learned about the great apes, but without the hassle of
grooming.
(Scott Adams - The Dilbert principle)
/// Bram Moolenaar -- b...@moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--
--
You received this message from the "vim_dev" maillist.
Do not top-post! Type your reply below the text you are replying to.
For more information, visit http://www.vim.org/maillist.php
---
You received this message because you are subscribed to the Google Groups
"vim_dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to vim_dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/vim_dev/202109061511.186FBUiM1378019%40masaka.moolenaar.net.
